Commit 80b80e0
committed
probe: wrong unit, an unsupported bound, and a checked ternlog claim
Three coderabbit findings on 5385ebf. Two are errors the PREVIOUS correction
introduced, which is the third generation of one defect class in this PR and the
thing worth recording.
1. The unit was OBSERVATIONS, not widths. The sweep visits 2 bases x 7 k = 14
distinct widths and repeats them 7 times, so the counter tops out at 98
samples of 14 widths. "7 of 98 widths" invents 84 widths that do not exist.
The measured numbers are unchanged; what was wrong is what they counted.
2. "the gap is a LOWER BOUND on any true difference" is withdrawn. Truncation
compresses the observed gap toward zero — but only from whichever side the
truly cheaper arm sits on, and which arm that is is exactly what this sample
cannot say. A bound needs the sign first. Replaced with: selection-biased,
direction and magnitude unresolved. That is strictly more honest and costs
nothing, because the decision never rested on the size of D - F, only on the
absence of support for the expensive option.
3. Asked for a rustdoc example on `probe_fixed4_ternlog`. Declined as asked, and
done better: this file is in `examples/`, where rustdoc never runs, so a ```
block would be an untested assertion dressed as a verified one — the exact
thing this PR spent its time removing. `main` now asserts the semantics
instead, so the claim is checked on every run.
That assertion earned its place immediately: it rejected the expected value I
had written from doing the arithmetic in my head. I had 0xF0F0 & 0x0F0F as
0x0F00 when the nibbles do not overlap at all, so it is 0x0000, and majority
is 0x00FF rather than 0x0FFF. A truth table transcribed one bit off would
still emit plausible `vpternlogq` and survive a read of the assembly — and so
would a doc example nobody executes.
Blackboard (17) corrects (16) on both counts and tabulates all five instances of
the class, with the mechanical sweep that finds them faster than review does:
for every printed line, name the accumulator behind it, its UNIT and its SCOPE,
then check the words against all three.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DCfrD5y19cvFc4AoyydXYv1 parent 5385ebf commit 80b80e0
3 files changed
Lines changed: 113 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
1 | 66 | | |
2 | 67 | | |
3 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
418 | 418 | | |
419 | 419 | | |
420 | 420 | | |
421 | | - | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
422 | 427 | | |
423 | 428 | | |
424 | 429 | | |
| |||
580 | 585 | | |
581 | 586 | | |
582 | 587 | | |
583 | | - | |
| 588 | + | |
584 | 589 | | |
585 | 590 | | |
586 | 591 | | |
| |||
601 | 606 | | |
602 | 607 | | |
603 | 608 | | |
604 | | - | |
605 | | - | |
606 | | - | |
607 | | - | |
| 609 | + | |
| 610 | + | |
| 611 | + | |
| 612 | + | |
| 613 | + | |
| 614 | + | |
| 615 | + | |
| 616 | + | |
| 617 | + | |
| 618 | + | |
| 619 | + | |
| 620 | + | |
| 621 | + | |
608 | 622 | | |
609 | 623 | | |
610 | 624 | | |
| |||
632 | 646 | | |
633 | 647 | | |
634 | 648 | | |
635 | | - | |
| 649 | + | |
| 650 | + | |
636 | 651 | | |
637 | 652 | | |
638 | 653 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
132 | 147 | | |
133 | 148 | | |
134 | 149 | | |
| |||
168 | 183 | | |
169 | 184 | | |
170 | 185 | | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
171 | 196 | | |
172 | 197 | | |
| 198 | + | |
173 | 199 | | |
174 | 200 | | |
175 | 201 | | |
| |||
0 commit comments