From fef80b65fab863b186a2a892dc8992ed9399c41e Mon Sep 17 00:00:00 2001 From: Antony Rizzitelli Date: Fri, 20 Nov 2026 21:53:59 +0000 Subject: [PATCH 1/2] fix(ci-node): build what the tests read in Stress again with typecheck #93 left only checks:prepare in the Stress build step. A caller whose tests read the output of typecheck, such as dms-saas and its dist/, failed every Stress run of the nightly tier since. --- .github/workflows/ci-node.yml | 4 +++- README.md | 7 ++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-node.yml b/.github/workflows/ci-node.yml index 40b419d..6581265 100644 --- a/.github/workflows/ci-node.yml +++ b/.github/workflows/ci-node.yml @@ -528,7 +528,9 @@ jobs: ci-node-${{ runner.os }}-${{ fromJSON(inputs.node-versions || '[""]')[0] || 'nvmrc' }}- - name: Build what the tests read - run: pnpm run --if-present checks:prepare + run: | + pnpm run --if-present checks:prepare + pnpm run --if-present typecheck - name: Start services id: services diff --git a/README.md b/README.md index 77031bf..6fa7ee3 100644 --- a/README.md +++ b/README.md @@ -588,9 +588,10 @@ a nightly run never retries a failed test or failed `extra-commands`. In the `nightly` tier only, after the Node.js jobs, the `Stress` job looks for tests that pass alone but time out under load. On Linux, with the first -`node-versions` entry or `.nvmrc`, it installs, runs `setup-commands` and -`checks:prepare`, starts the services, then runs `pnpm run test` three times -beside four busy loops per CPU. The loops take CPU time from the test runner's +`node-versions` entry or `.nvmrc`, it installs, runs `setup-commands`, +`checks:prepare` and `typecheck`, starts the services, then runs `pnpm run test` +three times beside four busy loops per CPU. `typecheck` builds what the tests +read after `pnpm run checks` in the Node.js job, such as a `dist/` folder. The loops take CPU time from the test runner's workers, as a loaded machine does, while the workers keep the count the runner picks from the CPUs it sees. It fails when any run fails, and its summary counts the failed runs. A pull request never runs it, and a caller sets nothing From 66c32ea4e7aa59f3246f7337fdf131f33dacf298 Mon Sep 17 00:00:00 2001 From: Antony Rizzitelli Date: Fri, 20 Nov 2026 21:59:26 +0000 Subject: [PATCH 2/2] docs(ci-node): say why Stress runs typecheck --- README.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 6fa7ee3..ca69ac7 100644 --- a/README.md +++ b/README.md @@ -590,12 +590,13 @@ In the `nightly` tier only, after the Node.js jobs, the `Stress` job looks for tests that pass alone but time out under load. On Linux, with the first `node-versions` entry or `.nvmrc`, it installs, runs `setup-commands`, `checks:prepare` and `typecheck`, starts the services, then runs `pnpm run test` -three times beside four busy loops per CPU. `typecheck` builds what the tests -read after `pnpm run checks` in the Node.js job, such as a `dist/` folder. The loops take CPU time from the test runner's -workers, as a loaded machine does, while the workers keep the count the runner -picks from the CPUs it sees. It fails when any run fails, and its summary -counts the failed runs. A pull request never runs it, and a caller sets nothing -for it. +three times beside four busy loops per CPU. The loops take CPU time from the +test runner's workers, as a loaded machine does, while the workers keep the +count the runner picks from the CPUs it sees. It fails when any run fails, and +its summary counts the failed runs. A pull request never runs it, and a caller +sets nothing for it. It runs no `pnpm run checks`, so `typecheck` gives the +tests the build, such as a `dist/` folder, that `checks` gives them in the +Node.js job. On a pull request and in the merge queue, each job fetches the target branch into `origin/`, such as `origin/main`, and the diff base into the