From e85fbeb3cca19bbf7e69e8b34742e435bcacbb04 Mon Sep 17 00:00:00 2001 From: Ayush Tiwari <147244828+Ayushdevo@users.noreply.github.com> Date: Thu, 12 Nov 2026 21:16:42 +0530 Subject: [PATCH] Stabilize constant-feature detection and validate inputs --- sentinelml/drift/sanitizer.py | 16 ++++++++++++++-- tests/test_constant_feature_sanitizer.py | 23 +++++++++++++++++++++++ 2 files changed, 37 insertions(+), 2 deletions(-) create mode 100644 tests/test_constant_feature_sanitizer.py diff --git a/sentinelml/drift/sanitizer.py b/sentinelml/drift/sanitizer.py index 4e24850..495bd11 100644 --- a/sentinelml/drift/sanitizer.py +++ b/sentinelml/drift/sanitizer.py @@ -1,3 +1,5 @@ +from numbers import Real + import numpy as np from typing import Tuple @@ -21,5 +23,15 @@ def sanitize_arrays(baseline: np.ndarray, current: np.ndarray) -> Tuple[np.ndarr @staticmethod def is_constant_feature(data: np.ndarray, tolerance: float = 1e-8) -> bool: - """Flags degenerate zero-variance features to prevent division by zero in bucket calculations.""" - return bool(np.std(data) < tolerance) + """Flag low-variance finite samples using an absolute standard-deviation tolerance.""" + if (isinstance(tolerance, bool) or not isinstance(tolerance, Real) + or not np.isfinite(tolerance) or tolerance < 0): + raise ValueError("tolerance must be a finite nonnegative number") + clean, _ = DataSanitizer.sanitize_arrays(data, data) + scale = np.max(np.abs(clean)) + if scale == 0: + return tolerance > 0 + normalized_std = np.std(clean / scale) + if normalized_std == 0: + return tolerance > 0 + return bool(normalized_std * scale < tolerance) diff --git a/tests/test_constant_feature_sanitizer.py b/tests/test_constant_feature_sanitizer.py new file mode 100644 index 0000000..cce7fd0 --- /dev/null +++ b/tests/test_constant_feature_sanitizer.py @@ -0,0 +1,23 @@ +import numpy as np +import pytest + +from sentinelml.drift.sanitizer import DataSanitizer + + +def test_constant_feature_handles_extreme_finite_values(): + with np.errstate(over="raise", invalid="raise"): + assert DataSanitizer.is_constant_feature([1e308, 1e308]) + assert DataSanitizer.is_constant_feature([-1e308, 1e308], tolerance=1.1e308) + assert not DataSanitizer.is_constant_feature([-1e308, 1e308], tolerance=0.9e308) + + +def test_constant_feature_ignores_nonfinite_values_but_requires_finite_sample(): + assert DataSanitizer.is_constant_feature([np.nan, 7., np.inf, 7.]) + with pytest.raises(ValueError, match="finite samples"): + DataSanitizer.is_constant_feature([np.nan, np.inf]) + + +@pytest.mark.parametrize("tolerance", [True, -1., np.nan, np.inf, "bad"]) +def test_constant_feature_rejects_invalid_tolerance(tolerance): + with pytest.raises(ValueError, match="tolerance"): + DataSanitizer.is_constant_feature([1., 1.], tolerance=tolerance)