Skip to content

Commit 5feb6bd

Browse files
authored
Merge pull request #501 from Breeding-Insight/feature/BI-3089
Re-enable entry number sorting/filtering
2 parents e85fd70 + 047331f commit 5feb6bd

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎package-lock.json‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/breeding-insight/model/Sort.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ export class ProgramSort {
160160

161161
// germplasm
162162
export enum GermplasmSortField {
163-
ImportEntryNumber = "importEntryNumber",
163+
ListEntryNumber = "listEntryNumber",
164164
AccessionNumber = "accessionNumber",
165165
DefaultDisplayName = "defaultDisplayName",
166166
BreedingMethod = "breedingMethod",

‎src/components/germplasm/GermplasmTable.vue‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@
77
v-on:show-error-notification="$emit('show-error-notification', $event)"
88
backend-sorting
99
backend-filtering
10-
v-bind:default-sort="entryNumberVisible ? [fieldMap['importEntryNumber'], 'ASC'] : [fieldMap['accessionNumber'], 'DESC']"
10+
v-bind:default-sort="entryNumberVisible ? [fieldMap['listEntryNumber'], 'ASC'] : [fieldMap['accessionNumber'], 'DESC']"
1111
v-on:sort="setSort"
1212
v-on:search="initSearch"
1313
v-bind:search-debounce="400"
1414
v-bind:is-show-all-enabled="false"
1515
>
16-
<b-table-column v-if="entryNumberVisible" field="importEntryNumber" label="Entry Number" v-slot="props" :th-attrs="(column) => ({scope:'col'})">
16+
<b-table-column v-if="entryNumberVisible" field="listEntryNumber" label="Entry Number" sortable v-slot="props" :th-attrs="(column) => ({scope:'col'})" searchable>
1717
{{ GermplasmUtils.getEntryNumber(props.row.data, referenceId) }}
1818
</b-table-column>
1919
<b-table-column field="accessionNumber" label="GID" sortable v-slot="props" :th-attrs="(column) => ({scope:'col'})" searchable>
@@ -127,7 +127,7 @@ export default class GermplasmTable extends Vue {
127127
private germplasmCallStack?: CallStack;
128128
129129
private fieldMap: any = {
130-
'importEntryNumber': GermplasmSortField.ImportEntryNumber,
130+
'listEntryNumber': GermplasmSortField.ListEntryNumber,
131131
'accessionNumber': GermplasmSortField.AccessionNumber,
132132
'defaultDisplayName' : GermplasmSortField.DefaultDisplayName,
133133
'breedingMethod': GermplasmSortField.BreedingMethod,

‎src/store/sorting/index.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ state = {
6767
germplasmSort: new GermplasmSort(GermplasmSortField.AccessionNumber, SortOrder.Descending),
6868

6969
// germplasm (by list) table
70-
germplasmByListSort: new GermplasmSort(GermplasmSortField.ImportEntryNumber, SortOrder.Ascending),
70+
germplasmByListSort: new GermplasmSort(GermplasmSortField.ListEntryNumber, SortOrder.Ascending),
7171

7272
// germplasm list table
7373
germplasmListSort: new GermplasmListSort(GermplasmListSortField.CreatedDate, SortOrder.Descending),

0 commit comments

Comments
 (0)