From 24e37efa1cba4b14be03e463a7119d8cb78f7635 Mon Sep 17 00:00:00 2001
From: TheWitness <copilot@users.noreply.github.com>
Date: Tue, 29 Sep 2026 14:32:07 -0400
Subject: [PATCH] ci: drop inert COMPOSER_ROOT_VERSION from the Pest step

COMPOSER_ROOT_VERSION only influences Composer root-version detection, which
does not run in the "Run Pest Unit Tests" step (Composer install happens in
an earlier step). Removing it from that step's env; no behaviour change.

Part of harmonizing the patch-coverage CI convention across the plugin fleet.
---
 .github/workflows/plugin-ci-workflow.yml | 2 --
 CHANGELOG.md                             | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/.github/workflows/plugin-ci-workflow.yml b/.github/workflows/plugin-ci-workflow.yml
index 16f4934c..9834da12 100644
--- a/.github/workflows/plugin-ci-workflow.yml
+++ b/.github/workflows/plugin-ci-workflow.yml
@@ -192,8 +192,6 @@ jobs:
       run: echo -n "${{ env.CACTI }}" | sudo tee ${{ github.workspace }}/cacti/plugins/thold/tests/.cacti-version > /dev/null
 
     - name: Run Pest Unit Tests
-      env:
-        COMPOSER_ROOT_VERSION: 1.3.0-dev
       run: |
         cd ${{ github.workspace }}/cacti
         include/vendor/bin/pest --configuration=plugins/thold/phpunit.xml \
diff --git a/CHANGELOG.md b/CHANGELOG.md
index c5bbf547..c10e5a86 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## ChangeLog
 
 --- develop ---
+* dev: Remove the inert COMPOSER_ROOT_VERSION env from the Pest CI step
 * feature: Restyle the Thold, Host status and Log status legends as rounded, evenly-spaced solid-colour chips for a clearer, more readable status key across every theme
 * security: Add a version-safe CSP nonce (`plugin_thold_csp_nonce()`) to every inline `<script>` tag so pages stay compatible with Cacti's Content-Security-Policy nonce enforcement, while falling back cleanly on older Cacti releases that lack the `CactiSecureHeaders` class
 * issue: Center-align the "Not Monitored" status cell on the Device Status page (thold_graph.php) so it matches the other status values instead of rendering right-aligned