From 956cf0ef920b3727dae299ac632f4a0ef633e033 Mon Sep 17 00:00:00 2001 From: Dipa-Sarker Date: Thu, 6 Aug 2026 21:24:32 +0100 Subject: [PATCH 1/2] fix book library app bugs --- debugging/book-library/debugging-notes.md | 61 +++++++++++++++++++++++ debugging/book-library/index.html | 4 +- debugging/book-library/script.js | 30 +++++++---- 3 files changed, 82 insertions(+), 13 deletions(-) create mode 100644 debugging/book-library/debugging-notes.md diff --git a/debugging/book-library/debugging-notes.md b/debugging/book-library/debugging-notes.md new file mode 100644 index 00000000..fa3945f0 --- /dev/null +++ b/debugging/book-library/debugging-notes.md @@ -0,0 +1,61 @@ +# HTML Debugging Checklist + +## Page Structure + +## Book Input Form + +## Add Book Button + +## Book Display Area + +## Delete Functionality + +## Read Status + +## Validation Support + +## Browser Testing + + +# JavaScript Debugging Checklist + +## Library Data Storage + +## Page Loading + +## Add Book Function + +## Book Constructor + +## Render Function + +## Read/Unread Button + +## Delete Button + +## Console Errors + + +## Final Testing +- [ ] Add a book with all information +- [ ] Add a book without title +- [ ] Add a book without author +- [ ] Add a book without pages +- [ ] Add a read book +- [ ] Add an unread book +- [ ] Delete a book +- [ ] Change read/unread status + +# HTML correction: +- input type +- submit function +- +# Script.js correction: +- delete e from addEventListener +- correct book name +- add input validation for author value in submit() function +- add author.value replacing title.value in new Book() +- replace library by myLibrary +- correct check == true/false and made correction for readstatus = yes/no for read button +- correct variable name delBut > delButton +- correct clicks > click \ No newline at end of file diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..2628651d 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -31,7 +31,7 @@

Library

Library /> myLibrary render(); } } @@ -54,7 +58,7 @@ function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells @@ -76,7 +80,10 @@ function render() { changeBut.className = "btn btn-success"; wasReadCell.appendChild(changeBut); let readStatus = ""; - if (myLibrary[i].check == false) { + if (myLibrary[i].check == true) { + // correct for read button, if user checks reads, + // it sould be check == true & button shows yes, but previuos it was false > yes, ture > no, means + // reverse readStatus = "Yes"; } else { readStatus = "No"; @@ -90,11 +97,12 @@ function render() { //add delete button to every row and render again let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + delButton.id = i + 5; // correct variable name delBut > delButton + deleteCell.appendChild(delButton); + delButton.className = "btn btn-warning"; + delButton.innerHTML = "Delete"; + delButton.addEventListener("click", function () { + // correct clicks > click alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); From 6a246e7c78442e52a8a0614231136dc2568f0db3 Mon Sep 17 00:00:00 2001 From: Dipa-Sarker Date: Mon, 10 Aug 2026 00:19:59 +0100 Subject: [PATCH 2/2] made correction according to general feedback --- debugging/book-library/index.html | 27 +++---- debugging/book-library/script.js | 113 +++++++++++++++--------------- 2 files changed, 67 insertions(+), 73 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 2628651d..5934f53a 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,12 +1,9 @@ - + - - + Book Library + + @@ -28,6 +25,7 @@

Library

+
Library class="form-control" id="pages" name="pages" + min ="1" required />
+
@@ -80,17 +79,9 @@

Library

- - - - - - - - - +
- + diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index e60c5b5d..17e31caa 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -8,11 +8,11 @@ window.addEventListener("load", function () { function populateStorage() { if (myLibrary.length == 0) { - let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); //correct book name - let book2 = new Book( + const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true); //correct book name + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", - "127", + 127, true ); myLibrary.push(book1); @@ -21,31 +21,44 @@ function populateStorage() { } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); //rename all variable names +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const checkInput = document.getElementById("check"); +const bookForm = document.getElementById("bookForm"); + //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { + const title = titleInput.value.trim(); //use .trim() to remove extra spaces + const author = authorInput.value.trim(); + const pages = Number(pagesInput.value); if ( - title.value == null || - title.value == "" || - author.value == null || //need input validation for author value, added this - author.value == "" || - pages.value == null || - pages.value == "" + title === "" || + + author === "" || //need input validation for author value, added this + + pagesInput.value === "" ) { alert("Please fill all fields!"); return false; - } else { - let book = new Book(title.value, author.value, pages.value, check.checked); //added author.value by + } + if (pages < 1) { + alert("Pages must be at least 1!"); + return false; + } + + const book = new Book(title, author, pages, checkInput.checked); //added author.value by // replacing 2nd title.value to author.value myLibrary.push(book); //corrected name for original array library > myLibrary render(); - } } +bookForm.addEventListener("submit", function (event) { //after user submits the book form +// this will run submit () function to add book + event.preventDefault(); + submit(); +}); function Book(title, author, pages, check) { this.title = title; @@ -55,57 +68,47 @@ function Book(title, author, pages, check) { } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); - } + // delete all old row at once + const library = document.getElementById("library"); //newly created id for cleaning all existing row + + library.innerHTML = ""; //clean all old rows + //insert updated row and cells - let length = myLibrary.length; + const length = myLibrary.length; for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + const row = library.insertRow(); + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + titleCell.textContent = myLibrary[i].title; // replaced all innerHTML by textContent + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == true) { - // correct for read button, if user checks reads, - // it sould be check == true & button shows yes, but previuos it was false > yes, ture > no, means - // reverse - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { + const changeButton = document.createElement("button"); //correct changeBut > changeButton + changeButton.id = i; + changeButton.className = "btn btn-success"; + wasReadCell.appendChild(changeButton); + const readStatus = myLibrary[i].check ? "Yes" : "No"; + changeButton.textContent = readStatus; + changeButton.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); //add delete button to every row and render again - let delButton = document.createElement("button"); - delButton.id = i + 5; // correct variable name delBut > delButton - deleteCell.appendChild(delButton); - delButton.className = "btn btn-warning"; - delButton.innerHTML = "Delete"; - delButton.addEventListener("click", function () { + let deleteButton = document.createElement("button"); + deleteCell.appendChild(deleteButton); + deleteButton.className = "btn btn-warning"; + deleteButton.textContent = "Delete"; + deleteButton.addEventListener("click", function () { // correct clicks > click - alert(`You've deleted title: ${myLibrary[i].title}`); + const deletedTitle = myLibrary[i].title; //save the book title which should have to delete myLibrary.splice(i, 1); render(); + alert(`You've deleted title: ${deletedTitle}`); }); } }