From d2654347275e986f99a80e8c4ba555abcc6e7bad Mon Sep 17 00:00:00 2001 From: Daniel Gergely Date: Mon, 9 Nov 2026 09:11:10 +0100 Subject: [PATCH] [T3663] FIX: don't print B2S letters whose page images can't be loaded --- .../models/partner_communication.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/partner_communication_compassion/models/partner_communication.py b/partner_communication_compassion/models/partner_communication.py index 86e62946d..2c183343e 100644 --- a/partner_communication_compassion/models/partner_communication.py +++ b/partner_communication_compassion/models/partner_communication.py @@ -44,6 +44,14 @@ def get_correspondence_attachments(self, letters=None): if self.send_mode == "physical": for letter in letters: try: + pages = letter.page_ids.filtered( + lambda p: p.original_page_url or p.final_page_url + ) + # Without a stored PDF, the pages are composed on their images + if not letter.sponsor_letter_scan and not all( + page.fetch_image() for page in pages + ): + raise MissingError(_("Letter image could not be loaded")) attachments[letter.file_name] = [ report, self._convert_pdf(letter.get_pdf()),