From d2ce19f9501c28c87066dca63300ab68148ab8c9 Mon Sep 17 00:00:00 2001 From: David Wulliamoz Date: Fri, 13 Nov 2026 15:31:26 +0100 Subject: [PATCH] FIX: division by zero in origin conversion rate when an origin only has sub sponsorships Assigning a SUB sponsorship to an origin whose contracts all have a parent raised ZeroDivisionError in _compute_won_sponsorships. Compute the stats for every origin (reset when no contract left), default the rate to 0 and also depend on contract parent_id/state. Assisted-by: claude-opus-5-5, medium, claude-code --- sponsorship_compassion/models/contract_origin.py | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/sponsorship_compassion/models/contract_origin.py b/sponsorship_compassion/models/contract_origin.py index 0da70203c..1c497092e 100644 --- a/sponsorship_compassion/models/contract_origin.py +++ b/sponsorship_compassion/models/contract_origin.py @@ -96,9 +96,14 @@ def _get_origin_types(self): ("other", _("Other")), ] - @api.depends("contract_ids.origin_id", "contract_ids.activation_date") + @api.depends( + "contract_ids.origin_id", + "contract_ids.activation_date", + "contract_ids.parent_id", + "contract_ids.state", + ) def _compute_won_sponsorships(self): - for origin in self.filtered("contract_ids"): + for origin in self: # not tacking sponsors with parent_id or in cancelled state. contract_ids = origin.contract_ids.filtered(lambda c: not c.parent_id) origin.won_sponsorships = len( @@ -107,9 +112,9 @@ def _compute_won_sponsorships(self): # sponsor who cancelled their sponsorship are used to compute # conversion_rate to avoid bias origin.conversion_rate = ( - len(contract_ids.filtered("activation_date")) - / float(len(contract_ids)) - * 100 + len(contract_ids.filtered("activation_date")) / len(contract_ids) * 100 + if contract_ids + else 0.0 ) ##########################################################################