Skip to content

Installation feedback from copilot#3232

Description

@RWOverdijk

馃憢 Copilot has feedback on us adding graphify.

In .opencode/skills/graphify/references/update.md:64:

The code-only update path never creates .graphify_extract.json: Step 3A writes only .graphify_ast.json, while the later merge immediately reads .graphify_extract.json at line 93 (and the normal cleanup removes that file). Every incremental update containing only source-code changes will therefore fail. Write the empty semantic result and run Step 3C before entering the incremental merge.

In .opencode/skills/graphify/SKILL.md:53:

This executes a user-supplied question by textual substitution into a shell command. The same pattern is used for paths, URLs, and generated answers in the referenced runbooks; quotes, $(), or backticks in otherwise valid developer input can break or alter the command. Pass these values through argument arrays or a safely serialized file rather than interpolating them into shell/Python snippets throughout the integration.

This issue also appears on line 88 of the same file.

The second point makes sense, it's how this whole project functions, but I did notice it failing several times. I also noticed the llm pasting the full user prompt as the question instead of extracting from it what is relevant.

As a last, but separate note: I also noticed that installation adds graphify to ./opencode/opencode.json with the wrong path. It doesn't have to be added at all, opencode picks up plugins automatically. ETA: found a related issue for this point.

ETA: Huge fan, graphify is the first thing i set up for all projects I work on 馃槃

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions