Currently, TelemetrySelectionStrategy.ensureSamplesHaveDownlinkRate(List<FrameSample> samples) checks all samples retrieved from the telemetry source for consistent frame size bits values, not just the samples currently being considered in a candidate sample set/window. This presents problems for missions where short and long frames are frequently mixed in a 24h window, as MMTC will refuse to run even when VCID groups are correctly configured to distinguish short from long frames.
It might be preferable to only apply consistent frame size validation after the VCID filter has already been applied as to avoid tossing out whole frame sample sets that likely contain valid candidate subsets just because some frames in the query window aren't the same size.
Currently,
TelemetrySelectionStrategy.ensureSamplesHaveDownlinkRate(List<FrameSample> samples)checks all samples retrieved from the telemetry source for consistent frame size bits values, not just the samples currently being considered in a candidate sample set/window. This presents problems for missions where short and long frames are frequently mixed in a 24h window, as MMTC will refuse to run even when VCID groups are correctly configured to distinguish short from long frames.It might be preferable to only apply consistent frame size validation after the VCID filter has already been applied as to avoid tossing out whole frame sample sets that likely contain valid candidate subsets just because some frames in the query window aren't the same size.