From 6cbae8001d998581301db863572b079d029ceac2 Mon Sep 17 00:00:00 2001 From: Simone Rubino Date: Tue, 8 Sep 2026 15:12:35 +0200 Subject: [PATCH] [IMP] base_geoengine: Work around missing required field Steps: 1. In the filesystem, delete a view from module `database_cleanup` 2. Install `base_geoengine` and `database_cleanup` 3. Restore the deleted view 4. Update `database_cleanup` Current: ERROR: null value in column "projection" of relation "ir_ui_view" violates not-null constraint Expected: The module updates Work around for https://github.com/odoo/odoo/issues/286530. --- base_geoengine/models/ir_view.py | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/base_geoengine/models/ir_view.py b/base_geoengine/models/ir_view.py index 253430bef..8a50c185d 100644 --- a/base_geoengine/models/ir_view.py +++ b/base_geoengine/models/ir_view.py @@ -20,7 +20,7 @@ class IrUIView(models.Model): "geoengine.vector.layer", "view_id", "Vector layers", required=True ) - projection = fields.Char(default="EPSG:3857", required=True) + projection = fields.Char(default="EPSG:3857") default_extent = fields.Char( "Default map extent", default="-123164.85222423, 5574694.9538936, 1578017.6490538," @@ -29,6 +29,18 @@ class IrUIView(models.Model): default_zoom = fields.Integer("Default map zoom") restricted_extent = fields.Char("Restricted map extent") + # Using a SQL Constraint + # because adding a new required field to this very low-level module + # might create a race condition during update, + # see https://github.com/odoo/odoo/issues/286530. + _sql_constraints = [ + ( + "geoengine_projection_required", + "CHECK(type <> 'geoengine' OR COALESCE(projection, '') <> '')", + "A GeoEngine view must have a Projection.", + ), + ] + def _is_qweb_based_view(self, view_type): if view_type == "geoengine": return True