From 6e476d1a5741b169823edd99b1aa0d8ca162699e Mon Sep 17 00:00:00 2001 From: pelesh Date: Wed, 30 Sep 2026 15:07:24 -0400 Subject: [PATCH 1/3] Don't print AMD header each time HyKKT is called. --- resolve/hykkt/permutation/Permutation.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/resolve/hykkt/permutation/Permutation.cpp b/resolve/hykkt/permutation/Permutation.cpp index 6adc63ac0..e4ca27465 100644 --- a/resolve/hykkt/permutation/Permutation.cpp +++ b/resolve/hykkt/permutation/Permutation.cpp @@ -124,7 +124,6 @@ namespace ReSolve double Control[AMD_CONTROL], Info[AMD_INFO]; amd_defaults(Control); - amd_control(Control); int result = amd_order(n_hes_, hes_i_, hes_j_, perm_, Control, Info); From 8dff532ff03ed4c3ce079937049d2f6a6411b2c9 Mon Sep 17 00:00:00 2001 From: pelesh Date: Wed, 30 Sep 2026 15:09:10 -0400 Subject: [PATCH 2/3] Mute error messages when testing error response Printing error messages when testing error response is confusing to users. --- tests/unit/hykkt/HykktSolverTests.hpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/unit/hykkt/HykktSolverTests.hpp b/tests/unit/hykkt/HykktSolverTests.hpp index 823f52453..5608e122a 100644 --- a/tests/unit/hykkt/HykktSolverTests.hpp +++ b/tests/unit/hykkt/HykktSolverTests.hpp @@ -14,6 +14,7 @@ #include #include #include +#include #include #include @@ -214,12 +215,16 @@ namespace ReSolve status *= validateResult(zero_rhs_error, tol); // Check that the solver raises an error when trying to change J_d - // from nonempty to empty. + // from nonempty to empty. The error is expected, so mute the logger + // while triggering it. matrix::Csr* J_d_empty = new matrix::Csr(J_d->getNumRows(), J_d->getNumColumns(), 0); + io::Logger::Verbosity saved_verbosity = io::Logger::verbosity(); + io::Logger::setVerbosity(io::Logger::NONE); int structure_status = hykktSolver.setMatrixBlocks(H, D_s_reuse, J, J_d_empty); + io::Logger::setVerbosity(saved_verbosity); status *= (structure_status != 0); // Exercise initialization and reuse with an empty J_d. From 541f760a9a4aeef89981df69b77f14e9b239a49a Mon Sep 17 00:00:00 2001 From: Shaked Regev <35384901+shakedregev@users.noreply.github.com> Date: Mon, 5 Oct 2026 10:34:46 -0400 Subject: [PATCH 3/3] [skip ci] Reorder comments. Co-authored-by: Shaked Regev <35384901+shakedregev@users.noreply.github.com> --- tests/unit/hykkt/HykktSolverTests.hpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/unit/hykkt/HykktSolverTests.hpp b/tests/unit/hykkt/HykktSolverTests.hpp index 5608e122a..4d07f9ac1 100644 --- a/tests/unit/hykkt/HykktSolverTests.hpp +++ b/tests/unit/hykkt/HykktSolverTests.hpp @@ -215,14 +215,13 @@ namespace ReSolve status *= validateResult(zero_rhs_error, tol); // Check that the solver raises an error when trying to change J_d - // from nonempty to empty. The error is expected, so mute the logger - // while triggering it. + // from nonempty to empty. matrix::Csr* J_d_empty = new matrix::Csr(J_d->getNumRows(), J_d->getNumColumns(), 0); io::Logger::Verbosity saved_verbosity = io::Logger::verbosity(); - io::Logger::setVerbosity(io::Logger::NONE); + io::Logger::setVerbosity(io::Logger::NONE); //The error is expected, so mute the logger before triggering it. int structure_status = hykktSolver.setMatrixBlocks(H, D_s_reuse, J, J_d_empty); io::Logger::setVerbosity(saved_verbosity); status *= (structure_status != 0);