From 5f576433d6a41a26e1e56837320157630e08600c Mon Sep 17 00:00:00 2001 From: Andy Date: Sun, 18 Oct 2026 09:02:49 +0100 Subject: [PATCH] Codechange: cache seen names in the casefold guard, for performance reasons --- nml/ast/item.py | 20 +++++++++++--------- nml/global_constants.py | 2 ++ 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/nml/ast/item.py b/nml/ast/item.py index 04b640cc..1fb24abc 100644 --- a/nml/ast/item.py +++ b/nml/ast/item.py @@ -83,15 +83,17 @@ def register_names(self): ) self.id = existing_id else: - casefoldedname = self.name.value.casefold() - for key in global_constants.item_names: - if casefoldedname == key.casefold(): - generic.print_warning( - generic.Warning.GENERIC, - f"Item with name '{self.name.value}' similar to existing name '{key}'", - self.pos, - ) - break + casefolded_name = self.name.value.casefold() + existing_name = global_constants.item_names_guard.get(casefolded_name) + + if existing_name is not None: + generic.print_warning( + generic.Warning.GENERIC, + f"Item with name '{self.name.value}' similar to existing name '{existing_name}'", + self.pos, + ) + else: + global_constants.item_names_guard[casefolded_name] = self.name.value # We may have to reserve multiple item IDs for houses num_ids = action0.house_sizes[self.size.value] if self.size is not None else 1 diff --git a/nml/global_constants.py b/nml/global_constants.py index 503ea1ab..93fc0b5b 100644 --- a/nml/global_constants.py +++ b/nml/global_constants.py @@ -1464,6 +1464,8 @@ def create_spritegroup_ref(name, info, pos): identifier_refcount = {} item_names = {} +# cache used for tracking casefolded names to prevent case-insenstive duplicate names +item_names_guard = {} settings = {} named_parameters = {} spritegroups = {"CB_FAILED": "CB_FAILED"}