diff --git a/src/keepass2android-app/EntryActivity.cs b/src/keepass2android-app/EntryActivity.cs index 27b70e47a..bd9a3b293 100644 --- a/src/keepass2android-app/EntryActivity.cs +++ b/src/keepass2android-app/EntryActivity.cs @@ -1470,6 +1470,8 @@ private void SetPasswordStyle(ProtectedTextviewGroup group) SetPasswordTypeface(group.VisibleProtectedField); group.ProtectedField.InputType = InputTypes.ClassText | InputTypes.TextVariationPassword; + // masked text is not spoken by screen readers: announce the length instead of the content + group.ProtectedField.ContentDescription = GetString(Resource.String.hidden_protected_field, group.ProtectedField.Text?.Length ?? 0); } protected override void OnResume() diff --git a/src/keepass2android-app/PasswordActivity.cs b/src/keepass2android-app/PasswordActivity.cs index a4d129a32..5c314bcf4 100644 --- a/src/keepass2android-app/PasswordActivity.cs +++ b/src/keepass2android-app/PasswordActivity.cs @@ -1601,6 +1601,9 @@ private void MakePasswordMaskedOrVisible() password.InputType = InputTypes.ClassText | InputTypes.TextVariationPassword; } password.SetSelection(selStart, selEnd); + var toggleButton = FindViewById(Resource.Id.toggle_password); + if (toggleButton != null) + toggleButton.ContentDescription = GetString(_showPassword ? Resource.String.hide_password : Resource.String.show_password); } protected override void OnPause() diff --git a/src/keepass2android-app/Resources/layout/ListViewPluginRow.xml b/src/keepass2android-app/Resources/layout/ListViewPluginRow.xml index 159c425ca..ac5ac1a94 100644 --- a/src/keepass2android-app/Resources/layout/ListViewPluginRow.xml +++ b/src/keepass2android-app/Resources/layout/ListViewPluginRow.xml @@ -10,7 +10,7 @@ android:layout_alignParentTop="true" android:layout_marginRight="15dp" android:layout_marginTop="5dp" - android:layout_marginBottom="5dp" /> + android:layout_marginBottom="5dp" android:importantForAccessibility="no"/> android:layout_height="match_parent" android:scaleType="centerCrop" android:src="@drawable/toolbar_bg_quickunlock" - app:layout_collapseMode="parallax" /> + app:layout_collapseMode="parallax" android:importantForAccessibility="no"/> + android:focusableInTouchMode="true" /> + android:background="?android:selectableItemBackground" android:contentDescription="@string/fingerprint_prefs"/> diff --git a/src/keepass2android-app/Resources/layout/about.xml b/src/keepass2android-app/Resources/layout/about.xml index f529841f7..815797b8e 100644 --- a/src/keepass2android-app/Resources/layout/about.xml +++ b/src/keepass2android-app/Resources/layout/about.xml @@ -22,7 +22,7 @@ android:layout_height="wrap_content" android:layout_below="@id/about_title" android:scaleType="fitXY" - android:src="@android:drawable/divider_horizontal_dark" /> + android:src="@android:drawable/divider_horizontal_dark" android:importantForAccessibility="no"/> + android:src="@android:drawable/divider_horizontal_dark" android:importantForAccessibility="no"/> + android:src="@android:drawable/divider_horizontal_dark" android:importantForAccessibility="no"/> + android:src="@drawable/ic_launcher" android:importantForAccessibility="no"/> \ No newline at end of file diff --git a/src/keepass2android-app/Resources/layout/child_db_config_row.xml b/src/keepass2android-app/Resources/layout/child_db_config_row.xml index 2e2ad24cc..9530ce5ca 100644 --- a/src/keepass2android-app/Resources/layout/child_db_config_row.xml +++ b/src/keepass2android-app/Resources/layout/child_db_config_row.xml @@ -22,8 +22,7 @@ android:layout_centerVertical="true" android:paddingBottom="4sp" - android:paddingTop="4sp" - /> + android:paddingTop="4sp" android:importantForAccessibility="no"/> android:layout_width="wrap_content" android:layout_height="wrap_content" android:src="@drawable/ic_storage_file" - android:padding="5dp" - - /> + android:padding="5dp" android:importantForAccessibility="no"/> android:hint="@string/hint_pass" android:inputType="textPassword" android:singleLine="true" - android:typeface="monospace" - android:importantForAccessibility="no" /> + android:typeface="monospace" /> android:hint="@string/hint_conf_pass" android:inputType="textPassword" android:singleLine="true" - android:typeface="monospace" - android:importantForAccessibility="no"/> + android:typeface="monospace" /> diff --git a/src/keepass2android-app/Resources/layout/donate.xml b/src/keepass2android-app/Resources/layout/donate.xml index 78d29fac2..51342c48f 100644 --- a/src/keepass2android-app/Resources/layout/donate.xml +++ b/src/keepass2android-app/Resources/layout/donate.xml @@ -24,7 +24,7 @@ android:layout_below="@id/donate_question" android:adjustViewBounds="true" android:scaleType="fitCenter" - android:src="@drawable/oktoberfest" /> + android:src="@drawable/oktoberfest" android:importantForAccessibility="no"/>