Skip to content

PGTLE_VERSION is documented but non-functional -- make pgtle PGTLE_VERSION=X generates all versions anyway #65

Description

@jnasbyupgrade

Problem

CLAUDE.md documents `make pgtle PGTLE_VERSION=1.5.0+` as a way to generate pg_tle registration SQL for one specific version range instead of all of them. This does not actually work.

Tested against a real repo: `make pgtle PGTLE_VERSION=1.5.0+` generates all version ranges regardless of the value passed.

Root cause

  • `pgtle.sh` unconditionally resets its internal `PGTLE_VERSION=""` during initialization (around line 160), which means the script always falls through to the "generate all" branch (`if [ -z "$PGTLE_VERSION" ]; then ... generate all ...`) regardless of any make-level variable.
  • `base.mk`'s `pgtle` target never actually passes a value through to `pgtle.sh` — the script's own `--pgtle-version` flag is the only way it accepts a version, and nothing in `base.mk` wires the make variable to that flag.

Impact

Anyone following CLAUDE.md's documented usage to generate a single version range gets silent wrong behavior (all ranges generated, not the one asked for) rather than an error.

Found while

Auditing all override variables in base.mk for #61's README documentation update — deliberately left `PGTLE_VERSION` out of the new "Configuration Variables" section rather than document something that doesn't work.

Ask

Either wire `PGTLE_VERSION` through to `pgtle.sh --pgtle-version` properly, or update/remove the CLAUDE.md claim if per-version generation isn't actually meant to be supported this way.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions