`run_tests_asan.sh` sets `ASAN_OPTIONS=detect_leaks=0`, with a comment explaining this was needed because "a pre-existing, separately tracked leak in the throw-by-pointer exception pattern would otherwise fail every run."
That leak (the `throw new std::runtime_error(...)` pattern) was fixed in #32 (closing #29). The suppression and its comment are now stale documentation drift and unnecessarily weaken this script's coverage — with the fix in place, leak detection can likely be re-enabled (`detect_leaks=1` or the default) without breaking the run.
Suggested fix: re-enable leak detection in `run_tests_asan.sh`, run it to confirm a clean pass, and remove/update the now-inaccurate comment.
This issue body was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
`run_tests_asan.sh` sets `ASAN_OPTIONS=detect_leaks=0`, with a comment explaining this was needed because "a pre-existing, separately tracked leak in the throw-by-pointer exception pattern would otherwise fail every run."
That leak (the `throw new std::runtime_error(...)` pattern) was fixed in #32 (closing #29). The suppression and its comment are now stale documentation drift and unnecessarily weaken this script's coverage — with the fix in place, leak detection can likely be re-enabled (`detect_leaks=1` or the default) without breaking the run.
Suggested fix: re-enable leak detection in `run_tests_asan.sh`, run it to confirm a clean pass, and remove/update the now-inaccurate comment.
This issue body was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).