Use Validation Contexts consistently

[equist]

To make the validation API:s more consistent, I suggest that they use validation contexts instead of multiple parameters where applicable. When reviewing the current code base that means to change the following (breaking change):

• IAuthorizeRequestValidator.ValidateAsync (two parameters -> AuthorizeRequestValidationContext)
• IDeviceAuthorizationRequestValidator.ValidateAsync (two parameters -> DeviceAuthorizationRequestValidationContext)
• IEndSessionRequestValidator.ValidateAsync (two parameters -> EndSessionRequestValidationContext)
• IEndSessionRequestValidator.ValidateCallbackAsync (single parameter, but for consistency ->EndSessionRequestValidationContext with Subject null (or include the Subject even if it isn't used))
• IIntrospectionRequestValidator.ValidateAsync (two parameters -> IntrospectionRequestValidationContext)
• JwtRequestValidator.ValidateAsync (two parameters -> JwtRequestValidationContext)
  • Also add interface for consistency
• IRedirectUriValidator.IsRedirectUriValidAsync (two parameters ->RedirectUriValidationContext)
• IRedirectUriValidator.IsPostLogoutRedirectUriValidAsync (two parameters -> RedirectUriValidationContext)
• ITokenRequestValidator.ValidateRequestAsync (two parameters -> TokenRequestValidationContext)
• ITokenRevocationRequestValidator.ValidateRequestAsync (two parameters -> TokenRevocationRequestValidationContext)
• ITokenValidator.ValidateAccessTokenAsync (two paramters -> AccessTokenValidationContext)
• ITokenValidator.ValidateIdentityTokenAsync (three parameters -> IdentityTokenValidationContext)

To be completly constistent the ISecretValidator (and ISecretsListValidator) should also be changed, but I suspect a bigger risk for breaking implementations so maybe leave them for now.

I can make this re-factoring if you find the suggestions to be good.

[joe-harvey-rsk]

Hey, we agree with your suggestions. To avoid breaking changes, we think it would make sense to keep the current validator methods but mark them as obsolete.

Let us know if you want to pick up the re-factoring, otherwise I will add it to our backlog to be picked up when possible.

[equist]

I made a first commit for AuthroizeRequestValidationContext here: 134d334#diff-9366e21219f6d678c0001fa299894df6c7c247e2bff1d16b1bf702fb290017c3

Can you review the use of obsolete so that we agree on what to do before I go through them all?
This will only not break consumers, but it will still break anyone making a custom implementation of the interface (which is impossible to avoid).