Skip to content

πŸ› Fix: BattleVoteServiceImplTest μ‹œκ°„λŒ€ 뢈일치둜 15μ‹œ(UTC) 이후 CI μ‹€νŒ¨Β #440

Description

@Roy-wonji

πŸ› οΈ Issue Overview

CIκ°€ 맀일 15:00 UTC(KST μžμ •) 이후에 돌면 BattleVoteServiceImplTest 2건이 μ‹€νŒ¨ν•©λ‹ˆλ‹€.

πŸ“ Issue Description

BattleVoteServiceImpl은 "였늘"을 LocalDate.now(KST)둜 νŒλ‹¨ν•˜λŠ”λ°, ν…ŒμŠ€νŠΈλŠ” μ‹œμŠ€ν…œ κΈ°λ³Έ μ‹œκ°„λŒ€μ˜ LocalDate.now()λ₯Ό μ”λ‹ˆλ‹€.

UTC λŸ¬λ„ˆμ—μ„œλŠ” 15:00 UTC 이후 두 값이 ν•˜λ£¨μ”© μ–΄κΈ‹λ‚˜, 였늘 배틀이 μ–΄μ œ λ°°ν‹€λ‘œ μ·¨κΈ‰λ˜λ©΄μ„œ ν¬λ ˆλ”§ 차감 λΆ„κΈ°κ°€ λ°˜λŒ€λ‘œ νƒ‘λ‹ˆλ‹€.

같은 λΈŒλžœμΉ˜μ—μ„œ 14:42 UTC 싀행은 ν†΅κ³Όν•˜κ³  15:25 UTC 싀행은 μ‹€νŒ¨ν•œ κ²ƒμœΌλ‘œ μž¬ν˜„ν–ˆμŠ΅λ‹ˆλ‹€. 둜컬(KST)μ—μ„œλŠ” 항상 톡과해 λ“œλŸ¬λ‚˜μ§€ μ•Šμ•˜μŠ΅λ‹ˆλ‹€.

μ‹€νŒ¨ λ‚΄μš©

  • 였늘 배틀이면 졜초 사전 νˆ¬ν‘œ μ‹œ ν¬λ ˆλ”§μ„ μ°¨κ°ν•˜μ§€ μ•ŠλŠ”λ‹€ β†’ NeverWantedButInvoked
  • 였늘의 배틀이라도 였늘 이미 무료 μ§„μž…μ„ μ‚¬μš©ν–ˆλ‹€λ©΄ ν¬λ ˆλ”§μ„ μ°¨κ°ν•œλ‹€ β†’ UnnecessaryStubbingException

βœ… To do

  • ν…ŒμŠ€νŠΈμ˜ λ‚ μ§œ 기쀀을 ν”„λ‘œλ•μ…˜κ³Ό λ™μΌν•˜κ²Œ KST둜 λ§žμΆ”κΈ°
  • TZ=UTC둜 15μ‹œ 이후 μž¬ν˜„ ν›„ 톡과 확인

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions