You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit b474a39
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: .claude/skills/fix-issue/references/verification-windows.md
+2-1Lines changed: 2 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -34,7 +34,8 @@ Read this when a `verify.sh` verdict needs interpreting for the Windows app, bef
34
34
-**They drive the real app through UI Automation (FlaUI)** and take the mouse and keyboard. `TABLEPRO_APP` names the published `TablePro.exe`, which the `ui` step finds under `windows/src/TablePro.App/bin/` in the `publish` folder for the SDK's runtime identifier; run `app` first.
35
35
-**Each launch gets a new data folder** through `TABLEPRO_DATA_DIR`, with its theme and row limit written into `settings.json`, so the user's connections never show and nothing carries over.
36
36
-**`windows/ci/desktop.ps1` is for hosted runners.** It writes a machine policy, stops system processes and changes the display mode. Never run it on a developer's machine.
37
-
-**Keys and clicks go through `AppSession`.** It brings the app to the front first, and `Chord`, `Click(element, landed)`, `Drag(..., landed)` and `TypeInto` try up to three times, waiting 5 seconds each for the app to show the input landed. A new test sends a shortcut with `Chord` and a `landed` check, never a bare `Keyboard.TypeSimultaneously`.
37
+
-**Keys and clicks go through `AppSession`.** It brings the app to the front first, and `Chord`, `Click(element, landed)`, `Drag(..., landed)` and `TypeInto` try up to three times, waiting 5 seconds each for the app to show the input landed. A new test sends a shortcut with `Chord` and a `landed` check, never a bare `Keyboard.TypeSimultaneously`. Every click reads the element's clickable point again until it has one, since a live element's point can fail to read for a moment; a test never calls FlaUI's own `Click`, `RightClick` or `DoubleClick`.
38
+
-**A list the app builds again after a change drops the row a test just found.** Read a row of such a list inside `AppSession.Holds`, which counts a gone row or its unsupported state as not yet (`windows/docs/decisions/0004-app-shell.md`, What the runner showed).
38
39
-**A drag goes through `SendInput`** (`PointerInput`). FlaUI moves the pointer with `SetCursorPos`, which WinUI does not take as a pointer moving with the button down.
39
40
-**UIA reads an empty Name as none.** WinUI reports an empty name as not supported, so FlaUI's `Name` throws `PropertyNotSupportedException`: it did once on x64, in run 41566360608. Read a name that can be empty through `Properties.Name.ValueOrDefault`.
40
41
-**`TablePattern.ColumnHeaders` is empty on Windows App SDK 2.6.4.**`CUIATableProviderWrapper::GetColumnHeaders` releases its SAFEARRAY before filling it; microsoft/microsoft-ui-xaml#11820 fixed it after 2.6.4. Read the headers from the header peers, or a cell's `TableItem` while its header is realized (`windows/docs/decisions/0003-data-grid-control.md`, Consequences).
Copy file name to clipboardExpand all lines: windows/docs/decisions/0004-app-shell.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -209,6 +209,8 @@ Facts the CI runs on `windows-2025` and `windows-11-arm` established, which the
209
209
-`TreeViewItem`'s multiple-selection check box is raw to UI Automation, so the tests check a row through its `SelectionItem` pattern, which reads that box.
210
210
- A click on a `MenuFlyoutSubItem` did not always open its submenu, and FlaUI's pointer glides to the next item across its neighbours, whose own submenus then open. The tests open a submenu through `ExpandCollapse` and invoke its item.
211
211
-`windows-2025` drags a window as an outline: "Show window contents while dragging" is off there (`SPI_GETDRAGFULLWINDOWS` 0), while `windows-11-arm` has it on. TabView merges a dragged tab into another strip from `InputNonClientPointerSource.WindowRectChanging`, which the outline drag raised once, on release; with window contents on, the same drag raised it 82 times and the tab merged and tore out again before the release (run 41837948701). CI turns the setting on with `Set-DragFullWindows` in `windows/ci/desktop.ps1`.
212
+
- A list the app builds again after each change (saved queries, the Connections page, history) drops every row, and a row a client found a moment before reads as gone: `UIA_E_ELEMENTNOTAVAILABLE` for its properties, and not supported for a tree row's `ExpandCollapseState`, since WinUI's `TreeViewItemDataAutomationPeer` throws once its item has no container. `AQueryIsSavedIntoAFolderAndARunIsPinned` found the folder row just before the move rebuilt the tree and read it just after, and failed in 7 of 12 rounds on `windows-11-arm` (run 43737243526). Read from the row found before the move, the old check threw `PropertyNotSupportedException` 12 times in 12, and the same check inside `AppSession.Holds`, which reads the new row on the next try, passed 12 times in 12; with it, both themes of the test passed 30 rounds in five `windows-11-arm` jobs and 6 on `windows-2025` (run 43742489353).
213
+
- A live element's clickable point can fail to read for a moment: on the Go to page button, with the same runtime id and the hit test at its center finding it, 22 of 22,231 reads over 216 page changes failed on `windows-11-arm` and 4 of 5,762 over 48 on `windows-2025`, after Go to page and after Next page alike, each between two reads that passed (runs 43737243526 and 43742489353). FlaUI's `Click` throws `NoClickablePointException` on the first failed read, which failed `ATableKeepsItsPageSizeAndGoesToAPageInsideItsCount` in runs 43690747382 and 43707549355; no flyout covered the button. `AppSession` reads the point again for up to 5 seconds before each click.
212
214
## Consequences
213
215
214
216
- The core gained the library and connecting through it: `Core::library`, `connect_saved`, `test_connection`, `parse_connection_url`, `DatabaseSession::table_query` and `sorted_query` with `sql_syntax::with_order_by` and `sort_reference`, `ResultSet::sorted` over `value::order`, and `Core::with_system_secrets`, which keeps secrets in Credential Manager on Windows (`core/ARCHITECTURE.md`, Platforms).
0 commit comments