diff --git a/apple/TablePro/Core/Database/Access/AgentTransactionGuard.swift b/apple/TablePro/Core/Database/Access/AgentTransactionGuard.swift index 2b9ae43802..a69f121875 100644 --- a/apple/TablePro/Core/Database/Access/AgentTransactionGuard.swift +++ b/apple/TablePro/Core/Database/Access/AgentTransactionGuard.swift @@ -44,7 +44,8 @@ internal struct AgentTransactionGuard: Sendable { ) case .oracle: return Savepoint(open: savepointStatement, release: nil, rollback: rollbackStatement) - case .redshift, .duckdb, .redis, .other: + // Teradata has no savepoint. + case .redshift, .duckdb, .redis, .teradata, .other: return nil } } diff --git a/apple/TablePro/Core/Services/Execution/TransactionEngineFamily.swift b/apple/TablePro/Core/Services/Execution/TransactionEngineFamily.swift index 8861146c27..77fc766a05 100644 --- a/apple/TablePro/Core/Services/Execution/TransactionEngineFamily.swift +++ b/apple/TablePro/Core/Services/Execution/TransactionEngineFamily.swift @@ -70,7 +70,9 @@ internal enum TransactionEngineFamily: String, Hashable, Sendable, CaseIterable switch self { case .postgres, .redshift, .cockroach, .duckdb: return true - case .mysql, .sqlite, .sqlServer, .oracle, .redis, .other: + // Teradata mode rolls back the whole transaction on a failed request and ANSI mode only the request; the + // family cannot see the session's mode, so Teradata keeps the answer it had before it had a family. + case .mysql, .sqlite, .sqlServer, .oracle, .redis, .teradata, .other: return false } } diff --git a/apple/TableProTests/Core/Services/Execution/ManualCommitTests.swift b/apple/TableProTests/Core/Services/Execution/ManualCommitTests.swift index d3ff9b353b..91a94286a0 100644 --- a/apple/TableProTests/Core/Services/Execution/ManualCommitTests.swift +++ b/apple/TableProTests/Core/Services/Execution/ManualCommitTests.swift @@ -148,6 +148,7 @@ struct ManualCommitTests { #expect(AgentTransactionGuard.protection(family: .duckdb, sessionState: .inTransaction, controlsTransaction: false) == .refuse) #expect(AgentTransactionGuard.protection(family: .redshift, sessionState: .inTransaction, controlsTransaction: false) == .refuse) #expect(AgentTransactionGuard.protection(family: .mysql, sessionState: .inTransaction, controlsTransaction: false) == .none) + #expect(AgentTransactionGuard.protection(family: .teradata, sessionState: .inTransaction, controlsTransaction: false) == .none) #expect(AgentTransactionGuard.protection(family: .postgres, sessionState: .idle, controlsTransaction: false) == .none) #expect(AgentTransactionGuard.protection(family: .postgres, sessionState: .inTransaction, controlsTransaction: true) == .none) }