From 542511e5777af4cfc08fd87f76c40995a30be6e2 Mon Sep 17 00:00:00 2001 From: Ngo Quoc Dat Date: Mon, 16 Nov 2026 01:55:44 +0700 Subject: [PATCH 1/2] test(cassandra): hold the refused port in the relay's failed-open test --- core/crates/drivers/cassandra/src/relay.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/core/crates/drivers/cassandra/src/relay.rs b/core/crates/drivers/cassandra/src/relay.rs index 8d5c9c91c2..cc58269963 100644 --- a/core/crates/drivers/cassandra/src/relay.rs +++ b/core/crates/drivers/cassandra/src/relay.rs @@ -104,7 +104,7 @@ mod tests { use tablepro_core::{LivenessPolicy, NetworkEndpoint}; use tablepro_net::DirectTcpTransport; use tokio::io::{AsyncReadExt, AsyncWriteExt}; - use tokio::net::TcpListener; + use tokio::net::{TcpListener, TcpSocket}; use super::*; @@ -140,9 +140,10 @@ mod tests { #[tokio::test] async fn a_failed_open_is_kept_for_the_connect_to_report() { - let unused = TcpListener::bind((Ipv4Addr::LOCALHOST, 0)).await.unwrap(); - let endpoint = NetworkEndpoint::new("127.0.0.1", unused.local_addr().unwrap().port()).unwrap(); - drop(unused); + // Bound and never listening: a dropped listener's port can go to the next bind, the relay's own included. + let refusing = TcpSocket::new_v4().unwrap(); + refusing.bind((Ipv4Addr::LOCALHOST, 0).into()).unwrap(); + let endpoint = NetworkEndpoint::new("127.0.0.1", refusing.local_addr().unwrap().port()).unwrap(); let relay = Relay::start(Arc::new(DirectTcpTransport::new(endpoint, &LivenessPolicy::DESKTOP))).unwrap(); let mut client = TcpStream::connect(relay.address()).await.unwrap(); From 19e522375948fa5126683b84df006f5ffce25c25 Mon Sep 17 00:00:00 2001 From: Ngo Quoc Dat Date: Mon, 16 Nov 2026 03:28:44 +0700 Subject: [PATCH 2/2] test(cassandra): say what took the dropped port --- core/crates/drivers/cassandra/src/relay.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/crates/drivers/cassandra/src/relay.rs b/core/crates/drivers/cassandra/src/relay.rs index cc58269963..5242f798c7 100644 --- a/core/crates/drivers/cassandra/src/relay.rs +++ b/core/crates/drivers/cassandra/src/relay.rs @@ -140,7 +140,7 @@ mod tests { #[tokio::test] async fn a_failed_open_is_kept_for_the_connect_to_report() { - // Bound and never listening: a dropped listener's port can go to the next bind, the relay's own included. + // Bound and never listening: on Windows a dropped listener's port went to another test's relay. let refusing = TcpSocket::new_v4().unwrap(); refusing.bind((Ipv4Addr::LOCALHOST, 0).into()).unwrap(); let endpoint = NetworkEndpoint::new("127.0.0.1", refusing.local_addr().unwrap().port()).unwrap();