I could need some hint to reintroduce Ledger support

[Neggia]

Hello,
in release notes you wrote that hardware wallet support has been removed, but I still see files in devices/ledger.
I'm still using old Ledger Nano S wallets, could you give me some hints if I'd need to reintroduce the code that has been stripped? Not urgent but I will have to do it if old ElectrumSV cease to work, thanks.

[TruthMachine]

The code for hardware wallets has not been stripped, the hardware wallet option has been hidden to protect users. Also hardware requirements are no longer bundled in the executives. If you wanted to reintroduce hw support, you would need bundle the hw requirements. There is a hw requirements file for this which includes requirements like hidapi, btchip, etc... I tested recent versions and was able to sign a tx with some devices, but most devices were not working. There are some issues when it comes to device MAC addresses and how they interact with newer trezor/ledger firmware in the wallet. There are tons of bugs and user issues with hw support, even if you got it to work. The most modern firmware may be impossible to get to work. If users upgrade firmware by accident they may lose access, and ledger/trezor don't allow downgrades of firmware. Some BSV transactions may also cause the entire device/wallet to crash and malfunction because the devices are not designed for BSV. Also if you get it to work, the device will show a lot of warnings but it may still let you sign/broadcast.

[Neggia]

Thanks for the hints, for now I was just talking about the Ledger Nano S with older firmware that was working fine in ElectrumSV, I wonder if that changed because of SPV but I will take a look when I've finished other stuff, cheers.