From 21e9600dd21534c4f0015dfd0d7ea5edc2e76f1f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?L=C3=A9on=20Avic=20Simmons?= Date: Fri, 23 Oct 2026 03:46:06 -0400 Subject: [PATCH] docs: fix typos in RULER workflows and file reader docstring MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - math_ruler_workflow.py: 'whereasa' -> 'whereas' in the reset() docstring. - math_ruler_workflow.py, math_trainable_ruler_workflow.py: 'first think ... and then provides the final answer' -> 'provide' in the RULER judge prompt (the same sentence in both workflows). - file_reader.py: 'Filed based' -> 'File-based' in the module docstring. Signed-off-by: Léon Avic Simmons --- trinity/buffer/reader/file_reader.py | 2 +- trinity/common/workflows/math_ruler_workflow.py | 4 ++-- trinity/common/workflows/math_trainable_ruler_workflow.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/trinity/buffer/reader/file_reader.py b/trinity/buffer/reader/file_reader.py index 1f8abbc9902..2fa5d955fd8 100644 --- a/trinity/buffer/reader/file_reader.py +++ b/trinity/buffer/reader/file_reader.py @@ -1,4 +1,4 @@ -"""Filed based buffer reader.""" +"""File-based buffer reader.""" from typing import List, Optional, Tuple diff --git a/trinity/common/workflows/math_ruler_workflow.py b/trinity/common/workflows/math_ruler_workflow.py index b3889f61a5a..8e0fbf6d7c7 100644 --- a/trinity/common/workflows/math_ruler_workflow.py +++ b/trinity/common/workflows/math_ruler_workflow.py @@ -32,7 +32,7 @@ def __init__( def reset(self, task: Task): """ Note that in this workflow, MathRewardFn is only used for calculating the 'golden reward', - whereasa the rewards used by RL training are calculated by RULER. + whereas the rewards used by RL training are calculated by RULER. """ if task.reward_fn is None: @@ -94,7 +94,7 @@ def get_ruler_scores(self, responses: List[Experience], judge: Any) -> Tuple[boo question_prompt = ( f"Question: {self.task_desc}\n\n" - f"""Solution format requirement: first think about the reasoning process in the mind and then provides the final answer. The reasoning process and answer are enclosed within and tags, respectively, i.e., + f"""Solution format requirement: first think about the reasoning process in the mind and then provide the final answer. The reasoning process and answer are enclosed within and tags, respectively, i.e., reasoning process here answer here .""" ) diff --git a/trinity/common/workflows/math_trainable_ruler_workflow.py b/trinity/common/workflows/math_trainable_ruler_workflow.py index 1ab31d4c8ef..d53707c04aa 100644 --- a/trinity/common/workflows/math_trainable_ruler_workflow.py +++ b/trinity/common/workflows/math_trainable_ruler_workflow.py @@ -144,7 +144,7 @@ def get_ruler_responses( question_prompt = ( f"Question: {self.task_desc}\n\n" - f"""Solution format requirement: first think about the reasoning process in the mind and then provides the final answer. The reasoning process and answer are enclosed within and tags, respectively, i.e., + f"""Solution format requirement: first think about the reasoning process in the mind and then provide the final answer. The reasoning process and answer are enclosed within and tags, respectively, i.e., reasoning process here answer here .""" )