From 974c75a6fc0efa30f1d0017a6e126d765049be2d Mon Sep 17 00:00:00 2001 From: Fredrik Fornwall Date: Sat, 12 Sep 2026 01:27:01 +0200 Subject: [PATCH] chore(c/validation): remove quirk for float16 ingestion Remove the quirk for float16 ingestion - it's better to override the test method and skip it, instead of adding a lot of quirks. Signed-off-by: Fredrik Fornwall --- c/validation/adbc_validation.h | 3 --- c/validation/adbc_validation_statement.cc | 4 ---- 2 files changed, 7 deletions(-) diff --git a/c/validation/adbc_validation.h b/c/validation/adbc_validation.h index 5fcaa0ad8f..2226704f34 100644 --- a/c/validation/adbc_validation.h +++ b/c/validation/adbc_validation.h @@ -258,9 +258,6 @@ class DriverQuirks { /// \brief Whether ingestion supports StringView/BinaryView types virtual bool supports_ingest_view_types() const { return true; } - /// \brief Whether ingestion supports Float16 - virtual bool supports_ingest_float16() const { return true; } - /// \brief Default catalog to use for tests virtual std::string catalog() const { return ""; } diff --git a/c/validation/adbc_validation_statement.cc b/c/validation/adbc_validation_statement.cc index 11c802b235..d50fbe0075 100644 --- a/c/validation/adbc_validation_statement.cc +++ b/c/validation/adbc_validation_statement.cc @@ -247,10 +247,6 @@ void StatementTest::TestSqlIngestInt64() { } void StatementTest::TestSqlIngestFloat16() { - if (!quirks()->supports_ingest_float16()) { - GTEST_SKIP(); - } - ASSERT_NO_FATAL_FAILURE(TestSqlIngestNumericType(NANOARROW_TYPE_HALF_FLOAT)); }