From b158acc00eba37d2b81ef9c687b9137cdfc58735 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francesco=20Chicchiricc=C3=B2?= Date: Mon, 12 Oct 2026 07:48:14 +0200 Subject: [PATCH 1/3] Chore: remove unused methods, duplicated interfaces, useless @SuppressWarnings --- .gitignore | 1 + .../AuthProfileItemDirectoryPanel.java | 1 - .../console/rest/ClientAppRestClient.java | 1 - .../panels/LinkedAccountModalPanel.java | 1 - .../ProvisioningPolicyModalPanel.java | 12 ---- .../console/topology/TopologyTogglePanel.java | 1 - .../any/LinkedAccountWizardBuilder.java | 25 +------- .../syncope/client/ui/commons/DateOps.java | 2 +- .../html/form/AjaxDropDownChoicePanel.java | 2 +- .../ui/commons/markup/html/form/AjaxGrid.java | 1 - .../html/form/AjaxGridBottomToolbar.java | 1 - .../markup/html/form/AjaxTextFieldPanel.java | 2 +- .../markup/html/form/EncryptedFieldPanel.java | 2 +- .../commons/markup/html/form/FieldPanel.java | 1 - .../html/form/preview/BinaryPDFPreviewer.java | 3 +- .../commons/panels/SimpleListViewPanel.java | 6 +- .../wizards/AbstractWizardMgtPanel.java | 3 +- .../console/panels/MultilevelPanel.java | 3 +- .../console/panels/PlainSchemaDetails.java | 4 +- .../panels/search/SearchClausePanel.java | 2 +- .../policies/PolicyRuleDirectoryPanel.java | 1 - .../client/console/rest/PolicyRestClient.java | 1 - .../tasks/NotificationTaskDirectoryPanel.java | 4 +- .../tasks/PropagationTaskDirectoryPanel.java | 4 +- .../tasks/SchedTaskDirectoryPanel.java | 4 +- .../wicket/markup/head/MetaHeaderItem.java | 3 +- .../html/form/AjaxCharacterFieldPanel.java | 2 +- .../html/form/AjaxSearchFieldPanel.java | 2 +- .../client/console/widgets/JobWidget.java | 1 - .../client/console/widgets/NumberWidget.java | 1 - .../wizards/any/AbstractAttrsWizardStep.java | 2 +- .../wizards/role/RoleWizardBuilder.java | 2 +- .../client/enduser/pages/SelfResult.java | 2 +- .../client/enduser/panels/AnyFormPanel.java | 1 - .../client/enduser/panels/ResultPanel.java | 8 +-- .../client/enduser/panels/any/PlainAttrs.java | 2 +- .../wicket/markup/head/MetaHeaderItem.java | 3 +- .../lib/auth/AppleOIDCAuthModuleConf.java | 2 +- .../lib/auth/AzureOIDCAuthModuleConf.java | 2 +- .../lib/auth/GoogleMfaAuthModuleConf.java | 3 +- .../lib/auth/GoogleOIDCAuthModuleConf.java | 2 +- .../lib/auth/KeycloakOIDCAuthModuleConf.java | 2 +- .../lib/auth/OAuth20AuthModuleConf.java | 2 +- .../common/lib/auth/OIDCAuthModuleConf.java | 2 +- .../lib/auth/SAML2IdPAuthModuleConf.java | 2 +- .../common/lib/auth/SpnegoAuthModuleConf.java | 3 +- .../common/lib/auth/X509AuthModuleConf.java | 3 +- .../policy/AbstractCorrelationRuleConf.java | 3 +- .../syncope/common/lib/LogOutputStream.java | 2 +- .../lib/policy/AbstractAccountRuleConf.java | 3 +- .../lib/policy/AbstractPasswordRuleConf.java | 3 +- .../lib/policy/DefaultAccountRuleConf.java | 2 +- .../lib/search/SyncopeFiqlParserTest.java | 3 +- .../syncope/core/logic/AbstractAnyLogic.java | 5 -- .../core/logic/LogicInvocationHandler.java | 1 + .../rest/cxf/service/TaskServiceImpl.java | 1 - .../core/persistence/api/entity/Any.java | 2 +- .../common/content/MultiParentNode.java | 1 - .../common/dao/AbstractAnyMatchDAO.java | 7 +-- .../jpa/content/XMLContentExporter.java | 2 +- .../jpa/entity/task/JPALiveSyncTaskExec.java | 3 +- .../jpa/entity/task/JPAMacroTaskExec.java | 3 +- .../entity/task/JPANotificationTaskExec.java | 3 +- .../entity/task/JPAPropagationTaskExec.java | 3 +- .../jpa/entity/task/JPAPullTaskExec.java | 3 +- .../jpa/entity/task/JPAPushTaskExec.java | 3 +- .../jpa/entity/task/JPASchedTaskExec.java | 3 +- .../persistence/neo4j/dao/Neo4jPolicyDAO.java | 1 - .../entity/task/Neo4jLiveSyncTaskExec.java | 3 +- .../neo4j/entity/task/Neo4jMacroTaskExec.java | 3 +- .../task/Neo4jNotificationTaskExec.java | 5 +- .../entity/task/Neo4jPropagationTaskExec.java | 3 +- .../neo4j/entity/task/Neo4jPullTaskExec.java | 3 +- .../neo4j/entity/task/Neo4jPushTaskExec.java | 3 +- .../neo4j/entity/task/Neo4jSchedTaskExec.java | 3 +- .../neo4j/inner/AnySearchTest.java | 4 -- .../provisioning/java/data/AnyDataBinder.java | 1 - .../job/AbstractSchedTaskJobDelegate.java | 1 - .../DefaultAnyObjectPullResultHandler.java | 5 +- .../DefaultAnyObjectPushResultHandler.java | 3 +- .../DefaultGroupPullResultHandler.java | 3 +- .../DefaultGroupPushResultHandler.java | 3 +- .../DefaultUserPullResultHandler.java | 3 +- .../java/pushpull/LiveSyncJobDelegate.java | 5 +- .../java/pushpull/PullJobDelegate.java | 5 +- .../java/DefaultMappingManagerTest.java | 16 ------ .../implementation/ImplementationManager.java | 3 +- .../task/VirtualThreadPoolTaskExecutor.java | 5 +- .../core/starter/actuate/JobEndpoint.java | 2 +- .../dao/ElasticsearchRealmSearchDAO.java | 3 +- .../enduser/rest/BpmnProcessRestClient.java | 10 ---- .../dao/OpenSearchRealmSearchDAO.java | 3 +- .../syncope/fit/core/AbstractTaskITCase.java | 57 ++++++++++--------- .../syncope/fit/core/PullTaskITCase.java | 53 ++++++++--------- .../syncope/fit/core/SyncReplITCase.java | 4 +- .../apache/syncope/fit/core/UserITCase.java | 1 - .../org/apache/syncope/sra/RouteProvider.java | 1 - 97 files changed, 133 insertions(+), 278 deletions(-) diff --git a/.gitignore b/.gitignore index 984b61bfb8c..6087560fb24 100644 --- a/.gitignore +++ b/.gitignore @@ -8,5 +8,6 @@ target maven-eclipse.xml .externalToolBuilders *nb-configuration.xml +.vscode node_modules **/checkstyle.cache diff --git a/client/am/console/src/main/java/org/apache/syncope/client/console/authprofiles/AuthProfileItemDirectoryPanel.java b/client/am/console/src/main/java/org/apache/syncope/client/console/authprofiles/AuthProfileItemDirectoryPanel.java index f795d7a483e..f8ed0a4e1e8 100644 --- a/client/am/console/src/main/java/org/apache/syncope/client/console/authprofiles/AuthProfileItemDirectoryPanel.java +++ b/client/am/console/src/main/java/org/apache/syncope/client/console/authprofiles/AuthProfileItemDirectoryPanel.java @@ -91,7 +91,6 @@ public AuthProfileItemDirectoryPanel( protected abstract String sortProperty(); @Override - @SuppressWarnings("unchecked") public void onEvent(final IEvent event) { if (event.getPayload() instanceof ExitEvent exitEvent) { authProfileModal.close(exitEvent.getTarget()); diff --git a/client/am/console/src/main/java/org/apache/syncope/client/console/rest/ClientAppRestClient.java b/client/am/console/src/main/java/org/apache/syncope/client/console/rest/ClientAppRestClient.java index 56d7f725495..23ec2c6c1ec 100644 --- a/client/am/console/src/main/java/org/apache/syncope/client/console/rest/ClientAppRestClient.java +++ b/client/am/console/src/main/java/org/apache/syncope/client/console/rest/ClientAppRestClient.java @@ -41,7 +41,6 @@ public T read(final ClientAppType type, final String key return policy; } - @SuppressWarnings("unchecked") public List list(final ClientAppType type) { try { return getService(ClientAppService.class).list(type).stream(). diff --git a/client/idm/console/src/main/java/org/apache/syncope/client/console/panels/LinkedAccountModalPanel.java b/client/idm/console/src/main/java/org/apache/syncope/client/console/panels/LinkedAccountModalPanel.java index e2419cc0dec..edf9cee0afa 100644 --- a/client/idm/console/src/main/java/org/apache/syncope/client/console/panels/LinkedAccountModalPanel.java +++ b/client/idm/console/src/main/java/org/apache/syncope/client/console/panels/LinkedAccountModalPanel.java @@ -160,7 +160,6 @@ protected void customActionOnCancelCallback(final AjaxRequestTarget target) { } @Override - @SuppressWarnings("unchecked") protected void customActionOnFinishCallback(final AjaxRequestTarget target) { checkAddButton(model.getObject().getRealm()); diff --git a/client/idm/console/src/main/java/org/apache/syncope/client/console/policies/ProvisioningPolicyModalPanel.java b/client/idm/console/src/main/java/org/apache/syncope/client/console/policies/ProvisioningPolicyModalPanel.java index 1d8b5693255..e47feb9b414 100644 --- a/client/idm/console/src/main/java/org/apache/syncope/client/console/policies/ProvisioningPolicyModalPanel.java +++ b/client/idm/console/src/main/java/org/apache/syncope/client/console/policies/ProvisioningPolicyModalPanel.java @@ -370,18 +370,10 @@ public String getAnyType() { return anyType; } - public void setAnyType(final String anyType) { - this.anyType = anyType; - } - public String getImplKey() { return Optional.ofNullable(impl).map(ImplementationTO::getKey).orElse(null); } - public void setImplKey(final String key) { - setImpl(implementations.getObject().get(key)); - } - public final void setImpl(final ImplementationTO impl) { this.impl = impl; if (impl != null) { @@ -405,10 +397,6 @@ public ImplementationTO getImpl() { return impl; } - public void setDefaultRuleConf(final DefaultPushCorrelationRuleConf defaultRuleConf) { - this.defaultRuleConf = defaultRuleConf; - } - public AbstractCorrelationRuleConf getDefaultRuleConf() { return defaultRuleConf; } diff --git a/client/idm/console/src/main/java/org/apache/syncope/client/console/topology/TopologyTogglePanel.java b/client/idm/console/src/main/java/org/apache/syncope/client/console/topology/TopologyTogglePanel.java index 3cde0ec748f..0506dac16c0 100644 --- a/client/idm/console/src/main/java/org/apache/syncope/client/console/topology/TopologyTogglePanel.java +++ b/client/idm/console/src/main/java/org/apache/syncope/client/console/topology/TopologyTogglePanel.java @@ -503,7 +503,6 @@ public String getAjaxIndicatorMarkupId() { private static final long serialVersionUID = 3776750333491622263L; @Override - @SuppressWarnings("unchecked") public void onClick(final AjaxRequestTarget target) { target.add(propTaskModal.setContent( new PropagationTasks(propTaskModal, node.getKey(), pageRef))); diff --git a/client/idm/console/src/main/java/org/apache/syncope/client/console/wizards/any/LinkedAccountWizardBuilder.java b/client/idm/console/src/main/java/org/apache/syncope/client/console/wizards/any/LinkedAccountWizardBuilder.java index ebf2c51c1f9..c4a6a5739d6 100644 --- a/client/idm/console/src/main/java/org/apache/syncope/client/console/wizards/any/LinkedAccountWizardBuilder.java +++ b/client/idm/console/src/main/java/org/apache/syncope/client/console/wizards/any/LinkedAccountWizardBuilder.java @@ -118,36 +118,15 @@ private void fixPlainAttrs(final LinkedAccountTO linkedAccountTO) { @Override protected Serializable getCreateCustomPayloadEvent(final Serializable afterObject, final AjaxRequestTarget target) { - return new CreateEvent( - LinkedAccountTO.class.cast(afterObject).getConnObjectKeyValue(), - model.getObject(), - target); + return new CreateEvent(target); } private static class CreateEvent extends ModalEvent { private static final long serialVersionUID = 6416834092156281986L; - private final String key; - - private final UserTO userTO; - - CreateEvent( - final String key, - final UserTO userTO, - final AjaxRequestTarget target) { - + CreateEvent(final AjaxRequestTarget target) { super(target); - this.key = key; - this.userTO = userTO; - } - - public String getKey() { - return key; - } - - public UserTO getUserTO() { - return userTO; } } } diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DateOps.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DateOps.java index 1f23abe89e7..3cdcee37988 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DateOps.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/DateOps.java @@ -59,7 +59,7 @@ public String format(final LocalDateTime date) { } } - public static final class WrappedDateModel implements IModel, Serializable { + public static final class WrappedDateModel implements IModel { private static final long serialVersionUID = 31027882183172L; diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxDropDownChoicePanel.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxDropDownChoicePanel.java index b87f89e4a84..7d8b3fb8ca1 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxDropDownChoicePanel.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxDropDownChoicePanel.java @@ -29,7 +29,7 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.ResourceModel; -public class AjaxDropDownChoicePanel extends FieldPanel implements Cloneable { +public class AjaxDropDownChoicePanel extends FieldPanel { private static final long serialVersionUID = -4716376580659196095L; diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxGrid.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxGrid.java index 3d933145d08..2693507c0bf 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxGrid.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxGrid.java @@ -196,7 +196,6 @@ protected class AjaxGridActionsPanel extends ActionsPanel> { private final Item> rowItem; - @SuppressWarnings("unchecked") public AjaxGridActionsPanel(final String id, final Item> item) { super(id, item); diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxGridBottomToolbar.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxGridBottomToolbar.java index 259b38e3d56..d6d706be712 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxGridBottomToolbar.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxGridBottomToolbar.java @@ -123,7 +123,6 @@ protected void populateItem(final LoopItem item) { }; } - @SuppressWarnings("unchecked") protected List> getEditableColumns() { List> columns = new ArrayList<>(); getTable().getColumns().stream(). diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxTextFieldPanel.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxTextFieldPanel.java index 521c4607073..1a84412ed94 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxTextFieldPanel.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/AjaxTextFieldPanel.java @@ -36,7 +36,7 @@ import org.apache.wicket.model.ResourceModel; import org.apache.wicket.util.convert.IConverter; -public class AjaxTextFieldPanel extends TextFieldPanel implements Cloneable { +public class AjaxTextFieldPanel extends TextFieldPanel { private static final long serialVersionUID = 238940918106696068L; diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/EncryptedFieldPanel.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/EncryptedFieldPanel.java index ba72ac7b36e..8935d100bce 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/EncryptedFieldPanel.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/EncryptedFieldPanel.java @@ -25,7 +25,7 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.ResourceModel; -public class EncryptedFieldPanel extends TextFieldPanel implements Cloneable { +public class EncryptedFieldPanel extends TextFieldPanel { private static final long serialVersionUID = 1882871043451691005L; diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/FieldPanel.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/FieldPanel.java index d37da07d5d1..efb81d172e4 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/FieldPanel.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/FieldPanel.java @@ -229,7 +229,6 @@ public FieldPanel settingsDependingComponents() { } @Override - @SuppressWarnings("unchecked") public FieldPanel clone() { final FieldPanel panel = SerializationUtils.clone(this); panel.setModelObject(null); diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/preview/BinaryPDFPreviewer.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/preview/BinaryPDFPreviewer.java index 1dc1b599d8d..5a2163f6f97 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/preview/BinaryPDFPreviewer.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/markup/html/form/preview/BinaryPDFPreviewer.java @@ -22,7 +22,6 @@ import java.awt.RenderingHints; import java.awt.image.BufferedImage; import java.io.IOException; -import java.io.Serializable; import java.time.Instant; import org.apache.pdfbox.Loader; import org.apache.pdfbox.cos.COSObject; @@ -91,7 +90,7 @@ public void put(final COSObject indirect, final PDXObject xobject) { return this.addOrReplace(previewContainer); } - protected static class ThumbnailImageResource extends DynamicImageResource implements Serializable { + protected static class ThumbnailImageResource extends DynamicImageResource { private static final long serialVersionUID = 923201517955737928L; diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/panels/SimpleListViewPanel.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/panels/SimpleListViewPanel.java index 0b1f028287d..d6a0cd7cb19 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/panels/SimpleListViewPanel.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/panels/SimpleListViewPanel.java @@ -27,7 +27,6 @@ import org.apache.commons.lang3.StringUtils; import org.apache.syncope.client.ui.commons.Constants; import org.apache.wicket.Component; -import org.apache.wicket.PageReference; import org.apache.wicket.core.util.lang.PropertyResolver; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.list.ListItem; @@ -139,10 +138,7 @@ public static class Builder implements Serializable { private final Class reference; - private final PageReference pageReference; - - public Builder(final Class reference, final PageReference pageRef) { - this.pageReference = pageRef; + public Builder(final Class reference) { this.reference = reference; this.items = null; } diff --git a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/wizards/AbstractWizardMgtPanel.java b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/wizards/AbstractWizardMgtPanel.java index 4444f498522..16d4e24981f 100644 --- a/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/wizards/AbstractWizardMgtPanel.java +++ b/client/idrepo/common-ui/src/main/java/org/apache/syncope/client/ui/commons/wizards/AbstractWizardMgtPanel.java @@ -19,10 +19,9 @@ package org.apache.syncope.client.ui.commons.wizards; import java.io.Serializable; -import org.apache.wicket.event.IEventSource; import org.apache.wicket.markup.html.panel.Panel; -public abstract class AbstractWizardMgtPanel extends Panel implements IEventSource { +public abstract class AbstractWizardMgtPanel extends Panel { private static final long serialVersionUID = -4152438633429194882L; diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/MultilevelPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/MultilevelPanel.java index 8d60be6933f..0642f430303 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/MultilevelPanel.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/MultilevelPanel.java @@ -20,7 +20,6 @@ import org.apache.wicket.ajax.AjaxRequestTarget; import org.apache.wicket.ajax.markup.html.AjaxLink; -import org.apache.wicket.markup.html.IHeaderContributor; import org.apache.wicket.markup.html.WebMarkupContainer; import org.apache.wicket.markup.html.basic.Label; import org.apache.wicket.markup.html.panel.Panel; @@ -28,7 +27,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -public class MultilevelPanel extends Panel implements IHeaderContributor { +public class MultilevelPanel extends Panel { private static final long serialVersionUID = -4064294905566247729L; diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/PlainSchemaDetails.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/PlainSchemaDetails.java index f230c5683e1..a81a9227403 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/PlainSchemaDetails.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/PlainSchemaDetails.java @@ -151,7 +151,7 @@ public PlainSchemaDetails(final String id, final PlainSchemaTO schemaTO) { dropdownValueProvider = new AjaxDropDownChoicePanel<>("dropdownValueProvider", getString("dropdownValueProvider"), new PropertyModel<>(schemaTO, "dropdownValueProvider")); dropdownValueProvider.setOutputMarkupId(true); - ((DropDownChoice) dropdownValueProvider.getField()).setNullValid(true); + ((DropDownChoice) dropdownValueProvider.getField()).setNullValid(true); dropdownValueProvider.setChoices(dropdownValueProviders.getObject()); dropdownValueProvider.setRequired(true); @@ -225,7 +225,7 @@ protected void onUpdate(final AjaxRequestTarget target) { validator = new AjaxDropDownChoicePanel<>("validator", getString("validator"), new PropertyModel<>(schemaTO, "validator")); validator.setOutputMarkupId(true); - ((DropDownChoice) validator.getField()).setNullValid(true); + ((DropDownChoice) validator.getField()).setNullValid(true); validator.setChoices(validators.getObject()); add(validator); diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/SearchClausePanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/SearchClausePanel.java index b45c4ced153..3f6e2c8bc30 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/SearchClausePanel.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/panels/search/SearchClausePanel.java @@ -854,7 +854,7 @@ protected void adjust(final Type type, final AjaxTextFieldPanel property, final } } - @SuppressWarnings("unchecked") + @SuppressWarnings({ "unchecked", "rawtypes" }) protected FieldPanel buildValue(final SearchClause searchClause, final AjaxTextFieldPanel property) { PlainSchemaTO plainSchema = Optional.ofNullable(anames.getObject().get(property.getModelObject())). orElseGet(() -> { diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/policies/PolicyRuleDirectoryPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/policies/PolicyRuleDirectoryPanel.java index eff7a67aa73..1421312b615 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/policies/PolicyRuleDirectoryPanel.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/policies/PolicyRuleDirectoryPanel.java @@ -239,7 +239,6 @@ public PolicyRuleDataProvider(final int paginatorRows) { comparator = new SortableDataProviderComparator<>(this); } - @SuppressWarnings("unchecked") private List getPolicyRuleWrappers(final ComposablePolicy policy) { return policy.getRules().stream().map(rule -> { ImplementationTO implementation = implementationRestClient.read(implementationType, rule); diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/rest/PolicyRestClient.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/rest/PolicyRestClient.java index 2586f7d6681..798383aaede 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/rest/PolicyRestClient.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/rest/PolicyRestClient.java @@ -44,7 +44,6 @@ public T read(final PolicyType type, final String key) { return policy; } - @SuppressWarnings("unchecked") public List list(final PolicyType type) { try { return getService(PolicyService.class).list(type).stream(). diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/NotificationTaskDirectoryPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/NotificationTaskDirectoryPanel.java index af66bcb3194..d0e377ed5df 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/NotificationTaskDirectoryPanel.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/NotificationTaskDirectoryPanel.java @@ -35,7 +35,6 @@ import org.apache.syncope.client.console.wicket.markup.html.form.ActionLink.ActionType; import org.apache.syncope.client.console.wicket.markup.html.form.ActionsPanel; import org.apache.syncope.client.ui.commons.Constants; -import org.apache.syncope.client.ui.commons.panels.ModalPanel; import org.apache.syncope.common.lib.SyncopeClientException; import org.apache.syncope.common.lib.to.NotificationTaskTO; import org.apache.syncope.common.lib.types.AnyTypeKind; @@ -49,8 +48,7 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.StringResourceModel; -public abstract class NotificationTaskDirectoryPanel - extends TaskDirectoryPanel implements ModalPanel { +public abstract class NotificationTaskDirectoryPanel extends TaskDirectoryPanel { private static final long serialVersionUID = 4984337552918213290L; diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/PropagationTaskDirectoryPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/PropagationTaskDirectoryPanel.java index d31101eccb9..3e28f5eeab4 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/PropagationTaskDirectoryPanel.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/PropagationTaskDirectoryPanel.java @@ -35,7 +35,6 @@ import org.apache.syncope.client.console.wicket.markup.html.form.ActionLink.ActionType; import org.apache.syncope.client.console.wicket.markup.html.form.ActionsPanel; import org.apache.syncope.client.ui.commons.Constants; -import org.apache.syncope.client.ui.commons.panels.ModalPanel; import org.apache.syncope.common.lib.SyncopeClientException; import org.apache.syncope.common.lib.SyncopeConstants; import org.apache.syncope.common.lib.to.PropagationTaskTO; @@ -49,8 +48,7 @@ import org.apache.wicket.model.Model; import org.apache.wicket.model.StringResourceModel; -public abstract class PropagationTaskDirectoryPanel - extends TaskDirectoryPanel implements ModalPanel { +public abstract class PropagationTaskDirectoryPanel extends TaskDirectoryPanel { private static final long serialVersionUID = 4984337552918213290L; diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/SchedTaskDirectoryPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/SchedTaskDirectoryPanel.java index 175d360e70b..ce71b15dea8 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/SchedTaskDirectoryPanel.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/tasks/SchedTaskDirectoryPanel.java @@ -43,7 +43,6 @@ import org.apache.syncope.client.console.wicket.ws.BasePageWebSocketBehavior; import org.apache.syncope.client.console.widgets.JobActionPanel; import org.apache.syncope.client.ui.commons.Constants; -import org.apache.syncope.client.ui.commons.panels.ModalPanel; import org.apache.syncope.client.ui.commons.wizards.AjaxWizard; import org.apache.syncope.common.lib.SyncopeClientException; import org.apache.syncope.common.lib.to.AnyTO; @@ -75,8 +74,7 @@ * * @param Sched task type. */ -public abstract class SchedTaskDirectoryPanel - extends TaskDirectoryPanel implements ModalPanel { +public abstract class SchedTaskDirectoryPanel extends TaskDirectoryPanel { private static final long serialVersionUID = 4984337552918213290L; diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/head/MetaHeaderItem.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/head/MetaHeaderItem.java index 66910278e85..cf048bbee83 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/head/MetaHeaderItem.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/head/MetaHeaderItem.java @@ -18,12 +18,11 @@ */ package org.apache.syncope.client.console.wicket.markup.head; -import java.io.Serializable; import java.util.List; import org.apache.wicket.markup.head.HeaderItem; import org.apache.wicket.request.Response; -public class MetaHeaderItem extends HeaderItem implements Serializable { +public class MetaHeaderItem extends HeaderItem { private static final long serialVersionUID = 7578609827530302053L; diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/AjaxCharacterFieldPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/AjaxCharacterFieldPanel.java index 2d5f1f94e51..10d90246561 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/AjaxCharacterFieldPanel.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/AjaxCharacterFieldPanel.java @@ -35,7 +35,7 @@ import org.apache.wicket.model.ResourceModel; import org.apache.wicket.validation.IValidator; -public class AjaxCharacterFieldPanel extends FieldPanel implements Cloneable { +public class AjaxCharacterFieldPanel extends FieldPanel { private static final long serialVersionUID = 238940918106696068L; diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/AjaxSearchFieldPanel.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/AjaxSearchFieldPanel.java index a48e4fd01a0..4417e6ade5a 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/AjaxSearchFieldPanel.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wicket/markup/html/form/AjaxSearchFieldPanel.java @@ -32,7 +32,7 @@ import org.apache.wicket.model.IModel; import org.apache.wicket.model.ResourceModel; -public abstract class AjaxSearchFieldPanel extends TextFieldPanel implements Cloneable { +public abstract class AjaxSearchFieldPanel extends TextFieldPanel { private static final long serialVersionUID = 6890905510177974519L; diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/widgets/JobWidget.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/widgets/JobWidget.java index 9deb5e0a611..f1fa6d4334c 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/widgets/JobWidget.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/widgets/JobWidget.java @@ -519,7 +519,6 @@ protected boolean statusCondition(final JobTO modelObject) { } @Override - @SuppressWarnings("unchecked") public void onEvent(final IEvent event) { if (event.getPayload() instanceof AjaxWizard.NewItemCancelEvent || event.getPayload() instanceof AjaxWizard.NewItemFinishEvent) { diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/widgets/NumberWidget.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/widgets/NumberWidget.java index 151b1dd8b5e..2138b03ab9b 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/widgets/NumberWidget.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/widgets/NumberWidget.java @@ -54,7 +54,6 @@ public NumberWidget(final String id, final String bg, final Number number, final WebMarkupContainer box = new WebMarkupContainer("card"); box.add(new AttributeAppender("class", ' ' + bg)); - @SuppressWarnings("unchecked") Class realms = SyncopeWebApplication.get().getPageClass("anys"); if (realms == null) { realms = Anys.class; diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/any/AbstractAttrsWizardStep.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/any/AbstractAttrsWizardStep.java index b663fa0b3ae..1f6bd71bbb8 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/any/AbstractAttrsWizardStep.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/any/AbstractAttrsWizardStep.java @@ -425,7 +425,7 @@ public PlainSchemas(final String id) { super(id); } - @SuppressWarnings({ "unchecked", "rawtypes" }) + @SuppressWarnings({ "unchecked" }) protected AbstractFieldPanel setPanel( final Map schemas, final ListItem item, diff --git a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/role/RoleWizardBuilder.java b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/role/RoleWizardBuilder.java index 11818c32511..09bf67a3041 100644 --- a/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/role/RoleWizardBuilder.java +++ b/client/idrepo/console/src/main/java/org/apache/syncope/client/console/wizards/role/RoleWizardBuilder.java @@ -168,7 +168,7 @@ protected Iterator getChoices(final String input) { new PropertyModel<>(modelObject, "realms")).build( "realms", "realms", - (FieldPanel) realm).hideLabel()); + (FieldPanel) realm).hideLabel()); } } } diff --git a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/pages/SelfResult.java b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/pages/SelfResult.java index eb066bb735e..a29f2395a34 100644 --- a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/pages/SelfResult.java +++ b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/pages/SelfResult.java @@ -87,7 +87,7 @@ public SelfResult(final ProvisioningResult provisioningResult, final Pag (Serializable) provisioningResult.getPropagationStatuses().stream() .filter(ps -> ExecStatus.SUCCESS != ps.getStatus()) .map(ps -> StatusUtils.getStatusBean(provisioningResult.getEntity(), ps.getResource(), - ps.getAfterObj(), false)).collect(Collectors.toList()), getPageReference()) + ps.getAfterObj(), false)).collect(Collectors.toList())) .setOutputMarkupId(true) .setVisible(SyncopeWebApplication.get().isReportPropagationErrorDetails())); } diff --git a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/AnyFormPanel.java b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/AnyFormPanel.java index ac40a2439da..4afd2c5b258 100644 --- a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/AnyFormPanel.java +++ b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/AnyFormPanel.java @@ -58,7 +58,6 @@ public AnyFormPanel(final String id, this.anyTypeClasses = anyTypeClasses; } - @SuppressWarnings("unchecked") public AnyFormPanel(final String id, final UserWrapper wrapper, final List anyTypeClasses, diff --git a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/ResultPanel.java b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/ResultPanel.java index da83052e59b..fdc7c871e43 100644 --- a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/ResultPanel.java +++ b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/ResultPanel.java @@ -25,7 +25,6 @@ import org.apache.syncope.client.ui.commons.status.StatusUtils; import org.apache.syncope.client.ui.commons.wizards.any.AbstractResultPanel; import org.apache.wicket.Component; -import org.apache.wicket.PageReference; import org.apache.wicket.markup.html.panel.Panel; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -36,17 +35,14 @@ public class ResultPanel extends AbstractResultPanel { protected static final Logger LOG = LoggerFactory.getLogger(ResultPanel.class); - private final PageReference pageRef; - - public ResultPanel(final String item, final Serializable errors, final PageReference pageRef) { + public ResultPanel(final String item, final Serializable errors) { super(item, errors); - this.pageRef = pageRef; } @SuppressWarnings("unchecked") @Override protected Panel customResultBody(final String panelId, final String item, final Serializable errorBeans) { - return new SimpleListViewPanel.Builder<>(StatusBean.class, pageRef) { + return new SimpleListViewPanel.Builder<>(StatusBean.class) { private static final long serialVersionUID = -6809736686861678498L; diff --git a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/any/PlainAttrs.java b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/any/PlainAttrs.java index 85e6c464e52..cecb9fffbe8 100644 --- a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/any/PlainAttrs.java +++ b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/panels/any/PlainAttrs.java @@ -410,7 +410,7 @@ protected PlainSchemas( private static final long serialVersionUID = 5306618783986001008L; @Override - @SuppressWarnings({ "unchecked", "rawtypes" }) + @SuppressWarnings({ "unchecked" }) protected void populateItem(final ListItem item) { Attr attr = item.getModelObject(); PlainSchemaTO schema = schemas.get(attr.getSchema()); diff --git a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/wicket/markup/head/MetaHeaderItem.java b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/wicket/markup/head/MetaHeaderItem.java index 90ccf60ec4c..ffa0333ec40 100644 --- a/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/wicket/markup/head/MetaHeaderItem.java +++ b/client/idrepo/enduser/src/main/java/org/apache/syncope/client/enduser/wicket/markup/head/MetaHeaderItem.java @@ -18,12 +18,11 @@ */ package org.apache.syncope.client.enduser.wicket.markup.head; -import java.io.Serializable; import java.util.Arrays; import org.apache.wicket.markup.head.HeaderItem; import org.apache.wicket.request.Response; -public class MetaHeaderItem extends HeaderItem implements Serializable { +public class MetaHeaderItem extends HeaderItem { private static final long serialVersionUID = 7578609827530302053L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/AppleOIDCAuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/AppleOIDCAuthModuleConf.java index cc1ce7a80d4..29566224618 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/AppleOIDCAuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/AppleOIDCAuthModuleConf.java @@ -21,7 +21,7 @@ import java.util.Map; import org.apache.syncope.common.lib.to.AuthModuleTO; -public class AppleOIDCAuthModuleConf extends AbstractOIDCAuthModuleConf implements AuthModuleConf { +public class AppleOIDCAuthModuleConf extends AbstractOIDCAuthModuleConf { private static final long serialVersionUID = -471527731042579522L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/AzureOIDCAuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/AzureOIDCAuthModuleConf.java index f1cd5b73f18..0ffba995a6c 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/AzureOIDCAuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/AzureOIDCAuthModuleConf.java @@ -21,7 +21,7 @@ import java.util.Map; import org.apache.syncope.common.lib.to.AuthModuleTO; -public class AzureOIDCAuthModuleConf extends AbstractOIDCAuthModuleConf implements AuthModuleConf { +public class AzureOIDCAuthModuleConf extends AbstractOIDCAuthModuleConf { private static final long serialVersionUID = -471527731042579522L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/GoogleMfaAuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/GoogleMfaAuthModuleConf.java index bbd17cd91d0..20d17c5d86d 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/GoogleMfaAuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/GoogleMfaAuthModuleConf.java @@ -18,7 +18,6 @@ */ package org.apache.syncope.common.lib.auth; -import java.io.Serializable; import java.util.Map; import org.apache.commons.lang3.StringUtils; import org.apache.syncope.common.lib.AbstractLDAPConf; @@ -41,7 +40,7 @@ public enum CryptoStrategy { } - public static class LDAP extends AbstractLDAPConf implements Serializable { + public static class LDAP extends AbstractLDAPConf { private static final long serialVersionUID = -7274446267090678730L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/GoogleOIDCAuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/GoogleOIDCAuthModuleConf.java index f848f450a74..fe8e11a9c3c 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/GoogleOIDCAuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/GoogleOIDCAuthModuleConf.java @@ -21,7 +21,7 @@ import java.util.Map; import org.apache.syncope.common.lib.to.AuthModuleTO; -public class GoogleOIDCAuthModuleConf extends AbstractOIDCAuthModuleConf implements AuthModuleConf { +public class GoogleOIDCAuthModuleConf extends AbstractOIDCAuthModuleConf { private static final long serialVersionUID = -471527731042579522L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/KeycloakOIDCAuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/KeycloakOIDCAuthModuleConf.java index a4f464c157d..398ba2426e2 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/KeycloakOIDCAuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/KeycloakOIDCAuthModuleConf.java @@ -21,7 +21,7 @@ import java.util.Map; import org.apache.syncope.common.lib.to.AuthModuleTO; -public class KeycloakOIDCAuthModuleConf extends AbstractOIDCAuthModuleConf implements AuthModuleConf { +public class KeycloakOIDCAuthModuleConf extends AbstractOIDCAuthModuleConf { private static final long serialVersionUID = -471527731042579522L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/OAuth20AuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/OAuth20AuthModuleConf.java index 8d7b97eb8df..c04b837ab59 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/OAuth20AuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/OAuth20AuthModuleConf.java @@ -22,7 +22,7 @@ import java.util.Map; import org.apache.syncope.common.lib.to.AuthModuleTO; -public class OAuth20AuthModuleConf extends AbstractOAuth20AuthModuleConf implements AuthModuleConf { +public class OAuth20AuthModuleConf extends AbstractOAuth20AuthModuleConf { private static final long serialVersionUID = 299820485764241682L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/OIDCAuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/OIDCAuthModuleConf.java index 0ea9339c3b3..bdb8fd127aa 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/OIDCAuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/OIDCAuthModuleConf.java @@ -21,7 +21,7 @@ import java.util.Map; import org.apache.syncope.common.lib.to.AuthModuleTO; -public class OIDCAuthModuleConf extends AbstractOIDCAuthModuleConf implements AuthModuleConf { +public class OIDCAuthModuleConf extends AbstractOIDCAuthModuleConf { private static final long serialVersionUID = -471527711042579422L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SAML2IdPAuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SAML2IdPAuthModuleConf.java index 35e4e0c839c..58d087f45c7 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SAML2IdPAuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SAML2IdPAuthModuleConf.java @@ -25,7 +25,7 @@ import org.apache.syncope.common.lib.types.SAML2BindingType; import org.apache.syncope.common.lib.types.TriStateBoolean; -public class SAML2IdPAuthModuleConf extends Pac4jAuthModuleConf implements AuthModuleConf { +public class SAML2IdPAuthModuleConf extends Pac4jAuthModuleConf { private static final long serialVersionUID = -471527731042579422L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SpnegoAuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SpnegoAuthModuleConf.java index 9d80778ea13..2e0938f122e 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SpnegoAuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/SpnegoAuthModuleConf.java @@ -18,7 +18,6 @@ */ package org.apache.syncope.common.lib.auth; -import java.io.Serializable; import java.util.Map; import org.apache.syncope.common.lib.AbstractLDAPConf; import org.apache.syncope.common.lib.to.AuthModuleTO; @@ -32,7 +31,7 @@ public class SpnegoAuthModuleConf implements LDAPDependantAuthModuleConf { private static final long serialVersionUID = -7775771400312303131L; - public static class LDAP extends AbstractLDAPConf implements Serializable { + public static class LDAP extends AbstractLDAPConf { private static final long serialVersionUID = -7274446267090678730L; diff --git a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/X509AuthModuleConf.java b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/X509AuthModuleConf.java index 227bb0bbb84..80bcc9e421f 100644 --- a/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/X509AuthModuleConf.java +++ b/common/am/lib/src/main/java/org/apache/syncope/common/lib/auth/X509AuthModuleConf.java @@ -18,7 +18,6 @@ */ package org.apache.syncope.common.lib.auth; -import java.io.Serializable; import java.util.ArrayList; import java.util.List; import java.util.Map; @@ -34,7 +33,7 @@ public class X509AuthModuleConf implements LDAPDependantAuthModuleConf { private static final long serialVersionUID = 1915254775199296906L; - public static class LDAP extends AbstractLDAPConf implements Serializable { + public static class LDAP extends AbstractLDAPConf { private static final long serialVersionUID = -7274446267090678730L; diff --git a/common/idm/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractCorrelationRuleConf.java b/common/idm/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractCorrelationRuleConf.java index e88c8403151..537cb93b1b5 100644 --- a/common/idm/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractCorrelationRuleConf.java +++ b/common/idm/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractCorrelationRuleConf.java @@ -19,9 +19,8 @@ package org.apache.syncope.common.lib.policy; import org.apache.commons.lang3.StringUtils; -import org.apache.syncope.common.lib.BaseBean; -public abstract class AbstractCorrelationRuleConf implements BaseBean, RuleConf { +public abstract class AbstractCorrelationRuleConf implements RuleConf { private static final long serialVersionUID = -4080475005967851092L; diff --git a/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/LogOutputStream.java b/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/LogOutputStream.java index 594560aa627..9e1ce8ce470 100644 --- a/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/LogOutputStream.java +++ b/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/LogOutputStream.java @@ -27,7 +27,7 @@ * Delegates output stream writing onto an SLF4J logger. * Inspired by {@code org.apache.commons.exec.LogOutputStream} */ -public class LogOutputStream extends OutputStream implements AutoCloseable { +public class LogOutputStream extends OutputStream { /** Initial buffer size. */ private static final int INTIAL_SIZE = 132; diff --git a/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractAccountRuleConf.java b/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractAccountRuleConf.java index 881423af6ac..7e15f4ad714 100644 --- a/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractAccountRuleConf.java +++ b/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractAccountRuleConf.java @@ -19,9 +19,8 @@ package org.apache.syncope.common.lib.policy; import org.apache.commons.lang3.StringUtils; -import org.apache.syncope.common.lib.BaseBean; -public abstract class AbstractAccountRuleConf implements BaseBean, AccountRuleConf { +public abstract class AbstractAccountRuleConf implements AccountRuleConf { private static final long serialVersionUID = -4080475005967851092L; diff --git a/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractPasswordRuleConf.java b/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractPasswordRuleConf.java index 83e2f20da0f..8d3f7e246ab 100644 --- a/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractPasswordRuleConf.java +++ b/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/AbstractPasswordRuleConf.java @@ -19,9 +19,8 @@ package org.apache.syncope.common.lib.policy; import org.apache.commons.lang3.StringUtils; -import org.apache.syncope.common.lib.BaseBean; -public abstract class AbstractPasswordRuleConf implements BaseBean, PasswordRuleConf { +public abstract class AbstractPasswordRuleConf implements PasswordRuleConf { private static final long serialVersionUID = -5814018872387142339L; diff --git a/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/DefaultAccountRuleConf.java b/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/DefaultAccountRuleConf.java index 9f653ab4f89..37540176c71 100644 --- a/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/DefaultAccountRuleConf.java +++ b/common/idrepo/lib/src/main/java/org/apache/syncope/common/lib/policy/DefaultAccountRuleConf.java @@ -24,7 +24,7 @@ import org.apache.syncope.common.lib.types.AnyTypeKind; import org.apache.syncope.common.lib.types.SchemaType; -public class DefaultAccountRuleConf extends AbstractAccountRuleConf implements AccountRuleConf { +public class DefaultAccountRuleConf extends AbstractAccountRuleConf { private static final long serialVersionUID = 3259256974414758406L; diff --git a/common/idrepo/lib/src/test/java/org/apache/syncope/common/lib/search/SyncopeFiqlParserTest.java b/common/idrepo/lib/src/test/java/org/apache/syncope/common/lib/search/SyncopeFiqlParserTest.java index 422cde3b879..e8fb655c133 100644 --- a/common/idrepo/lib/src/test/java/org/apache/syncope/common/lib/search/SyncopeFiqlParserTest.java +++ b/common/idrepo/lib/src/test/java/org/apache/syncope/common/lib/search/SyncopeFiqlParserTest.java @@ -32,11 +32,10 @@ public class SyncopeFiqlParserTest { private static final SyncopeFiqlParser FIQL_PARSER = new SyncopeFiqlParser<>( SearchBean.class, AbstractFiqlSearchConditionBuilder.CONTEXTUAL_PROPERTIES); - @SuppressWarnings("unchecked") private static SyncopeFiqlSearchCondition parse(final String fiql) { SearchCondition parsed = FIQL_PARSER.parse(fiql); assertTrue(parsed instanceof SyncopeFiqlSearchCondition); - return (SyncopeFiqlSearchCondition) parsed; + return (SyncopeFiqlSearchCondition) parsed; } @Test diff --git a/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/AbstractAnyLogic.java b/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/AbstractAnyLogic.java index 00bc9e77c3c..610dfe78f87 100644 --- a/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/AbstractAnyLogic.java +++ b/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/AbstractAnyLogic.java @@ -84,7 +84,6 @@ protected List getActions(final Realm realm) { return result; } - @SuppressWarnings("unchecked") protected BeforeResult beforeCreate(final C input) { Realm realm = realmSearchDAO.findByFullPath(input.getRealm()).orElseThrow(() -> { SyncopeClientException sce = SyncopeClientException.build(ClientExceptionType.InvalidRealm); @@ -121,7 +120,6 @@ protected BeforeResult beforeCreate(final C input) { return new BeforeResult<>(actionedCR, actions); } - @SuppressWarnings("unchecked") protected BeforeResult beforeUpdate(final U input, final String realmPath) { Realm realm = realmSearchDAO.findByFullPath(realmPath).orElseThrow(() -> { SyncopeClientException sce = SyncopeClientException.build(ClientExceptionType.InvalidRealm); @@ -141,7 +139,6 @@ protected BeforeResult beforeUpdate(final U input, final String realmPath) { return new BeforeResult<>(update, actions); } - @SuppressWarnings("unchecked") protected BeforeResult beforeDelete(final TO input) { Realm realm = realmSearchDAO.findByFullPath(input.getRealm()).orElseThrow(() -> { SyncopeClientException sce = SyncopeClientException.build(ClientExceptionType.InvalidRealm); @@ -161,7 +158,6 @@ protected BeforeResult beforeDelete(final TO input) { return new BeforeResult<>(any, actions); } - @SuppressWarnings("unchecked") protected ProvisioningResult afterCreate( final TO input, final List statuses, final List actions) { @@ -196,7 +192,6 @@ protected ProvisioningResult afterUpdate( return result; } - @SuppressWarnings("unchecked") protected ProvisioningResult afterDelete( final TO input, final List statuses, final List actions) { diff --git a/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/LogicInvocationHandler.java b/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/LogicInvocationHandler.java index 3774adaf47e..23448b7eb01 100644 --- a/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/LogicInvocationHandler.java +++ b/core/idrepo/logic/src/main/java/org/apache/syncope/core/logic/LogicInvocationHandler.java @@ -46,6 +46,7 @@ public LogicInvocationHandler(final NotificationManager notificationManager, fin this.auditManager = auditManager; } + @SuppressWarnings("rawtypes") @Around("execution(* org.apache.syncope.core.logic.AbstractLogic+.*(..))") public Object around(final ProceedingJoinPoint joinPoint) throws Throwable { Class clazz = joinPoint.getTarget().getClass(); diff --git a/core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/TaskServiceImpl.java b/core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/TaskServiceImpl.java index 79e8b505420..7e0a716651a 100644 --- a/core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/TaskServiceImpl.java +++ b/core/idrepo/rest-cxf/src/main/java/org/apache/syncope/core/rest/cxf/service/TaskServiceImpl.java @@ -76,7 +76,6 @@ public void delete(final TaskType type, final String key) { logic.delete(type, key); } - @SuppressWarnings("unchecked") @Override public PagedResult search(final TaskQuery query) { Page result = logic.search( diff --git a/core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/Any.java b/core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/Any.java index a6e6fa828bb..6bfac4c9b33 100644 --- a/core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/Any.java +++ b/core/persistence-api/src/main/java/org/apache/syncope/core/persistence/api/entity/Any.java @@ -23,7 +23,7 @@ import org.apache.syncope.core.persistence.api.entity.group.Group; import org.apache.syncope.core.persistence.api.entity.user.User; -public interface Any extends Attributable, Entity { +public interface Any extends Attributable { OffsetDateTime getCreationDate(); diff --git a/core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/content/MultiParentNode.java b/core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/content/MultiParentNode.java index a6c8df07780..d92ee50fb89 100644 --- a/core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/content/MultiParentNode.java +++ b/core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/content/MultiParentNode.java @@ -102,7 +102,6 @@ public boolean equals(final Object obj) { if (getClass() != obj.getClass()) { return false; } - @SuppressWarnings("unchecked") final MultiParentNode other = (MultiParentNode) obj; return new EqualsBuilder(). append(object, other.object). diff --git a/core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/dao/AbstractAnyMatchDAO.java b/core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/dao/AbstractAnyMatchDAO.java index 7b19f5e6c4d..1db6cb50d27 100644 --- a/core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/dao/AbstractAnyMatchDAO.java +++ b/core/persistence-common/src/main/java/org/apache/syncope/core/persistence/common/dao/AbstractAnyMatchDAO.java @@ -131,21 +131,21 @@ public boolean matches(final T any, final SearchCond cond) { if (match == null) { match = cond.asLeaf(RelationshipTypeCond.class). filter(leaf -> any instanceof Groupable). - map(leaf -> matches((Relatable) any, leaf, not)). + map(leaf -> matches((Relatable) any, leaf, not)). orElse(null); } if (match == null) { match = cond.asLeaf(RelationshipCond.class). filter(leaf -> any instanceof Groupable). - map(leaf -> matches((Relatable) any, leaf, not)). + map(leaf -> matches((Relatable) any, leaf, not)). orElse(null); } if (match == null) { match = cond.asLeaf(MembershipCond.class). filter(leaf -> any instanceof Groupable). - map(leaf -> matches((Groupable) any, leaf, not)). + map(leaf -> matches((Groupable) any, leaf, not)). orElse(null); } @@ -346,7 +346,6 @@ protected boolean matches(final Any any, final AttrCond cond, final boolean not) return false; } - @SuppressWarnings("unchecked") Optional attr = (Optional) any.getPlainAttr(cond.getSchema()); boolean found; diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/content/XMLContentExporter.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/content/XMLContentExporter.java index dbb7b5d69a0..7419fd80192 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/content/XMLContentExporter.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/content/XMLContentExporter.java @@ -196,7 +196,7 @@ protected static Map> relationTables(final Map) a).getElementType()); } relationTables.put( diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPALiveSyncTaskExec.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPALiveSyncTaskExec.java index 4b4278dcdaa..4b2632889b2 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPALiveSyncTaskExec.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPALiveSyncTaskExec.java @@ -23,11 +23,10 @@ import jakarta.persistence.Table; import org.apache.syncope.core.persistence.api.entity.task.LiveSyncTask; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; @Entity @Table(name = JPALiveSyncTaskExec.TABLE) -public class JPALiveSyncTaskExec extends AbstractTaskExec implements TaskExec { +public class JPALiveSyncTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAMacroTaskExec.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAMacroTaskExec.java index 18f96686ad9..4b991f8fcf2 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAMacroTaskExec.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAMacroTaskExec.java @@ -23,11 +23,10 @@ import jakarta.persistence.Table; import org.apache.syncope.core.persistence.api.entity.task.MacroTask; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; @Entity @Table(name = JPAMacroTaskExec.TABLE) -public class JPAMacroTaskExec extends AbstractTaskExec implements TaskExec { +public class JPAMacroTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPANotificationTaskExec.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPANotificationTaskExec.java index e37a947dcc6..8e566cc5071 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPANotificationTaskExec.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPANotificationTaskExec.java @@ -22,11 +22,10 @@ import jakarta.persistence.ManyToOne; import jakarta.persistence.Table; import org.apache.syncope.core.persistence.api.entity.task.NotificationTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; @Entity @Table(name = JPANotificationTaskExec.TABLE) -public class JPANotificationTaskExec extends AbstractTaskExec implements TaskExec { +public class JPANotificationTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPropagationTaskExec.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPropagationTaskExec.java index 010fe8d14df..3366b471d0f 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPropagationTaskExec.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPropagationTaskExec.java @@ -22,11 +22,10 @@ import jakarta.persistence.ManyToOne; import jakarta.persistence.Table; import org.apache.syncope.core.persistence.api.entity.task.PropagationTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; @Entity @Table(name = JPAPropagationTaskExec.TABLE) -public class JPAPropagationTaskExec extends AbstractTaskExec implements TaskExec { +public class JPAPropagationTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPullTaskExec.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPullTaskExec.java index 7e1f1d98144..6eff92a4c46 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPullTaskExec.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPullTaskExec.java @@ -23,11 +23,10 @@ import jakarta.persistence.Table; import org.apache.syncope.core.persistence.api.entity.task.PullTask; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; @Entity @Table(name = JPAPullTaskExec.TABLE) -public class JPAPullTaskExec extends AbstractTaskExec implements TaskExec { +public class JPAPullTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPushTaskExec.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPushTaskExec.java index 2aaa02c9660..00015020e6c 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPushTaskExec.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPAPushTaskExec.java @@ -23,11 +23,10 @@ import jakarta.persistence.Table; import org.apache.syncope.core.persistence.api.entity.task.PushTask; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; @Entity @Table(name = JPAPushTaskExec.TABLE) -public class JPAPushTaskExec extends AbstractTaskExec implements TaskExec { +public class JPAPushTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPASchedTaskExec.java b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPASchedTaskExec.java index 655e7a9e447..3f008c06322 100644 --- a/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPASchedTaskExec.java +++ b/core/persistence-jpa/src/main/java/org/apache/syncope/core/persistence/jpa/entity/task/JPASchedTaskExec.java @@ -22,11 +22,10 @@ import jakarta.persistence.ManyToOne; import jakarta.persistence.Table; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; @Entity @Table(name = JPASchedTaskExec.TABLE) -public class JPASchedTaskExec extends AbstractTaskExec implements TaskExec { +public class JPASchedTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jPolicyDAO.java b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jPolicyDAO.java index 93f913a1de3..260a78fc6a4 100644 --- a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jPolicyDAO.java +++ b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/dao/Neo4jPolicyDAO.java @@ -135,7 +135,6 @@ public Optional findById(final String key) { flatMap(toOptional("n.id", Neo4jPolicy.class, null)); } - @SuppressWarnings("unchecked") @Override public Optional findById(final String key, final Class reference) { return neo4jTemplate.findById(key, getNodeReference(reference)).map(reference::cast); diff --git a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jLiveSyncTaskExec.java b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jLiveSyncTaskExec.java index cfe2e34b7f6..930ba330e6e 100644 --- a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jLiveSyncTaskExec.java +++ b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jLiveSyncTaskExec.java @@ -20,12 +20,11 @@ import org.apache.syncope.core.persistence.api.entity.task.LiveSyncTask; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; import org.springframework.data.neo4j.core.schema.Node; import org.springframework.data.neo4j.core.schema.Relationship; @Node(Neo4jLiveSyncTaskExec.NODE) -public class Neo4jLiveSyncTaskExec extends AbstractTaskExec implements TaskExec { +public class Neo4jLiveSyncTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jMacroTaskExec.java b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jMacroTaskExec.java index 2dde2fb9e50..71e54a2b80c 100644 --- a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jMacroTaskExec.java +++ b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jMacroTaskExec.java @@ -21,12 +21,11 @@ import jakarta.validation.constraints.NotNull; import org.apache.syncope.core.persistence.api.entity.task.MacroTask; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; import org.springframework.data.neo4j.core.schema.Node; import org.springframework.data.neo4j.core.schema.Relationship; @Node(Neo4jMacroTaskExec.NODE) -public class Neo4jMacroTaskExec extends AbstractTaskExec implements TaskExec { +public class Neo4jMacroTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jNotificationTaskExec.java b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jNotificationTaskExec.java index 13d96935e6a..aa0c6c6c7f1 100644 --- a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jNotificationTaskExec.java +++ b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jNotificationTaskExec.java @@ -20,14 +20,11 @@ import jakarta.validation.constraints.NotNull; import org.apache.syncope.core.persistence.api.entity.task.NotificationTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; import org.springframework.data.neo4j.core.schema.Node; import org.springframework.data.neo4j.core.schema.Relationship; @Node(Neo4jNotificationTaskExec.NODE) -public class Neo4jNotificationTaskExec - extends AbstractTaskExec - implements TaskExec { +public class Neo4jNotificationTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPropagationTaskExec.java b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPropagationTaskExec.java index 4efcc63c91b..dda78c28de9 100644 --- a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPropagationTaskExec.java +++ b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPropagationTaskExec.java @@ -20,12 +20,11 @@ import jakarta.validation.constraints.NotNull; import org.apache.syncope.core.persistence.api.entity.task.PropagationTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; import org.springframework.data.neo4j.core.schema.Node; import org.springframework.data.neo4j.core.schema.Relationship; @Node(Neo4jPropagationTaskExec.NODE) -public class Neo4jPropagationTaskExec extends AbstractTaskExec implements TaskExec { +public class Neo4jPropagationTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPullTaskExec.java b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPullTaskExec.java index 993484b02d2..b0f406f7a67 100644 --- a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPullTaskExec.java +++ b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPullTaskExec.java @@ -20,12 +20,11 @@ import org.apache.syncope.core.persistence.api.entity.task.PullTask; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; import org.springframework.data.neo4j.core.schema.Node; import org.springframework.data.neo4j.core.schema.Relationship; @Node(Neo4jPullTaskExec.NODE) -public class Neo4jPullTaskExec extends AbstractTaskExec implements TaskExec { +public class Neo4jPullTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPushTaskExec.java b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPushTaskExec.java index 526d9a0e334..89ddb361d05 100644 --- a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPushTaskExec.java +++ b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jPushTaskExec.java @@ -21,12 +21,11 @@ import jakarta.validation.constraints.NotNull; import org.apache.syncope.core.persistence.api.entity.task.PushTask; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; import org.springframework.data.neo4j.core.schema.Node; import org.springframework.data.neo4j.core.schema.Relationship; @Node(Neo4jPushTaskExec.NODE) -public class Neo4jPushTaskExec extends AbstractTaskExec implements TaskExec { +public class Neo4jPushTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jSchedTaskExec.java b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jSchedTaskExec.java index c3895439279..560bc1c4102 100644 --- a/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jSchedTaskExec.java +++ b/core/persistence-neo4j/src/main/java/org/apache/syncope/core/persistence/neo4j/entity/task/Neo4jSchedTaskExec.java @@ -20,12 +20,11 @@ import jakarta.validation.constraints.NotNull; import org.apache.syncope.core.persistence.api.entity.task.SchedTask; -import org.apache.syncope.core.persistence.api.entity.task.TaskExec; import org.springframework.data.neo4j.core.schema.Node; import org.springframework.data.neo4j.core.schema.Relationship; @Node(Neo4jSchedTaskExec.NODE) -public class Neo4jSchedTaskExec extends AbstractTaskExec implements TaskExec { +public class Neo4jSchedTaskExec extends AbstractTaskExec { private static final long serialVersionUID = 1909033231464074554L; diff --git a/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/AnySearchTest.java b/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/AnySearchTest.java index 693ff9a01a5..8e3c5ed5c64 100644 --- a/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/AnySearchTest.java +++ b/core/persistence-neo4j/src/test/java/org/apache/syncope/core/persistence/neo4j/inner/AnySearchTest.java @@ -44,7 +44,6 @@ import org.apache.syncope.core.persistence.api.dao.PlainSchemaDAO; import org.apache.syncope.core.persistence.api.dao.RealmDAO; import org.apache.syncope.core.persistence.api.dao.RealmSearchDAO; -import org.apache.syncope.core.persistence.api.dao.RoleDAO; import org.apache.syncope.core.persistence.api.dao.UserDAO; import org.apache.syncope.core.persistence.api.dao.search.AnyCond; import org.apache.syncope.core.persistence.api.dao.search.AnyTypeCond; @@ -106,9 +105,6 @@ public class AnySearchTest extends AbstractTest { @Autowired private RealmSearchDAO realmSearchDAO; - @Autowired - private RoleDAO roleDAO; - @Autowired private PlainSchemaDAO plainSchemaDAO; diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AnyDataBinder.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AnyDataBinder.java index 52cebf434d0..ae2191aba87 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AnyDataBinder.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AnyDataBinder.java @@ -345,7 +345,6 @@ protected SyncopeClientException checkMandatory(final Any any, final AnyUtils an return reqValMissing; } - @SuppressWarnings({ "unchecked", "rawtypes" }) protected void processAttrPatch( final AnyTO anyTO, final Any any, diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/AbstractSchedTaskJobDelegate.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/AbstractSchedTaskJobDelegate.java index 138a577709d..826e5c18bc9 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/AbstractSchedTaskJobDelegate.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/job/AbstractSchedTaskJobDelegate.java @@ -167,7 +167,6 @@ protected void end() { } } - @SuppressWarnings("unchecked") @Transactional @Override public void execute( diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultAnyObjectPullResultHandler.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultAnyObjectPullResultHandler.java index 1904b985e15..2f04bd86f79 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultAnyObjectPullResultHandler.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultAnyObjectPullResultHandler.java @@ -33,13 +33,10 @@ import org.apache.syncope.core.provisioning.api.AnyObjectProvisioningManager; import org.apache.syncope.core.provisioning.api.ProvisioningManager; import org.apache.syncope.core.provisioning.api.WorkflowResult; -import org.apache.syncope.core.provisioning.api.pushpull.AnyPullResultHandler; import org.identityconnectors.framework.common.objects.SyncDelta; import org.springframework.beans.factory.annotation.Autowired; -public class DefaultAnyObjectPullResultHandler - extends AbstractPullResultHandler - implements AnyPullResultHandler { +public class DefaultAnyObjectPullResultHandler extends AbstractPullResultHandler { @Autowired private AnyObjectProvisioningManager anyObjectProvisioningManager; diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultAnyObjectPushResultHandler.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultAnyObjectPushResultHandler.java index e43751a0b23..e9313844d50 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultAnyObjectPushResultHandler.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultAnyObjectPushResultHandler.java @@ -26,9 +26,8 @@ import org.apache.syncope.core.persistence.api.entity.AnyUtils; import org.apache.syncope.core.persistence.api.entity.anyobject.AnyObject; import org.apache.syncope.core.provisioning.api.WorkflowResult; -import org.apache.syncope.core.provisioning.api.pushpull.AnyPushResultHandler; -public class DefaultAnyObjectPushResultHandler extends AbstractPushResultHandler implements AnyPushResultHandler { +public class DefaultAnyObjectPushResultHandler extends AbstractPushResultHandler { @Override protected AnyUtils anyUtils() { diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultGroupPullResultHandler.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultGroupPullResultHandler.java index c763e04c310..9125478edb8 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultGroupPullResultHandler.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultGroupPullResultHandler.java @@ -33,11 +33,10 @@ import org.apache.syncope.core.provisioning.api.GroupProvisioningManager; import org.apache.syncope.core.provisioning.api.ProvisioningManager; import org.apache.syncope.core.provisioning.api.WorkflowResult; -import org.apache.syncope.core.provisioning.api.pushpull.AnyPullResultHandler; import org.identityconnectors.framework.common.objects.SyncDelta; import org.springframework.beans.factory.annotation.Autowired; -public class DefaultGroupPullResultHandler extends AbstractPullResultHandler implements AnyPullResultHandler { +public class DefaultGroupPullResultHandler extends AbstractPullResultHandler { @Autowired private GroupProvisioningManager groupProvisioningManager; diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultGroupPushResultHandler.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultGroupPushResultHandler.java index 4adcc73a0fe..cfb2239fa5e 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultGroupPushResultHandler.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultGroupPushResultHandler.java @@ -26,9 +26,8 @@ import org.apache.syncope.core.persistence.api.entity.AnyUtils; import org.apache.syncope.core.persistence.api.entity.group.Group; import org.apache.syncope.core.provisioning.api.WorkflowResult; -import org.apache.syncope.core.provisioning.api.pushpull.AnyPushResultHandler; -public class DefaultGroupPushResultHandler extends AbstractPushResultHandler implements AnyPushResultHandler { +public class DefaultGroupPushResultHandler extends AbstractPushResultHandler { @Override protected AnyUtils anyUtils() { diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultUserPullResultHandler.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultUserPullResultHandler.java index a468a81c6b7..e2f63adc948 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultUserPullResultHandler.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/DefaultUserPullResultHandler.java @@ -53,14 +53,13 @@ import org.apache.syncope.core.provisioning.api.WorkflowResult; import org.apache.syncope.core.provisioning.api.job.JobExecutionException; import org.apache.syncope.core.provisioning.api.propagation.PropagationException; -import org.apache.syncope.core.provisioning.api.pushpull.AnyPullResultHandler; import org.apache.syncope.core.provisioning.api.pushpull.InboundActions; import org.apache.syncope.core.provisioning.api.rules.InboundMatch; import org.identityconnectors.framework.common.objects.AttributeUtil; import org.identityconnectors.framework.common.objects.SyncDelta; import org.springframework.beans.factory.annotation.Autowired; -public class DefaultUserPullResultHandler extends AbstractPullResultHandler implements AnyPullResultHandler { +public class DefaultUserPullResultHandler extends AbstractPullResultHandler { @Autowired protected UserProvisioningManager userProvisioningManager; diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LiveSyncJobDelegate.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LiveSyncJobDelegate.java index 77f5394afc5..daf1acac15d 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LiveSyncJobDelegate.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/LiveSyncJobDelegate.java @@ -53,7 +53,6 @@ import org.apache.syncope.core.provisioning.api.pushpull.LiveSyncDeltaMapper; import org.apache.syncope.core.provisioning.api.pushpull.ProvisioningProfile; import org.apache.syncope.core.provisioning.api.pushpull.RealmPullResultHandler; -import org.apache.syncope.core.provisioning.api.pushpull.SyncopePullExecutor; import org.apache.syncope.core.provisioning.api.pushpull.SyncopePullResultHandler; import org.apache.syncope.core.provisioning.java.job.TaskJob; import org.apache.syncope.core.provisioning.java.utils.ConnObjectUtils; @@ -67,9 +66,7 @@ import org.springframework.beans.factory.annotation.Autowired; import org.springframework.transaction.annotation.Transactional; -public class LiveSyncJobDelegate - extends AbstractPullExecutor - implements SyncopePullExecutor, StoppableJobDelegate { +public class LiveSyncJobDelegate extends AbstractPullExecutor implements StoppableJobDelegate { protected record LiveSyncInfo( Provision provision, diff --git a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/PullJobDelegate.java b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/PullJobDelegate.java index 19fc2ba2252..ec8f48a8f9b 100644 --- a/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/PullJobDelegate.java +++ b/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/pushpull/PullJobDelegate.java @@ -39,7 +39,6 @@ import org.apache.syncope.core.provisioning.api.pushpull.ProvisioningProfile; import org.apache.syncope.core.provisioning.api.pushpull.RealmPullResultHandler; import org.apache.syncope.core.provisioning.api.pushpull.ReconFilterBuilder; -import org.apache.syncope.core.provisioning.api.pushpull.SyncopePullExecutor; import org.apache.syncope.core.provisioning.api.pushpull.SyncopePullResultHandler; import org.apache.syncope.core.provisioning.java.utils.ConnObjectUtils; import org.apache.syncope.core.provisioning.java.utils.MappingUtils; @@ -48,9 +47,7 @@ import org.identityconnectors.framework.common.objects.ObjectClass; import org.identityconnectors.framework.common.objects.OperationOptions; -public class PullJobDelegate - extends AbstractPullExecutor - implements SyncopePullExecutor, StoppableJobDelegate { +public class PullJobDelegate extends AbstractPullExecutor implements StoppableJobDelegate { protected Optional perContextReconFilterBuilder = Optional.empty(); diff --git a/core/provisioning-java/src/test/java/org/apache/syncope/core/provisioning/java/DefaultMappingManagerTest.java b/core/provisioning-java/src/test/java/org/apache/syncope/core/provisioning/java/DefaultMappingManagerTest.java index 002a0f38583..e9f99bce553 100644 --- a/core/provisioning-java/src/test/java/org/apache/syncope/core/provisioning/java/DefaultMappingManagerTest.java +++ b/core/provisioning-java/src/test/java/org/apache/syncope/core/provisioning/java/DefaultMappingManagerTest.java @@ -27,11 +27,7 @@ import org.apache.syncope.common.lib.to.Provision; import org.apache.syncope.common.lib.types.AnyTypeKind; import org.apache.syncope.common.lib.types.CipherAlgorithm; -import org.apache.syncope.core.persistence.api.attrvalue.PlainAttrValidationManager; -import org.apache.syncope.core.persistence.api.dao.AnyTypeClassDAO; import org.apache.syncope.core.persistence.api.dao.ExternalResourceDAO; -import org.apache.syncope.core.persistence.api.dao.GroupDAO; -import org.apache.syncope.core.persistence.api.dao.RealmSearchDAO; import org.apache.syncope.core.persistence.api.dao.UserDAO; import org.apache.syncope.core.persistence.api.entity.EntityFactory; import org.apache.syncope.core.persistence.api.entity.ExternalResource; @@ -59,21 +55,9 @@ public class DefaultMappingManagerTest extends AbstractTest { @Autowired private ExternalResourceDAO resourceDAO; - @Autowired - private RealmSearchDAO realmSearchDAO; - - @Autowired - private GroupDAO groupDAO; - - @Autowired - private AnyTypeClassDAO anyTypeClassDAO; - @Autowired private EntityFactory entityFactory; - @Autowired - private PlainAttrValidationManager validator; - @Test public void prepareAttrsForUser() { User bellini = userDAO.findByUsername("bellini").orElseThrow(); diff --git a/core/spring/src/main/java/org/apache/syncope/core/spring/implementation/ImplementationManager.java b/core/spring/src/main/java/org/apache/syncope/core/spring/implementation/ImplementationManager.java index 2f9c890be21..646bae0ad98 100644 --- a/core/spring/src/main/java/org/apache/syncope/core/spring/implementation/ImplementationManager.java +++ b/core/spring/src/main/java/org/apache/syncope/core/spring/implementation/ImplementationManager.java @@ -215,7 +215,7 @@ public static Optional buildPushCorrelationRule( } } - @SuppressWarnings({ "unchecked", "rawtypes" }) + @SuppressWarnings("unchecked") private static Class findCommandArgsClass(final Type type) { if (type.getTypeName().startsWith( ImplementationTypesHolder.getInstance().getValues().get(IdRepoImplementationType.COMMAND) + "<")) { @@ -321,7 +321,6 @@ public static T build(final String domain, final Implementation impl) throws return createBean((Class) getClass(domain, impl).getLeft(), impl.getEngine()); } - @SuppressWarnings("unchecked") private static T build( final Class clazz, final boolean classCached, diff --git a/core/spring/src/main/java/org/apache/syncope/core/spring/task/VirtualThreadPoolTaskExecutor.java b/core/spring/src/main/java/org/apache/syncope/core/spring/task/VirtualThreadPoolTaskExecutor.java index c8a73aa4221..da57a9d1855 100644 --- a/core/spring/src/main/java/org/apache/syncope/core/spring/task/VirtualThreadPoolTaskExecutor.java +++ b/core/spring/src/main/java/org/apache/syncope/core/spring/task/VirtualThreadPoolTaskExecutor.java @@ -27,15 +27,12 @@ import java.util.concurrent.RejectedExecutionHandler; import java.util.concurrent.ThreadFactory; import java.util.concurrent.TimeUnit; -import org.springframework.core.task.AsyncTaskExecutor; import org.springframework.core.task.SimpleAsyncTaskExecutor; import org.springframework.core.task.TaskDecorator; import org.springframework.scheduling.SchedulingTaskExecutor; import org.springframework.scheduling.concurrent.ExecutorConfigurationSupport; -public class VirtualThreadPoolTaskExecutor - extends ExecutorConfigurationSupport - implements AsyncTaskExecutor, SchedulingTaskExecutor { +public class VirtualThreadPoolTaskExecutor extends ExecutorConfigurationSupport implements SchedulingTaskExecutor { private static final long serialVersionUID = 4747270938984213408L; diff --git a/core/starter/src/main/java/org/apache/syncope/core/starter/actuate/JobEndpoint.java b/core/starter/src/main/java/org/apache/syncope/core/starter/actuate/JobEndpoint.java index dd67aad896b..5d93455753e 100644 --- a/core/starter/src/main/java/org/apache/syncope/core/starter/actuate/JobEndpoint.java +++ b/core/starter/src/main/java/org/apache/syncope/core/starter/actuate/JobEndpoint.java @@ -79,7 +79,7 @@ public Map status() { status.keySet().forEach(domain -> { Set jobStatuses = new HashSet<>( AuthContextUtils.callAsAdmin(domain, () -> jobStatusDAO.findAll())); - jobStatuses.removeIf(syncopeTaskScheduler.getJobNames(domain)::contains); + jobStatuses.removeIf(s -> syncopeTaskScheduler.getJobNames(domain).contains(s.getKey())); if (!jobStatuses.isEmpty()) { @SuppressWarnings("unchecked") diff --git a/ext/elasticsearch/persistence/src/main/java/org/apache/syncope/core/persistence/elasticsearch/dao/ElasticsearchRealmSearchDAO.java b/ext/elasticsearch/persistence/src/main/java/org/apache/syncope/core/persistence/elasticsearch/dao/ElasticsearchRealmSearchDAO.java index 6b1b411121f..8d24aa5e683 100644 --- a/ext/elasticsearch/persistence/src/main/java/org/apache/syncope/core/persistence/elasticsearch/dao/ElasticsearchRealmSearchDAO.java +++ b/ext/elasticsearch/persistence/src/main/java/org/apache/syncope/core/persistence/elasticsearch/dao/ElasticsearchRealmSearchDAO.java @@ -50,7 +50,6 @@ import org.apache.syncope.core.persistence.api.dao.MalformedPathException; import org.apache.syncope.core.persistence.api.dao.PlainSchemaDAO; import org.apache.syncope.core.persistence.api.dao.RealmDAO; -import org.apache.syncope.core.persistence.api.dao.RealmSearchDAO; import org.apache.syncope.core.persistence.api.dao.UserDAO; import org.apache.syncope.core.persistence.api.dao.search.AnyCond; import org.apache.syncope.core.persistence.api.dao.search.AttrCond; @@ -70,7 +69,7 @@ import org.springframework.data.domain.Sort; import org.springframework.transaction.annotation.Transactional; -public class ElasticsearchRealmSearchDAO extends AbstractRealmSearchDAO implements RealmSearchDAO { +public class ElasticsearchRealmSearchDAO extends AbstractRealmSearchDAO { protected static final Set ID_PROPS = Set.of("key", "id", "_id"); diff --git a/ext/flowable/client-enduser/src/main/java/org/apache/syncope/client/enduser/rest/BpmnProcessRestClient.java b/ext/flowable/client-enduser/src/main/java/org/apache/syncope/client/enduser/rest/BpmnProcessRestClient.java index 82c886955da..3214f380c32 100644 --- a/ext/flowable/client-enduser/src/main/java/org/apache/syncope/client/enduser/rest/BpmnProcessRestClient.java +++ b/ext/flowable/client-enduser/src/main/java/org/apache/syncope/client/enduser/rest/BpmnProcessRestClient.java @@ -18,10 +18,7 @@ */ package org.apache.syncope.client.enduser.rest; -import jakarta.ws.rs.core.MediaType; import java.util.List; -import org.apache.cxf.jaxrs.client.Client; -import org.apache.cxf.jaxrs.client.WebClient; import org.apache.syncope.common.lib.to.BpmnProcess; import org.apache.syncope.common.rest.api.service.BpmnProcessService; @@ -29,13 +26,6 @@ public class BpmnProcessRestClient extends BaseRestClient { private static final long serialVersionUID = 5049285686167071017L; - private BpmnProcessService getService(final MediaType mediaType) { - BpmnProcessService service = getService(BpmnProcessService.class); - Client client = WebClient.client(service); - client.type(mediaType); - return service; - } - public List getDefinitions() { return getService(BpmnProcessService.class).list(); } diff --git a/ext/opensearch/persistence/src/main/java/org/apache/syncope/core/persistence/opensearch/dao/OpenSearchRealmSearchDAO.java b/ext/opensearch/persistence/src/main/java/org/apache/syncope/core/persistence/opensearch/dao/OpenSearchRealmSearchDAO.java index b510c034cd5..44d7ce48f60 100644 --- a/ext/opensearch/persistence/src/main/java/org/apache/syncope/core/persistence/opensearch/dao/OpenSearchRealmSearchDAO.java +++ b/ext/opensearch/persistence/src/main/java/org/apache/syncope/core/persistence/opensearch/dao/OpenSearchRealmSearchDAO.java @@ -32,7 +32,6 @@ import org.apache.syncope.core.persistence.api.dao.MalformedPathException; import org.apache.syncope.core.persistence.api.dao.PlainSchemaDAO; import org.apache.syncope.core.persistence.api.dao.RealmDAO; -import org.apache.syncope.core.persistence.api.dao.RealmSearchDAO; import org.apache.syncope.core.persistence.api.dao.UserDAO; import org.apache.syncope.core.persistence.api.dao.search.AnyCond; import org.apache.syncope.core.persistence.api.dao.search.AttrCond; @@ -69,7 +68,7 @@ import org.springframework.data.domain.Sort; import org.springframework.transaction.annotation.Transactional; -public class OpenSearchRealmSearchDAO extends AbstractRealmSearchDAO implements RealmSearchDAO { +public class OpenSearchRealmSearchDAO extends AbstractRealmSearchDAO { protected static final Set ID_PROPS = Set.of("key", "id", "_id"); protected static final List FULLPATH_SORT_OPTIONS = List.of( diff --git a/fit/core-reference/src/test/java/org/apache/syncope/fit/core/AbstractTaskITCase.java b/fit/core-reference/src/test/java/org/apache/syncope/fit/core/AbstractTaskITCase.java index bd6b83e179d..3c849b127dc 100644 --- a/fit/core-reference/src/test/java/org/apache/syncope/fit/core/AbstractTaskITCase.java +++ b/fit/core-reference/src/test/java/org/apache/syncope/fit/core/AbstractTaskITCase.java @@ -120,38 +120,39 @@ protected void execProvisioningTasks( final int maxWaitSeconds, final boolean dryRun) throws Exception { - SimpleAsyncTaskExecutor executor = new SimpleAsyncTaskExecutor(); - executor.setVirtualThreads(true); - List> futures = new ArrayList<>(); + try (SimpleAsyncTaskExecutor executor = new SimpleAsyncTaskExecutor()) { + executor.setVirtualThreads(true); + List> futures = new ArrayList<>(); + + taskKeys.forEach(taskKey -> { + futures.add(executor.submit(() -> { + try { + return execSchedTask(taskService, type, taskKey, maxWaitSeconds, dryRun); + } catch (Exception e) { + ExecTO failure = new ExecTO(); + failure.setRefKey(taskKey); + failure.setStatus(ExecStatus.FAILURE.name()); + failure.setMessage(e.getMessage()); + return failure; + } + })); + + // avoid flooding the test server + try { + Thread.sleep(2000); + } catch (InterruptedException e) { + // ignore + } + }); - taskKeys.forEach(taskKey -> { - futures.add(executor.submit(() -> { + futures.forEach(future -> { try { - return execSchedTask(taskService, type, taskKey, maxWaitSeconds, dryRun); + future.get(maxWaitSeconds, TimeUnit.SECONDS); } catch (Exception e) { - ExecTO failure = new ExecTO(); - failure.setRefKey(taskKey); - failure.setStatus(ExecStatus.FAILURE.name()); - failure.setMessage(e.getMessage()); - return failure; + LOG.error("While getting futures", e); } - })); - - // avoid flooding the test server - try { - Thread.sleep(2000); - } catch (InterruptedException e) { - // ignore - } - }); - - futures.forEach(future -> { - try { - future.get(maxWaitSeconds, TimeUnit.SECONDS); - } catch (Exception e) { - LOG.error("While getting futures", e); - } - }); + }); + } } protected NotificationTaskTO findNotificationTask(final String notification, final int maxWaitSeconds) { diff --git a/fit/core-reference/src/test/java/org/apache/syncope/fit/core/PullTaskITCase.java b/fit/core-reference/src/test/java/org/apache/syncope/fit/core/PullTaskITCase.java index 79a234389ba..8a8688d49b0 100644 --- a/fit/core-reference/src/test/java/org/apache/syncope/fit/core/PullTaskITCase.java +++ b/fit/core-reference/src/test/java/org/apache/syncope/fit/core/PullTaskITCase.java @@ -964,33 +964,34 @@ public void concurrentPull() throws InterruptedException { // 0. first cleanup then create 20 users on LDAP ldapCleanup(); - SimpleAsyncTaskExecutor tp = new SimpleAsyncTaskExecutor(); - tp.setVirtualThreads(true); - List> futures = new ArrayList<>(); - - for (int i = 0; i < 20; i++) { - String idx = StringUtils.leftPad(String.valueOf(i), 2, "0"); - futures.add(tp.submit(() -> createLdapRemoteObject( - "uid=pullFromLDAP_" + idx + ",ou=People,o=isp", - Map.of( - "objectClass", "inetOrgPerson", - "uid", "pullFromLDAP_" + idx, - "cn", "pullFromLDAP_" + idx, - "mail", "pullFromLDAP_" + idx + "@syncope.apache.org", - "description", "Active", - "givenName", "pullFromLDAP_" + idx, - "sn", "Surname", - "registeredAddress", "5BAA61E4C9B93F3F0682250B6CF8331B7EE68FD8", - "title", "odd", - "userpassword", "password")))); - } - futures.forEach(future -> { - try { - future.get(MAX_WAIT_SECONDS, TimeUnit.SECONDS); - } catch (Exception e) { - LOG.error("While getting futures", e); + try (SimpleAsyncTaskExecutor tp = new SimpleAsyncTaskExecutor()) { + tp.setVirtualThreads(true); + List> futures = new ArrayList<>(); + + for (int i = 0; i < 20; i++) { + String idx = StringUtils.leftPad(String.valueOf(i), 2, "0"); + futures.add(tp.submit(() -> createLdapRemoteObject( + "uid=pullFromLDAP_" + idx + ",ou=People,o=isp", + Map.of( + "objectClass", "inetOrgPerson", + "uid", "pullFromLDAP_" + idx, + "cn", "pullFromLDAP_" + idx, + "mail", "pullFromLDAP_" + idx + "@syncope.apache.org", + "description", "Active", + "givenName", "pullFromLDAP_" + idx, + "sn", "Surname", + "registeredAddress", "5BAA61E4C9B93F3F0682250B6CF8331B7EE68FD8", + "title", "odd", + "userpassword", "password")))); } - }); + futures.forEach(future -> { + try { + future.get(MAX_WAIT_SECONDS, TimeUnit.SECONDS); + } catch (Exception e) { + LOG.error("While getting futures", e); + } + }); + } // 1. create new concurrent pull task PullTaskTO pullTask = TASK_SERVICE.read(TaskType.PULL, LDAP_PULL_TASK, false); diff --git a/fit/core-reference/src/test/java/org/apache/syncope/fit/core/SyncReplITCase.java b/fit/core-reference/src/test/java/org/apache/syncope/fit/core/SyncReplITCase.java index c2e2b750f96..3310410b8e2 100644 --- a/fit/core-reference/src/test/java/org/apache/syncope/fit/core/SyncReplITCase.java +++ b/fit/core-reference/src/test/java/org/apache/syncope/fit/core/SyncReplITCase.java @@ -366,7 +366,7 @@ void liveSync() throws LDAPException { atMost(MAX_WAIT_SECONDS, TimeUnit.SECONDS).pollInterval(1, TimeUnit.SECONDS).until(() -> { try { - return GROUP_SERVICE.search( + return GROUP_SERVICE.search( new AnyQuery.Builder().fiql("name==readers").build()).getResult(); } catch (SyncopeClientException e) { return List.of(); @@ -378,7 +378,7 @@ void liveSync() throws LDAPException { atMost(MAX_WAIT_SECONDS, TimeUnit.SECONDS).pollInterval(1, TimeUnit.SECONDS).until(() -> { try { - return USER_SERVICE.search( + return USER_SERVICE.search( new AnyQuery.Builder().fiql("username==user0*").build()).getResult(); } catch (SyncopeClientException e) { return List.of(); diff --git a/fit/core-reference/src/test/java/org/apache/syncope/fit/core/UserITCase.java b/fit/core-reference/src/test/java/org/apache/syncope/fit/core/UserITCase.java index 7cdd7394c87..d6f1bdb3dfc 100644 --- a/fit/core-reference/src/test/java/org/apache/syncope/fit/core/UserITCase.java +++ b/fit/core-reference/src/test/java/org/apache/syncope/fit/core/UserITCase.java @@ -641,7 +641,6 @@ public void updatePasswordOnly() { assertTrue(beforeTasks < afterTasks); } - @SuppressWarnings("unchecked") @Test public void verifyTaskRegistration() { // get task list diff --git a/sra/src/main/java/org/apache/syncope/sra/RouteProvider.java b/sra/src/main/java/org/apache/syncope/sra/RouteProvider.java index 8918ba547b0..29599c237e1 100644 --- a/sra/src/main/java/org/apache/syncope/sra/RouteProvider.java +++ b/sra/src/main/java/org/apache/syncope/sra/RouteProvider.java @@ -127,7 +127,6 @@ public RouteProvider( this.useGZIPCompression = useGZIPCompression; } - @SuppressWarnings("unchecked") protected GatewayFilter toFilter(final SRARouteTO route, final SRARouteFilter gwfilter) throws ClassNotFoundException, NumberFormatException { From b7a0725b202b544e34fa110bd9e3cac31a5ef743 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francesco=20Chicchiricc=C3=B2?= Date: Mon, 12 Oct 2026 08:44:21 +0200 Subject: [PATCH 2/3] Restore a few missing set methods --- .../policies/ProvisioningPolicyModalPanel.java | 12 ++++++++++++ pom.xml | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/client/idm/console/src/main/java/org/apache/syncope/client/console/policies/ProvisioningPolicyModalPanel.java b/client/idm/console/src/main/java/org/apache/syncope/client/console/policies/ProvisioningPolicyModalPanel.java index e47feb9b414..1d8b5693255 100644 --- a/client/idm/console/src/main/java/org/apache/syncope/client/console/policies/ProvisioningPolicyModalPanel.java +++ b/client/idm/console/src/main/java/org/apache/syncope/client/console/policies/ProvisioningPolicyModalPanel.java @@ -370,10 +370,18 @@ public String getAnyType() { return anyType; } + public void setAnyType(final String anyType) { + this.anyType = anyType; + } + public String getImplKey() { return Optional.ofNullable(impl).map(ImplementationTO::getKey).orElse(null); } + public void setImplKey(final String key) { + setImpl(implementations.getObject().get(key)); + } + public final void setImpl(final ImplementationTO impl) { this.impl = impl; if (impl != null) { @@ -397,6 +405,10 @@ public ImplementationTO getImpl() { return impl; } + public void setDefaultRuleConf(final DefaultPushCorrelationRuleConf defaultRuleConf) { + this.defaultRuleConf = defaultRuleConf; + } + public AbstractCorrelationRuleConf getDefaultRuleConf() { return defaultRuleConf; } diff --git a/pom.xml b/pom.xml index c781ef15134..744183d9ac1 100644 --- a/pom.xml +++ b/pom.xml @@ -462,7 +462,7 @@ under the License. 3.21.0 3.7.0 1.15.0 - 1.22.1 + 1.23.0 6.3.3 5.2.2 From 73ff962a483da0de1b1619959e26b25b62b43893 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Francesco=20Chicchiricc=C3=B2?= Date: Mon, 12 Oct 2026 10:43:49 +0200 Subject: [PATCH 3/3] Revert --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index 744183d9ac1..c781ef15134 100644 --- a/pom.xml +++ b/pom.xml @@ -462,7 +462,7 @@ under the License. 3.21.0 3.7.0 1.15.0 - 1.23.0 + 1.22.1 6.3.3 5.2.2