Repository navigation
Checks on artifact licensing #8808
Replies: 5 comments
|
I agree that each fix should explain why the existing checks missed it. The linked issues suggest a coverage gap: headers can pass while bundled datasets, images, or vendored tools still lack licensing information. One useful approach from AsterixDB is reusable license templates that I believe also records bundled image paths and attribution. Could we use a shared provenance record for Texera’s datasets, images, and copied code to generate the licensing sections for each distribution, then check those records against the packaged contents? |
|
@sshiv012 @parshimers Do you suggest any action for this topic? |
|
The icons are hard. I think there should be 2 improvements:
|
|
I agree with Ian's two proposals (a specific license for every added image, and much tighter license-check allow/ignore paths). I'd add a third guard, because the miss in #8799 wasn't really a header problem. Why header checks can't catch this class of issue Header checks such as RAT answer "does this source file carry an ASF header?". They don't answer "is everything shipped in this artifact accounted for in LICENSE/NOTICE?". #8799 was a bundled dataset missing from the docker-compose LICENSE, so it would have passed a header scan. Images are the same: RAT just treats them as binary files (see the comments in Tomcat's rat-excludes), so it can't tell us whether we have the right to ship them. The ASF requirement is that LICENSE and NOTICE exactly represent the contents of each distribution, including binary and convenience bundles, so the check needs to run against the packaged artifacts too. How other ASF projects approach it
Concrete suggestion
I haven't looked closely at how the current license workflows treat non-code files, so apologies if some of this is already covered. Happy to help prototype step 2 if people think it's useful. |
Uh oh!
There was an error while loading. Please reload this page.
Hi folks,
We already have some checks on artifact licensing, via actions and other things. However, these don't seem to be enough. In 1.2.0 there were some artifacts that slipped though. In 1.2.1, which should only be a bugfix release, we still have regressions:
#8799
#8800
#8801
#8802
For each of these, just fixing the specific file(s) is not enough. It needs to be understood why it fell through the existing checks, and what can be done to avoid making the same or a similar mistake in the future. We have very helpful folks like PJ in the Incubator to help us at this point, but we will not have them for long. It needs to be shown that we have our bases covered in this area and can be trusted to catch these issues ourselves.
Thoughts?
All reactions