From 4f063997bbe7eb8efdeab1441f40b0def8ae1684 Mon Sep 17 00:00:00 2001 From: Vishesh Upadhyay Date: Sun, 25 Oct 2026 03:24:11 +0530 Subject: [PATCH] fix: copy advanced commerce item lists --- .../apple/itunes/storekit/model/HelperValidationUtils.java | 5 +++-- .../itunes/storekit/model/AdvancedCommerceModelsTest.java | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/apple/itunes/storekit/model/HelperValidationUtils.java b/src/main/java/com/apple/itunes/storekit/model/HelperValidationUtils.java index eae413f5..39415a9c 100644 --- a/src/main/java/com/apple/itunes/storekit/model/HelperValidationUtils.java +++ b/src/main/java/com/apple/itunes/storekit/model/HelperValidationUtils.java @@ -2,6 +2,7 @@ package com.apple.itunes.storekit.model; +import java.util.ArrayList; import java.util.List; import java.util.Objects; @@ -87,7 +88,7 @@ public static List validateItems(List list) { } } - return list; + return new ArrayList<>(list); } private static String validateStringWithMaxLength(String value, int maxLength, String fieldName) { @@ -97,4 +98,4 @@ private static String validateStringWithMaxLength(String value, int maxLength, S } return value; } -} \ No newline at end of file +} diff --git a/src/test/java/com/apple/itunes/storekit/model/AdvancedCommerceModelsTest.java b/src/test/java/com/apple/itunes/storekit/model/AdvancedCommerceModelsTest.java index 5d986d05..cf12b34d 100644 --- a/src/test/java/com/apple/itunes/storekit/model/AdvancedCommerceModelsTest.java +++ b/src/test/java/com/apple/itunes/storekit/model/AdvancedCommerceModelsTest.java @@ -1163,8 +1163,9 @@ public void testAdvancedCommerceSubscriptionReactivateInAppRequestItemsValidatio @Test public void testAdvancedCommerceRequestAddItemAppendsToList() { - AdvancedCommerceSubscriptionPriceChangeRequest priceChangeRequest = new AdvancedCommerceSubscriptionPriceChangeRequest(createRequestInfo(), new ArrayList<>(List.of(new AdvancedCommerceSubscriptionPriceChangeItem("sku", 1000L)))) + AdvancedCommerceSubscriptionPriceChangeRequest priceChangeRequest = new AdvancedCommerceSubscriptionPriceChangeRequest(createRequestInfo(), List.of(new AdvancedCommerceSubscriptionPriceChangeItem("sku", 1000L))) .addItem(new AdvancedCommerceSubscriptionPriceChangeItem("sku2", 2000L)); + Assertions.assertEquals(List.of(new AdvancedCommerceSubscriptionPriceChangeItem("sku", 1000L), new AdvancedCommerceSubscriptionPriceChangeItem("sku2", 2000L)), priceChangeRequest.getItems()); AdvancedCommerceSubscriptionCreateRequest createRequest = new AdvancedCommerceSubscriptionCreateRequest(createRequestInfo(), "USD", new AdvancedCommerceDescriptors("description", "display name"), new ArrayList<>(List.of(new AdvancedCommerceSubscriptionCreateItem("sku", "description", "display name", 1000L))),