From a0f6e4a5698d96aea7f6e13d8ebe4f315ae9f5f9 Mon Sep 17 00:00:00 2001 From: Cursor Agent Date: Sat, 7 Nov 2026 21:41:42 +0000 Subject: [PATCH] test(radio): Lock single-mode load abort against false PLAY_ERROR Prove a playing Single stream replacement ignores a queued media abort so AbortError "Load aborted" is not treated as a current-request failure. Comment the existing media-element regression for the same Sentry shape. No production code change: main already scopes cancellation to the attachment AbortController (#457). Fixes RADIO-23 Changelog: skip Co-authored-by: Francesco Castrovilli --- .../lib/audio/manager/audio-manager.test.ts | 45 +++++++++++++++++++ .../media-element-playback-source.test.ts | 2 + 2 files changed, 47 insertions(+) diff --git a/apps/radio/src/lib/audio/manager/audio-manager.test.ts b/apps/radio/src/lib/audio/manager/audio-manager.test.ts index 1efa4f996..6d1c5e401 100644 --- a/apps/radio/src/lib/audio/manager/audio-manager.test.ts +++ b/apps/radio/src/lib/audio/manager/audio-manager.test.ts @@ -670,6 +670,51 @@ describe("AudioManager", () => { } ); + // RADIO-23: single-mode external stream replacement. load() queues an abort + // for the previous resource; treating that media event as failure reported + // AbortError "Load aborted" as PLAY_ERROR while the replacement was current. + test("a playing single-mode stream replacement ignores a queued media abort", async () => { + const harness = createMediaPlaybackHarness(); + try { + const { manager, browser } = harness; + const soundId = manager.createSound(station, "single:station", "native"); + const states: AudioState[] = []; + manager.subscribe(soundId, (state) => states.push(state)); + const starting = manager.playSound(soundId); + await flushMicrotasks(); + const audio = browser.audio(); + audio.emit("canplay"); + await starting; + audio.emit("playing"); + expect(audio.paused).toBe(false); + + const emptyReadyState = HTMLMediaElement.HAVE_NOTHING; + audio.load = () => { + audio.readyState = emptyReadyState; + }; + const nextUrl = "https://radio.example/replacement.mp3"; + const refreshing = manager + .refreshStreamUrl(soundId, nextUrl) + .catch((error: unknown) => error); + await flushMicrotasks(); + const stateCount = states.length; + audio.emit("abort"); + audio.emit("canplay"); + expect(await refreshing).toBeUndefined(); + + expect(audio.src).toBe(nextUrl); + expect(audio.paused).toBe(false); + expect(states.slice(stateCount).some((state) => state.error)).toBe(false); + expect(states.at(-1)).toMatchObject({ + error: null, + isLoading: false, + isPlaying: true, + }); + } finally { + harness.restore(); + } + }); + test.each(["audio-graph", "native"] as const)( "a recreated %s source seeks before its first playback", async (mode) => { diff --git a/apps/radio/src/lib/audio/playback/media-element-playback-source.test.ts b/apps/radio/src/lib/audio/playback/media-element-playback-source.test.ts index 2c20a4642..206db1348 100644 --- a/apps/radio/src/lib/audio/playback/media-element-playback-source.test.ts +++ b/apps/radio/src/lib/audio/playback/media-element-playback-source.test.ts @@ -127,6 +127,8 @@ afterEach(() => { }); describe("MediaElementPlaybackSource native playback", () => { + // RADIO-23: a browser abort for the previous resource must not reject the + // current load as AbortError "Load aborted" (reported upstream as PLAY_ERROR). test("a queued abort from the previous resource does not fail its replacement", async () => { const browser = installBrowser(); const onError = mock(() => undefined);