From 67198d0962ada655e8328cd9a6360219647ee842 Mon Sep 17 00:00:00 2001 From: meawong Date: Thu, 8 Oct 2026 11:59:53 -0700 Subject: [PATCH] 35155 - Fix corrections for regular name typos --- .../filings/validations/correction.py | 5 ++-- .../filings/validations/test_correction_ia.py | 24 +++++++++++++++++++ 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/legal-api/src/legal_api/services/filings/validations/correction.py b/legal-api/src/legal_api/services/filings/validations/correction.py index 5e61b52e9d..9edfb5214e 100644 --- a/legal-api/src/legal_api/services/filings/validations/correction.py +++ b/legal-api/src/legal_api/services/filings/validations/correction.py @@ -277,10 +277,9 @@ def _validate_name_request(business, filing_dict, new_legal_type, filing_type): msg = [] if filing_dict.get("filing", {}).get("correction", {}).get("nameRequest", {}).get("nrNumber", None): msg.extend(validate_name_request(filing_dict, new_legal_type or business.legal_type, filing_type)) - else: + elif new_legal_type: valid_names = [business.legal_name] - if (new_legal_type and - (new_numbered_name := Business.generate_numbered_legal_name(new_legal_type, business.identifier))): + if new_numbered_name := Business.generate_numbered_legal_name(new_legal_type, business.identifier): # if existing legal_name is a numbered name and if type has changed # then the legal name get updated according to the new legal type valid_names.append(new_numbered_name) diff --git a/legal-api/tests/unit/services/filings/validations/test_correction_ia.py b/legal-api/tests/unit/services/filings/validations/test_correction_ia.py index 4ddeacd599..f4b9fe0d92 100644 --- a/legal-api/tests/unit/services/filings/validations/test_correction_ia.py +++ b/legal-api/tests/unit/services/filings/validations/test_correction_ia.py @@ -109,6 +109,30 @@ def test_valid_ia_correction(session, app, jwt): assert None is err +def test_valid_ia_correction_allows_legal_name_typo_correction_without_nr(session, app, jwt): + """Test that a valid IA without NR can fix a legal name typo.""" + identifier = 'BC1234567' + business = factory_business(identifier, entity_type='BC') + business.legal_name = 'Test Compnay Inc.' + business.save() + + corrected_filing = factory_completed_filing(business, INCORPORATION_APPLICATION) + + filing = copy.deepcopy(CORRECTION) + filing['filing']['header']['identifier'] = identifier + filing['filing']['correction']['correctedFilingId'] = corrected_filing.id + filing['filing']['correction']['nameRequest'] = { + 'nrNumber': '', + 'legalName': 'Test Company Inc.', + 'legalType': 'BC' + } + + with jwt_request_context(app, jwt, [STAFF_ROLE]): + err = validate(business, filing) + + assert err is None + + @pytest.mark.parametrize('new_name, legal_type, nr_legal_type, nr_type, err_msg', [ ('legal_name-BC1234568', 'CP', 'CP', 'BECV', None), ('legal_name-BC1234567_Changed', 'BEN', 'CP', 'BECV',