Skip to content

DEFECT_REGISTER.md

Latest commit

 

History

History
74 lines (57 loc) · 8.75 KB

DEFECT_REGISTER.md

File metadata and controls

74 lines (57 loc) · 8.75 KB
Raw

Defect Register — InvoiceFlow

Date: 2026-11-13 · Starting commit e286e93 · Phase 1–4 feature set, pre-release hardening pass.

Resolved in this pass

I-007 — Clicks inside every dialog were silently ignored (P1, FIXED 2026-11-13)

  • Evidence: index.html places <dialog id="modal"> as a sibling of <div id="app">, but the delegated click handler was bound to #app. Any data-* button inside a dialog never reached it — the template line "Add line" / "Remove line" buttons did nothing, and the failure was invisible (no JS error). The pre-existing "remove line works" check passed only because it asserted a no-op.
  • Fix: delegated handler moved to document, the single ancestor of both the page and its dialogs. The workspace test's mock DOM was updated to model document.addEventListener, which the real DOM has always provided.
  • Verified: template add/remove line now change the row count 1→2→1; full UI audit 251 checks / 0 failures.

I-008 — Opening a second dialog wiped the first (P1, FIXED 2026-11-13)

  • Evidence: the reminder dialog opened empty (dialog.innerHTML.length === 0) after submitting the previous dialog. <dialog>.close() fires its close event asynchronously; clearing modal.innerHTML inside that handler ran after textDialog() had already populated the replacement dialog, erasing it.
  • Fix: clear modal.innerHTML at the start of modalForm() instead of in the close handler. Each new dialog now begins from a clean slate regardless of when the old close event lands.
  • Verified: reminder → message dialog renders the full text in a real browser.

I-009 — Templates were unusable: createTemplate is not defined (P1, FIXED 2026-11-13)

  • Evidence: browser console on saving a template. The template functions were added to core.js but never added to the app.js import list.
  • Fix: import completed; template create/use/edit/delete verified end-to-end (18/18 browser checks).

I-010 — Template "Use" inflated every price by 100× (P1, FIXED 2026-11-13)

  • Evidence: using a template opened the editor with price = 350000.00 for a R3 500 line. The editor draft stores human units and multiplies by 100 on load; the template's stored cents were written straight into it.
  • Fix: convert with decimal() when writing the draft. Verified the editor shows 3500.00 and the resulting invoice carries the correct amount.

I-011 — Old backups failed validation after branding fields were added (P2, FIXED 2026-11-13)

  • Evidence: parseBackup threw Invalid logo… on backups written before logo/accent existed. s.business.logo !== null is true for undefined, and the empty-business comparison used strict JSON.stringify equality.
  • Fix: normalise with s.business={...emptyState().business,...s.business} and use loose != null checks, so pre-branding backups validate and gain null defaults.

I-012 — Service-worker cache key not bumped for new assets (P2, FIXED 2026-11-13)

  • Evidence: a real browser kept serving the previous core.js from invoiceflow-v048, so fixes appeared not to work. sw.js precaches ./core.js and ./app.js under a name that only changed when someone remembered to change it.
  • Fix: cache key bumped to invoiceflow-v049; activate already deletes every other invoiceflow-* cache. Verified the browser then served the new modules.

I-004 — Second invoice creation crashed: i.lines is undefined (P1, FIXED 2026-11-13)

  • Evidence: real-browser reproduction. new-invoice ran route={page:'invoice',id:newId}; editLines=[]; clearDraft(); — clearDraft() executed after route was reassigned, so draftKey() (which reads the current route) deleted the draft keyed to the saved invoice id instead of the keyed-to-undefined draft being edited. The stale draft survived, was reloaded on the next "New invoice", and pricingFields() called breakdown() on it.
  • Fix: clearDraft() now runs before route is reassigned. Independently, the guard in pricingFields was tightened from i? to i?.lines? so an empty draft cannot reach breakdown().
  • Verified: second, third, fourth and fifth invoice creations all succeed with zero JS errors (tests/harness/stress-audit.mjs).

I-005 — Settings page threw ReferenceError: when is not defined after any encrypted backup (P1, FIXED 2026-11-13)

  • Evidence: control audit stack backupLabel@app.js:23:314 ← settingsPage ← renderPage ← render. backupLabel() declared const when inside a try block but referenced it in the return outside that block, so the function threw whenever state.lastBackupAt was set — i.e. after any encrypted backup. Reachable from new-invoice, which redirects to Settings when the business name is empty.
  • Fix: hoisted to let when='' before the try. Swept the whole codebase for the same try{const …} scoping pattern; this was the only offender.
  • Verified: #last-backup now renders Last backup: just now (13 Nov 2026) instead of throwing.

I-006 — Invoice document showed internal and redundant rows (P2, FIXED 2026-11-13)

  • Evidence: rendered document read Payments recorded R 0,00 and Credit notes R 0,00 on every unpaid invoice, printed Value excluding VAT / VAT 0% to non-VAT businesses, and carried the internal note "Draft only — not yet issued." inside the customer-facing document.
  • Fix: zero-value rows are now conditional; the VAT breakdown is suppressed for non-VAT businesses; the internal draft note was removed (the title already carries · DRAFT). Payment instructions now repeat the due date, matching standard invoice layout.
  • Verified by rendering the document and reading it back.

I-001 — Version drift (P2, FIXED 2026-11-13)

  • Evidence: package.json: 0.4.0 vs README/PRODUCT-DETAILS.md: 0.4.0 vs service-worker cache invoiceflow-v048-phase4-20261112. The cache key had been bumped for Phase 4 while the packaged version was not.
  • Fix: aligned to 0.4.8 across package.json, README.md, PRODUCT-DETAILS.md and the service-worker cache key (invoiceflow-v048). Verified package.json parses and npm run check passes.

I-002 — No .env.example (P2, FIXED)

  • Evidence: file absent at the 2026-11-06 register; .gitignore carried an exception for it that nothing satisfied.
  • Fix: .env.example is now committed and documents that the static app needs no variables, with reserved notes for future server-side features.

I-003 — vitest not installed / test harness fragility (P3, FIXED)

  • Evidence: npm run test:ui was not executable at the 2026-11-06 register.
  • Fix: vitest is a dev dependency and npm run test:ui runs 3/3 UI tests; npm test now runs 135 domain tests plus those 3.

V-001 — Cash chart overflowed its container at tablet width (P2, FIXED 2026-11-13)

  • Evidence: real-browser measurement at 768 px showed .cash-chart scrollWidth 236 px against a 205 px client width, with table/thead/tr elements extending past the viewport. Cause: .chart-group{flex:1} had no min-width:0 and .bar was fixed at 13px, so the six month-groups could not shrink below their content size.
  • Fix: min-width:0 on .chart-group; .bar changed to flex:1 1 0; max-width:13px; min-width:2px. Verified by a 229-check responsive sweep across 11 pages and 10 viewport widths with zero overflow.

V-002 — Visual verification was not repeatable (P3, FIXED 2026-11-13)

  • Evidence: the browser audit existed only in a temporary scratch directory that is pruned after 24 hours, so no one else could re-run the verification.
  • Fix: tests/harness/browser-harness.mjs and tests/harness/ui-audit.mjs added to the repository with npm run test:visual (live site) and npm run test:visual:local (serves dist/ itself). The harness covers the responsive sweep, dark mode, the editor draft guard, the expense-photo dialog, detail views, accessibility naming and offline readiness.

Accepted limitations (not defects)

  • Local IndexedDB only — no cloud sync/account/auto-backup; README warns to export per-workspace backups.
  • Offline/PWA limits: service worker needs HTTPS + first successful load; recurring drafts only generate while browser is open.
  • VAT numbers format-checked only (^4\d{9}$), not SARS-verified; no tax advice.
  • Android not Play-ready: unsigned if ANDROID_UPLOAD_KEYSTORE_* env unset; minifyEnabled false.
  • CIPC reminder estimates the annual return at the end of the calendar year; the exact anniversary must be confirmed on the CIPC website.
  • src/lib/validation.js was removed on 2026-11-13. It duplicated email validation already performed by checkParty in dist/core.js on every save, and its sanitizeInput was a naive angle-bracket strip that must never be used as an XSS defence. Production escaping is the esc() helper in dist/app.js. The vitest UI suite now tests the real validateState path instead.