From 91172f537676e67d368b5115c43905b01680d7ef Mon Sep 17 00:00:00 2001 From: Scott McCarty Date: Wed, 4 Nov 2026 20:10:16 -0500 Subject: [PATCH] fix: run codeql inside `sdlc ci` `[tool.sdlc.ci] skip = ["codeql"]` kept CodeQL out of the one tier anything enforces. Constitution XII says CI runs push's checks except Gourmand and Gatehouse; CodeQL is one of push's verdicts. With the skip in place the only thing that could block on a CodeQL finding was the pre-push hook -- a developer's machine, one `--no-verify` away -- while the required `sdlc ci` reported green. The comment justifying the skip said the CodeQL Action covered it. The CodeQL Action does run on pull requests here, but its check is advisory: no ruleset requires it, so a finding annotated the PR and merged anyway. Gate run locally with codeql in: `sdlc ci` exits 0. One of 24 repos; python-sdlc#19 then refuses this config so it cannot come back. RT#1552. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6 --- pyproject.toml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pyproject.toml b/pyproject.toml index 38226da..f86a35c 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -86,8 +86,3 @@ skip = ["semgrep"] [tool.sdlc.push.pytest] env = { GITLAB_TOKEN = "test_token_for_ci" } -[tool.sdlc.ci] -# The CodeQL Action job uploads to the Security tab and annotates new -# alerts on the pull request, so CI does not analyse a second time. -# The push tier still gates on it. -skip = ["codeql"]