From a09660658f238018760f04aef299ee736ab94ccd Mon Sep 17 00:00:00 2001 From: Scott McCarty Date: Wed, 4 Nov 2026 20:35:02 -0500 Subject: [PATCH] fix: run codeql inside `sdlc ci` `[tool.sdlc.ci] skip = ["codeql"]` kept CodeQL out of the one tier anything enforces. Constitution XII says CI runs push's checks except Gourmand and Gatehouse; CodeQL is one of push's verdicts. With the skip in place the only thing that could block on a CodeQL finding was the pre-push hook -- a developer's machine, one `--no-verify` away -- while the required `sdlc ci` reported green. The comment justifying the skip said the CodeQL Action covered it. The CodeQL Action does run on pull requests here, but its check is advisory: no ruleset requires it, so a finding annotated the PR and merged anyway. Gate run locally with codeql in: `sdlc ci` exits 0. One of 24 repos; python-sdlc#19 then refuses this config so it cannot come back. RT#1552. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6 --- .gitignore | 3 +++ pyproject.toml | 5 ----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index 34505f9..04ea0cc 100644 --- a/.gitignore +++ b/.gitignore @@ -57,3 +57,6 @@ Thumbs.db # MCP Registry auth tokens .mcpregistry_* + +# Per-machine Claude Code permissions and absolute paths. Never shared. +.claude/settings.local.json diff --git a/pyproject.toml b/pyproject.toml index 47d31b6..510fce3 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -110,8 +110,3 @@ skip = ["semgrep"] [tool.sdlc.push.pytest] env = { WORDPRESS_URL = "https://example.com", WORDPRESS_USERNAME = "test_user_for_ci", WORDPRESS_APP_PASSWORD = "test_password_for_ci" } -[tool.sdlc.ci] -# The CodeQL Action job uploads to the Security tab and annotates new -# alerts on the pull request, so CI does not analyse a second time. -# The push tier still gates on it. -skip = ["codeql"]