From c153d11d7ee7c1349a47bc6a3d3431dd88f13d56 Mon Sep 17 00:00:00 2001 From: Scott McCarty Date: Wed, 4 Nov 2026 16:38:38 -0500 Subject: [PATCH] fix: mint the CI token by client-id, not the deprecated app-id actions/create-github-app-token@v3 logs `Input 'app-id' has been deprecated with message: Use 'client-id' instead.` Nothing is broken yet, but the input goes away in the action's next major version, and then every workflow in the org that mints a token fails at the token step -- which a Dependabot bump to @v4 would deliver all at once. The client ID is public (`gh api apps/crunchtools-ci --jq .client_id`), so it is an org variable rather than a secret, and the `vars.X || secrets.X` fallback the App ID needed is gone with it. The private key is unchanged. RT#1554 Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01R7Y1jesjfgxHeqtKJCvay6 --- .github/workflows/container.yml | 2 +- .github/workflows/release.yml | 2 +- .github/workflows/update-tools.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/container.yml b/.github/workflows/container.yml index 81f0982..850bf99 100644 --- a/.github/workflows/container.yml +++ b/.github/workflows/container.yml @@ -208,7 +208,7 @@ jobs: id: ci-token uses: actions/create-github-app-token@v3 with: - app-id: ${{ vars.CRUNCHTOOLS_CI_APP_ID || secrets.CRUNCHTOOLS_CI_APP_ID }} + client-id: ${{ vars.CRUNCHTOOLS_CI_CLIENT_ID }} private-key: ${{ secrets.CRUNCHTOOLS_CI_APP_KEY }} owner: crunchtools diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 0c015bc..4cb4530 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -52,7 +52,7 @@ jobs: id: ci-token uses: actions/create-github-app-token@v3 with: - app-id: ${{ vars.CRUNCHTOOLS_CI_APP_ID || secrets.CRUNCHTOOLS_CI_APP_ID }} + client-id: ${{ vars.CRUNCHTOOLS_CI_CLIENT_ID }} private-key: ${{ secrets.CRUNCHTOOLS_CI_APP_KEY }} owner: crunchtools diff --git a/.github/workflows/update-tools.yml b/.github/workflows/update-tools.yml index aead4d1..f095cf9 100644 --- a/.github/workflows/update-tools.yml +++ b/.github/workflows/update-tools.yml @@ -39,7 +39,7 @@ jobs: id: ci-token uses: actions/create-github-app-token@v3 with: - app-id: ${{ vars.CRUNCHTOOLS_CI_APP_ID || secrets.CRUNCHTOOLS_CI_APP_ID }} + client-id: ${{ vars.CRUNCHTOOLS_CI_CLIENT_ID }} private-key: ${{ secrets.CRUNCHTOOLS_CI_APP_KEY }} owner: crunchtools