From 8992d4997e3b6d6a481d8241274252dbf915ffae Mon Sep 17 00:00:00 2001 From: Scott McCarty Date: Wed, 18 Nov 2026 06:54:48 +0000 Subject: [PATCH] ci: time out the sdlc ci job after 30 minutes A job on exedore-cached1 hung for 2h18m inside a nested podman build and held the runner until it was cancelled by hand; GitHub's default is six hours. examples/ci.yml now sets timeout-minutes: 30 on `sdlc ci`, and convert_repo.py counts timeout-minutes among the keys the stub covers, so a second run over a converted repo still finds nothing to do. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01R7Y1jeWKZVB8rtVJ3TZsRc --- CHANGELOG.md | 6 ++++++ examples/ci.yml | 1 + scripts/convert_repo.py | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c0a5cdd..e2ba2fa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,12 @@ All notable changes to this project are documented here, following ## [Unreleased] +### Changed + +- `examples/ci.yml`'s `sdlc ci` job times out after 30 minutes rather than + GitHub's 6 hours, so a hung job cannot hold a runner; `convert_repo.py` still + treats a job carrying `timeout-minutes` as one the stub covers. + ## [0.10.2] - 2026-11-18 ### Changed diff --git a/examples/ci.yml b/examples/ci.yml index 3af87ab..db67dc5 100644 --- a/examples/ci.yml +++ b/examples/ci.yml @@ -34,6 +34,7 @@ permissions: jobs: sdlc: name: sdlc ci + timeout-minutes: 30 runs-on: ubuntu-latest steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 diff --git a/scripts/convert_repo.py b/scripts/convert_repo.py index 2460cef..8cc2399 100755 --- a/scripts/convert_repo.py +++ b/scripts/convert_repo.py @@ -298,7 +298,7 @@ def is_gourmand_job(job: object) -> bool: # and steps that are only the checkout and the `sdlc ci` step. Anything more -- # another step, a service, an env, a matrix -- is something ci.yml would # drop, so that workflow keeps its place and only its step is rewritten. -COVERED_SDLC_KEYS = {"name", "runs-on", "steps", "permissions"} +COVERED_SDLC_KEYS = {"name", "runs-on", "steps", "permissions", "timeout-minutes"} COVERED_GOURMAND_KEYS = {"name", "uses"} COVERED_WORKFLOW_KEYS = {"name", True, "on", "permissions", "jobs"} # YAML 1.1 reads on: as True CHECKOUT = re.compile(r"^actions/checkout@")