Repository navigation
Commit 4eaf688
jm
fix: address review - error vs miss on CLARIN getters, uuid-less creates
- get_items_from_collection: a failed request returned [], the consumers'
end-of-collection signal, silently truncating their paging loops. It now
goes through fetch_resource and returns None (last_err set on a non-200).
- get_user_by_email: DSpace answers an unknown email with 204 No Content.
204 is the clean miss (None, no log, no last_err); 404 and any other
non-user answer return None but log ERROR and keep last_err; the raw
email is never logged. Transport errors propagate instead of looking
like a miss.
- create_group / create_user / create_submit_group: return None when the
parsed body has no uuid, since Group(None)/User(None) are now accepted
and would be truthy, uuid-less objects.
- get_owningCollection: an unparseable 200 records last_err; a transport
error returns None (logged) so one timeout does not abort a prefetch loop.
- add_member: correct the comment - DSpace resolves the posted eperson by
its trailing UUID, the bare /epersons/ href was not broken.1 parent 88c4c56 commit 4eaf688
4 files changed
Lines changed: 138 additions & 55 deletions
File tree
- dspace_rest_client
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1165 | 1165 | | |
1166 | 1166 | | |
1167 | 1167 | | |
1168 | | - | |
1169 | | - | |
1170 | | - | |
1171 | | - | |
1172 | | - | |
1173 | | - | |
1174 | | - | |
1175 | | - | |
1176 | | - | |
1177 | | - | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
| 1177 | + | |
| 1178 | + | |
1178 | 1179 | | |
| 1180 | + | |
1179 | 1181 | | |
1180 | 1182 | | |
1181 | 1183 | | |
| |||
1283 | 1285 | | |
1284 | 1286 | | |
1285 | 1287 | | |
1286 | | - | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
1287 | 1293 | | |
1288 | 1294 | | |
1289 | 1295 | | |
| |||
1322 | 1328 | | |
1323 | 1329 | | |
1324 | 1330 | | |
1325 | | - | |
| 1331 | + | |
| 1332 | + | |
| 1333 | + | |
| 1334 | + | |
| 1335 | + | |
1326 | 1336 | | |
1327 | 1337 | | |
1328 | 1338 | | |
| |||
1335 | 1345 | | |
1336 | 1346 | | |
1337 | 1347 | | |
1338 | | - | |
| 1348 | + | |
1339 | 1349 | | |
1340 | 1350 | | |
1341 | 1351 | | |
| |||
1359 | 1369 | | |
1360 | 1370 | | |
1361 | 1371 | | |
1362 | | - | |
1363 | | - | |
| 1372 | + | |
| 1373 | + | |
1364 | 1374 | | |
1365 | 1375 | | |
1366 | 1376 | | |
| |||
1429 | 1439 | | |
1430 | 1440 | | |
1431 | 1441 | | |
1432 | | - | |
1433 | | - | |
1434 | | - | |
1435 | | - | |
1436 | | - | |
| 1442 | + | |
| 1443 | + | |
| 1444 | + | |
| 1445 | + | |
| 1446 | + | |
| 1447 | + | |
1437 | 1448 | | |
1438 | 1449 | | |
1439 | 1450 | | |
| |||
1568 | 1579 | | |
1569 | 1580 | | |
1570 | 1581 | | |
1571 | | - | |
1572 | | - | |
1573 | | - | |
1574 | | - | |
1575 | | - | |
1576 | | - | |
1577 | | - | |
1578 | | - | |
1579 | | - | |
1580 | | - | |
1581 | | - | |
1582 | | - | |
1583 | | - | |
1584 | | - | |
1585 | | - | |
1586 | | - | |
1587 | | - | |
1588 | | - | |
| 1582 | + | |
| 1583 | + | |
| 1584 | + | |
| 1585 | + | |
| 1586 | + | |
| 1587 | + | |
| 1588 | + | |
| 1589 | + | |
| 1590 | + | |
| 1591 | + | |
| 1592 | + | |
| 1593 | + | |
| 1594 | + | |
1589 | 1595 | | |
| 1596 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
21 | | - | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
| |||
131 | 132 | | |
132 | 133 | | |
133 | 134 | | |
134 | | - | |
135 | | - | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
136 | 139 | | |
137 | 140 | | |
138 | 141 | | |
139 | | - | |
| 142 | + | |
| 143 | + | |
140 | 144 | | |
141 | 145 | | |
142 | 146 | | |
| |||
187 | 191 | | |
188 | 192 | | |
189 | 193 | | |
190 | | - | |
191 | | - | |
192 | | - | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
193 | 221 | | |
194 | 222 | | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
202 | 226 | | |
203 | 227 | | |
204 | 228 | | |
| |||
258 | 282 | | |
259 | 283 | | |
260 | 284 | | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
261 | 299 | | |
262 | 300 | | |
263 | 301 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
140 | | - | |
| 139 | + | |
| 140 | + | |
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
159 | 197 | | |
160 | 198 | | |
161 | 199 | | |
| |||
0 commit comments