You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3ca2011
Browse filesBrowse the repository at this point in the historyBrowse files
fix(submission): keep keyboard reorder-cancel and clear-entry consistent
Both from the Copilot review of this PR; both are regressions this PR introduced.
cancelKeyboardDragAndDrop() still moved the group models only, so Escape after a
keyboard reorder restored the model order while leaving the FormArray as it was -
the exact desync this PR set out to remove. It now goes through
moveGroupAndControl() like the drag and arrow-key paths.
Dropping the clear entry's (click) handler to stop it firing twice per mouse
interaction also removed its keyboard activation, since a native button turns
Enter into a click. It now carries (keydown.enter) alongside (mousedown), which
mirrors how the options are bound.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: src/app/shared/form/builder/ds-dynamic-form-ui/models/array-group/dynamic-form-array.component.row-binding.spec.ts
Copy file name to clipboardExpand all lines: src/app/shared/form/builder/ds-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.component.html
+3-1Lines changed: 3 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -59,8 +59,10 @@
59
59
<!-- Clearing is destructive and must sit at the END of the menu. As the first entry it was
60
60
rendered directly beneath the input, exactly where a click meant to close the menu lands,
61
61
so dismissing the dropdown wiped the value instead.
62
-
A single handler: carrying both (click) and (mousedown) fired it twice per interaction. -->
62
+
(mousedown) + (keydown.enter) mirrors the options above: carrying (click) as well fired
63
+
it twice per mouse interaction, but dropping it outright left clearing mouse-only. -->
Copy file name to clipboardExpand all lines: src/app/shared/form/builder/ds-dynamic-form-ui/models/scrollable-dropdown/dynamic-scrollable-dropdown.duplicate.spec.ts
0 commit comments