Skip to content

fix(plan): ISSUE_CONTENT / ACCEPTANCE_CRITERIA / ISSUE_REF captured from Git agent but never consumed #331

Description

@dean0x

Problem

src/assets/commands/plan.mds line 84 instructs capturing three variables from the Git agent's output:

Capture from Git agent output: `ISSUE_CONTENT`, `ACCEPTANCE_CRITERIA`, `ISSUE_REF`.
Use the fetched data to seed the discovery below; skip Gate 0 questions where the issue
already provides sufficient scope ...

Grepping plan.mds for each name returns exactly one hit each — the capture line itself. None of the three variables is referenced again anywhere in the command. The capture is dead: the values are named in the instruction but have no downstream consumer in the file.

This matters because ADR-003 ("prefix-shippability clause (iii)") requires every declared artifact to have at least one reachable consumer in the phase's end-state. Prior to PR #327, this list also included ISSUE_ID and ISSUE_URL, which had no producer in git.md at all (those were removed in #327). The remaining three now have producers but still no consumers.

Evidence

$ grep -c "ISSUE_CONTENT\|ACCEPTANCE_CRITERIA\|ISSUE_REF\b" src/assets/commands/plan.mds
1
  • src/assets/commands/plan.mds:84 — sole occurrence (the capture instruction itself)
  • No other reference to ISSUE_CONTENT, ACCEPTANCE_CRITERIA, or ISSUE_REF in plan.mds

Fix

Two options:

  1. Wire the captured values into the gate flow: pass ISSUE_CONTENT and ACCEPTANCE_CRITERIA into the Gate 0 discovery questions as seeding context (the instruction already says "skip Gate 0 questions where the issue already provides sufficient scope" — make that conditional explicit with a variable reference). Pass ISSUE_REF into the design agent or plan artifact header so the issue link propagates through the workflow.

  2. Drop the capture instruction: if the three values are genuinely not needed in the plan flow, remove the Capture from Git agent output: sentence to eliminate the dead instruction.

Option 1 is likely the right fix — the capture was presumably added to serve Gate 0 seeding and plan traceability; the wiring was never completed.

Found during review of PR #327.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtech-debtTechnical debt items to address

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions