Wrong URL Sometimes Generated GH tuples

[tuaris]

The issue is described in detail here: https://forums.FreeBSD.org/threads/porting-grafana-tempo-oauth2adapt-go-module-fails-to-download.95531/post-677779

It seems that there are some edge cases that results in incorrect tuples being generated. For example. the tool generates the following tuples:

googleapis:google-cloud-go:v0.2.2:googleapis_google_cloud_go_1/vendor/cloud.google.com/go/auth/oauth2adapt \
open-telemetry:opentelemetry-collector:v1.12.0:open_telemetry_opentelemetry_collector_4/vendor/go.opentelemetry.io/collector/pdata \
open-telemetry:opentelemetry-collector:v1.9.0:open_telemetry_opentelemetry_collector_1/vendor/go.opentelemetry.io/collector/config/configcompression \
open-telemetry:opentelemetry-collector:v1.9.0:open_telemetry_opentelemetry_collector_2/vendor/go.opentelemetry.io/collector/config/configopaque \
open-telemetry:opentelemetry-collector:v1.9.0:open_telemetry_opentelemetry_collector_3/vendor/go.opentelemetry.io/collector/featuregate \
open-telemetry:opentelemetry-go-contrib:v0.52.0:open_telemetry_opentelemetry_go_contrib_1/vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc \
open-telemetry:opentelemetry-go-contrib:v0.53.0:open_telemetry_opentelemetry_go_contrib_2/vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp \
open-telemetry:opentelemetry-go:v0.49.0:open_telemetry_opentelemetry_go_6/vendor/go.opentelemetry.io/otel/exporters/prometheus \

Which result in 404 errors such as:

===>  License AGPLv3 accepted by the user
===>  License AGPLv3 accepted by the user
===>   grafana-tempo-2.6.1 depends on file: /usr/local/sbin/pkg - found
=> open-telemetry-opentelemetry-collector-featuregate-v1.9.0_GH0.tar.gz doesn't seem to exist in /usr/home/daniel/Shared/Development/ports/distfiles/.
=> Attempting to fetch https://codeload.github.com/open-telemetry/opentelemetry-collector/tar.gz/featuregate/v1.9.0?dummy=/open-telemetry-opentelemetry-collector-featuregate-v1.9.0_GH0.tar.gz
fetch: https://codeload.github.com/open-telemetry/opentelemetry-collector/tar.gz/featuregate/v1.9.0?dummy=/open-telemetry-opentelemetry-collector-featuregate-v1.9.0_GH0.tar.gz: size of remote file is not known
open-telemetry-opentelemetry-collector-feature        1539 kB 2600 kBps    01s
=> open-telemetry-opentelemetry-go-contrib-v0.52.0_GH0.tar.gz doesn't seem to exist in /usr/home/daniel/Shared/Development/ports/distfiles/.
=> Attempting to fetch https://codeload.github.com/open-telemetry/opentelemetry-go-contrib/tar.gz/v0.52.0?dummy=/open-telemetry-opentelemetry-go-contrib-v0.52.0_GH0.tar.gz
fetch: https://codeload.github.com/open-telemetry/opentelemetry-go-contrib/tar.gz/v0.52.0?dummy=/open-telemetry-opentelemetry-go-contrib-v0.52.0_GH0.tar.gz: Not Found
=> Attempting to fetch http://distcache.FreeBSD.org/ports-distfiles/open-telemetry-opentelemetry-go-contrib-v0.52.0_GH0.tar.gz
fetch: http://distcache.FreeBSD.org/ports-distfiles/open-telemetry-opentelemetry-go-contrib-v0.52.0_GH0.tar.gz: Not Found
=> Couldn't fetch it - please try to retrieve this
=> port manually into /usr/home/daniel/Shared/Development/ports/distfiles/ and try again.
*** Error code 1

The GH tuples should instead be:

googleapis:google-cloud-go:auth/oauth2adapt/v0.2.2:googleapis_google_cloud_go/vendor/cloud.google.com/go/auth/oauth2adapt \
open-telemetry:opentelemetry-collector:pdata/v1.12.0:open_telemetry_opentelemetry_collector/vendor/go.opentelemetry.io/collector/pdata \
open-telemetry:opentelemetry-collector:config/configcompression/v1.9.0:open_telemetry_opentelemetry_collector/vendor/go.opentelemetry.io/collector/config/configcompression \
open-telemetry:opentelemetry-collector:config/configopaque/v1.9.0:open_telemetry_opentelemetry_collector/vendor/go.opentelemetry.io/collector/config/configopaque \
open-telemetry:opentelemetry-collector:featuregate/v1.9.0:open_telemetry_opentelemetry_collector/vendor/go.opentelemetry.io/collector/featuregate \
open-telemetry:opentelemetry-go-contrib:instrumentation/google.golang.org/grpc/otelgrpc/v0.52.0:open_telemetry_opentelemetry_go_contrib/vendor/go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc \
open-telemetry:opentelemetry-go-contrib:instrumentation/net/http/otelhttp/v0.53.0:open_telemetry_opentelemetry_go_contrib/vendor/go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp \
open-telemetry:opentelemetry-go:otel/exporters/prometheus/v0.49.0:open_telemetry_opentelemetry_go/vendor/go.opentelemetry.io/otel/exporters/prometheus \

This was experienced while trying to generate them for https://github.com/grafana/tempo

[tuaris]

Also just noticed that while the go-redis module URL is correctly generated, the filesystem path is incorrect. It will look for work/redis-x.x.x instead of work/go-redis-x.x.x when moving items into the vendor folder.

Example:

go-redis:redis:v8.11.5:go_redis_redis_v8/vendor/github.com/go-redis/redis/v8

Should be

redis:go-redis:v8.11.5:go_redis_redis_v8/vendor/github.com/go-redis/redis/v8

[alexdupre]

I've fixed these and other issues in my fork: https://github.com/alexdupre/modules2tuple/

Just committed to the ports tree as 2.2.6 release.