From 221c570f7b0a8608405b98f88c336f9e09a97299 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Sun, 19 Oct 2025 19:44:01 +0000 Subject: [PATCH 1/4] CI(CodeQL): Scan C/C++ with build-mode: none --- .github/workflows/codeql-analysis.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index ceee1dfe399..634f4110f18 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -28,10 +28,13 @@ jobs: strategy: fail-fast: false matrix: - language: - - c-cpp - - python - - actions + include: + - language: c-cpp + build-mode: none + - language: python + build-mode: none + - language: actions + build-mode: none concurrency: group: ${{ github.workflow }}-${{ @@ -65,6 +68,7 @@ jobs: with: languages: ${{ matrix.language }} config-file: ./.github/codeql/codeql-config.yml + build-mode: ${{ matrix.build-mode }} - name: Create installation directory run: | @@ -79,7 +83,7 @@ jobs: echo "MAKEFLAGS=-j$(nproc)" >> "${GITHUB_ENV}" - name: Build - if: ${{ matrix.language == 'c-cpp' }} + if: ${{ matrix.language == 'c-cpp' && false }} env: CFLAGS: -std=gnu17 CXXFLAGS: -std=c++17 From c9e7803f9f3c46b379a26de9c45177aff9ba8977 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Sun, 19 Oct 2025 20:05:26 +0000 Subject: [PATCH 2/4] CI(CodeQL): Remove installing dependencies --- .github/workflows/codeql-analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml index 634f4110f18..fadba2398fd 100644 --- a/.github/workflows/codeql-analysis.yml +++ b/.github/workflows/codeql-analysis.yml @@ -52,7 +52,7 @@ jobs: with: python-version: "3.x" - name: Install non-Python dependencies - if: ${{ matrix.language == 'c-cpp' }} + if: ${{ matrix.language == 'c-cpp' && false }} run: | sudo apt-get update -y sudo apt-get install -y wget git gawk findutils From 5a97739b9331dc501994bfdfec5390fcf1b04c97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Sun, 19 Oct 2025 20:23:49 +0000 Subject: [PATCH 3/4] Checks(CodeQL): Use security-extended query suite --- .github/codeql/codeql-config.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/codeql/codeql-config.yml b/.github/codeql/codeql-config.yml index a1c7428e3f8..f13709c86d4 100644 --- a/.github/codeql/codeql-config.yml +++ b/.github/codeql/codeql-config.yml @@ -6,3 +6,5 @@ paths-ignore: - dist.* - node_modules - python/grass/pygrass/tests +queries: + - uses: security-extended From 3e33279775fae7cc4cec594a6055aa3865c04392 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Edouard=20Choini=C3=A8re?= <27212526+echoix@users.noreply.github.com> Date: Sun, 19 Oct 2025 23:33:46 -0400 Subject: [PATCH 4/4] Potential fix for code scanning alert no. 7126: Multiplication result converted to larger type Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --- raster3d/r3.showdspf/draw_cappolys_ogl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/raster3d/r3.showdspf/draw_cappolys_ogl.c b/raster3d/r3.showdspf/draw_cappolys_ogl.c index 489d771a604..38988d7ae0f 100644 --- a/raster3d/r3.showdspf/draw_cappolys_ogl.c +++ b/raster3d/r3.showdspf/draw_cappolys_ogl.c @@ -66,7 +66,7 @@ int index; norm[0] = norm[2] = 0.0; for (t = start; t != stop; t += direction) { tmpvt[t][0] = (vertices[t << 1] + xloc) * D_spec->xscale; - tmpvt[t][1] = (D_Cap->z) * D_spec->yscale; + tmpvt[t][1] = ((double) D_Cap->z) * D_spec->yscale; tmpvt[t][2] = (vertices[(t << 1) + 1] + yloc) * D_spec->zscale; } break;