Skip to content

staging has no branch protection — CI security gates run but don't block merges #185

Description

@jgruberf5

Summary

staging — the integration branch every release is promoted from — has no branch protection at all:

$ gh api repos/f5devcentral/bnk-forge/branches/staging/protection
{"message":"Branch not protected","status":"404"}

So the CI jobs, including the new gitleaks / shellcheck / version-consistency security gates (#182, #180), run but are not required checks. Nothing blocks a merge to staging when a gate is red — a secret, a shellcheck failure, or a version-drift could land and then be promoted.

Found in a pre-4.0.0-release critical review, alongside #184.

Why it matters

Suggested fix (repo-admin, not a code PR)

  • Add branch protection to staging requiring the aggregate CI Gate status check (and a review, matching main's intent).
  • Reconcile main's lock so the release automation can complete (tracked separately with the release-lock work).
  • Confirm the new P1 gates (Secret Scan, ShellCheck, Version Consistency, Script Self-Tests) are included in the required set once they've merged.

Scope

Governance/config, not code — hence no code PR. Severity medium: active human review is the current backstop (workaround exists), but the automated security gate is not actually enforcing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciCI pipeline, build, release automationsecuritySecurity hardening, CVE tracking, or an authz/authn gapseverity:mediumCorrectness or diagnosability degraded; workaround exists

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions