From f7cbb97274c5cf573652c71ea441d29248783107 Mon Sep 17 00:00:00 2001 From: Johnathan Falk Date: Tue, 27 Oct 2026 21:41:38 -0400 Subject: [PATCH] fix(reusable-ci): pin gha-ci-workflow-helpers with the frontend-run exit-code fix Under the previous pin (4b5f4d45, labelled v1.1.4) the frontend-run command exited 0 when the npm script failed, so a failing frontend test or E2E run was reported as a pass. Re-pin all 13 references to v1.1.7-rc.8 (ca7caa417), which contains gha-ci-workflow-helpers#29. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_011To9HQUWYYqyWHoXYmEi6Z --- .github/guid-index.json | 2 +- .github/workflows/reusable-ci.yml | 28 +++++++++---------- .../20261027_bump_ci_helpers_frontend_run.md | 3 ++ 3 files changed, 18 insertions(+), 15 deletions(-) create mode 100644 changelog.d/20261027_bump_ci_helpers_frontend_run.md diff --git a/.github/guid-index.json b/.github/guid-index.json index cfa567ad..3d243b44 100644 --- a/.github/guid-index.json +++ b/.github/guid-index.json @@ -979,7 +979,7 @@ "path": ".github/workflows/reusable-ci.yml", "guid": "reusable-ci-2025-09-24-core-workflow", "title": "Reusable CI Workflow", - "version": "1.19.3", + "version": "1.19.4", "header_path": ".github/workflows/reusable-ci.yml", "path_mismatch": false }, diff --git a/.github/workflows/reusable-ci.yml b/.github/workflows/reusable-ci.yml index beb1017d..e5b03f54 100644 --- a/.github/workflows/reusable-ci.yml +++ b/.github/workflows/reusable-ci.yml @@ -1,5 +1,5 @@ # file: .github/workflows/reusable-ci.yml -# version: 1.19.3 +# version: 1.19.4 # guid: reusable-ci-2025-09-24-core-workflow # last-edited: 2026-10-27 @@ -657,7 +657,7 @@ jobs: sudo apt-get install -y $PACKAGES - name: Build Go project - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: go-setup @@ -665,7 +665,7 @@ jobs: # go tool cover ignore flags they do not know, so this only reaches tests. - name: Test Go project if: ${{ !inputs.skip-tests }} - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 env: GOFLAGS: ${{ inputs.go-test-timeout != '' && format('-timeout={0}', inputs.go-test-timeout) || '' }} with: @@ -759,7 +759,7 @@ jobs: echo "GHCOMMON_SCRIPTS_DIR=$PWD/ghcommon-workflow-scripts/.github/workflows/scripts" >> "$GITHUB_ENV" - name: Install Python dependencies - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: python-install @@ -772,7 +772,7 @@ jobs: - name: Test Python code if: ${{ !inputs.skip-tests }} - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: python-run-tests @@ -839,13 +839,13 @@ jobs: - name: Format Rust code if: ${{ !inputs.skip-linting }} - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: rust-format - name: Lint Rust code if: ${{ !inputs.skip-linting }} - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: rust-clippy @@ -931,14 +931,14 @@ jobs: # No additional cache setup needed here. - name: Install dependencies - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: frontend-install frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }} - name: Lint frontend code if: ${{ !inputs.skip-linting }} - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: frontend-run frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }} @@ -947,7 +947,7 @@ jobs: frontend-failure-message: '❌ Linting failed or not configured' - name: Build frontend - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: frontend-run frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }} @@ -957,7 +957,7 @@ jobs: - name: Test frontend if: ${{ !inputs.skip-tests }} - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: frontend-run frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }} @@ -986,7 +986,7 @@ jobs: - name: Run E2E tests if: ${{ !inputs.skip-tests && !inputs.skip-e2e-tests }} - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: frontend-run frontend-working-dir: ${{ steps.frontend-dir.outputs.dir }} @@ -1149,7 +1149,7 @@ jobs: } >> "$GITHUB_ENV" - name: Generate summary - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: generate-ci-summary env: @@ -1164,7 +1164,7 @@ jobs: JOB_DOCS: skipped - name: Check overall status - uses: falkcorp/gha-ci-workflow-helpers@4b5f4d45d42c99d98ccf731624f2f4b91d849561 # v1.1.4 + uses: falkcorp/gha-ci-workflow-helpers@ca7caa4172a20983df0f93c16e4637669fa002f4 # v1.1.7-rc.8 with: command: check-ci-status env: diff --git a/changelog.d/20261027_bump_ci_helpers_frontend_run.md b/changelog.d/20261027_bump_ci_helpers_frontend_run.md new file mode 100644 index 00000000..968466ce --- /dev/null +++ b/changelog.d/20261027_bump_ci_helpers_frontend_run.md @@ -0,0 +1,3 @@ +### Fixed + +- reusable-ci: gha-ci-workflow-helpers is pinned to v1.1.7-rc.8 (was a v1.1.4-labelled SHA). Under the old pin the `frontend-run` command exited 0 when the npm script failed, so a failing frontend unit or E2E run was reported as a pass; it now fails the step.