From fab633986d750f12da1158fe71231cd4726dace8 Mon Sep 17 00:00:00 2001 From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com> Date: Fri, 30 Oct 2026 00:18:23 +0000 Subject: [PATCH 1/2] chore: placeholder for #1014 --- .deleteme.now | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 .deleteme.now diff --git a/.deleteme.now b/.deleteme.now new file mode 100644 index 00000000..e69de29b From baff79236811637b1056dd268706926e42e628a3 Mon Sep 17 00:00:00 2001 From: Mark Ridgwell <273118822+dnyw4l3n13@users.noreply.github.com> Date: Fri, 30 Oct 2026 00:23:56 +0000 Subject: [PATCH 2/2] fix(workflows): prefix core.setFailed messages with cross-mark emoji Closes #1014 --- .deleteme.now | 0 .github/actions/approve-pr/action.yml | 2 +- .github/actions/assign-pr-to-creator/action.yml | 2 +- .../actions/check-no-case-sensitivity-conflicts/action.yml | 2 +- .github/actions/check-no-ignored-files/action.yml | 2 +- .github/actions/check-no-merge-commits/action.yml | 4 ++-- .github/actions/check-no-merge-conflicts/action.yml | 4 ++-- .github/actions/enable-automerge/action.yml | 2 +- .github/workflows/pr-lint.yml | 2 +- 9 files changed, 10 insertions(+), 10 deletions(-) delete mode 100644 .deleteme.now diff --git a/.deleteme.now b/.deleteme.now deleted file mode 100644 index e69de29b..00000000 diff --git a/.github/actions/approve-pr/action.yml b/.github/actions/approve-pr/action.yml index 4719ad57..4e617e87 100644 --- a/.github/actions/approve-pr/action.yml +++ b/.github/actions/approve-pr/action.yml @@ -22,7 +22,7 @@ runs: script: | const prNumber = Number(process.env.PR_NUMBER || context.payload.pull_request?.number); if (!Number.isInteger(prNumber) || prNumber <= 0) { - core.setFailed('No pull request number available: supply the pr-number input or run on a pull_request event.'); + core.setFailed('❌ No pull request number available: supply the pr-number input or run on a pull_request event.'); return; } await github.rest.pulls.createReview({ diff --git a/.github/actions/assign-pr-to-creator/action.yml b/.github/actions/assign-pr-to-creator/action.yml index dc3e8be3..3176e118 100644 --- a/.github/actions/assign-pr-to-creator/action.yml +++ b/.github/actions/assign-pr-to-creator/action.yml @@ -22,7 +22,7 @@ runs: script: | const prNumber = Number(process.env.PR_NUMBER || context.payload.pull_request?.number); if (!Number.isInteger(prNumber) || prNumber <= 0) { - core.setFailed('No pull request number available: supply the pr-number input or run on a pull_request event.'); + core.setFailed('❌ No pull request number available: supply the pr-number input or run on a pull_request event.'); return; } const pullRequest = process.env.PR_NUMBER diff --git a/.github/actions/check-no-case-sensitivity-conflicts/action.yml b/.github/actions/check-no-case-sensitivity-conflicts/action.yml index 83934545..3544fcee 100644 --- a/.github/actions/check-no-case-sensitivity-conflicts/action.yml +++ b/.github/actions/check-no-case-sensitivity-conflicts/action.yml @@ -50,4 +50,4 @@ runs: core.error(`Case sensitivity conflict: ${file}`, { file }); } - core.setFailed(`Case sensitivity conflicts found (${offenders.length}).`); + core.setFailed(`❌ Case sensitivity conflicts found (${offenders.length}).`); diff --git a/.github/actions/check-no-ignored-files/action.yml b/.github/actions/check-no-ignored-files/action.yml index c1996a0a..9da637f4 100644 --- a/.github/actions/check-no-ignored-files/action.yml +++ b/.github/actions/check-no-ignored-files/action.yml @@ -47,4 +47,4 @@ runs: core.error(`Ignored file found: ${file}`, { file }); } - core.setFailed(`Found ignored files (${ignoredFiles.length}).`); + core.setFailed(`❌ Found ignored files (${ignoredFiles.length}).`); diff --git a/.github/actions/check-no-merge-commits/action.yml b/.github/actions/check-no-merge-commits/action.yml index a72cc4e8..2df72b95 100644 --- a/.github/actions/check-no-merge-commits/action.yml +++ b/.github/actions/check-no-merge-commits/action.yml @@ -22,7 +22,7 @@ runs: script: | const prNumber = Number(process.env.PR_NUMBER || context.payload.pull_request?.number); if (!Number.isInteger(prNumber) || prNumber <= 0) { - core.setFailed('No pull request number available: supply the pr-number input or run on a pull_request event.'); + core.setFailed('❌ No pull request number available: supply the pr-number input or run on a pull_request event.'); return; } const commits = await github.paginate(github.rest.pulls.listCommits, { @@ -35,7 +35,7 @@ runs: for (const commit of mergeCommits) { core.error(`Merge commit: ${commit.sha} - ${commit.commit.message.split('\n')[0]}`); } - core.setFailed(`Found ${mergeCommits.length} merge commit(s). Please rebase instead of merging.`); + core.setFailed(`❌ Found ${mergeCommits.length} merge commit(s). Please rebase instead of merging.`); } else { core.info('No merge commits found.'); } diff --git a/.github/actions/check-no-merge-conflicts/action.yml b/.github/actions/check-no-merge-conflicts/action.yml index fd6fc523..57ab08ee 100644 --- a/.github/actions/check-no-merge-conflicts/action.yml +++ b/.github/actions/check-no-merge-conflicts/action.yml @@ -25,7 +25,7 @@ runs: return; } - core.setFailed(`git grep failed (exit ${error.status}): ${error.stderr || error.message}`); + core.setFailed(`❌ git grep failed (exit ${error.status}): ${error.stderr || error.message}`); return; } @@ -41,4 +41,4 @@ runs: core.error(`Merge conflict found in ${file}`, { file }); } - core.setFailed('Found merge conflicts.'); + core.setFailed('❌ Found merge conflicts.'); diff --git a/.github/actions/enable-automerge/action.yml b/.github/actions/enable-automerge/action.yml index 53e28f5b..1a342e42 100644 --- a/.github/actions/enable-automerge/action.yml +++ b/.github/actions/enable-automerge/action.yml @@ -27,7 +27,7 @@ runs: const mergeMethod = process.env.MERGE_METHOD; const prNumber = Number(process.env.PR_NUMBER || context.payload.pull_request?.number); if (!Number.isInteger(prNumber) || prNumber <= 0) { - core.setFailed('No pull request number available: supply the pr-number input or run on a pull_request event.'); + core.setFailed('❌ No pull request number available: supply the pr-number input or run on a pull_request event.'); return; } const pullRequest = process.env.PR_NUMBER diff --git a/.github/workflows/pr-lint.yml b/.github/workflows/pr-lint.yml index 6742470a..2f569fc9 100644 --- a/.github/workflows/pr-lint.yml +++ b/.github/workflows/pr-lint.yml @@ -141,7 +141,7 @@ jobs: uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0 with: script: | - core.setFailed('Changelog has not changed') + core.setFailed('❌ Changelog has not changed') # @@required: merge change-log-entry-is-in-unreleased: