From af90d8a73996cf3daf0574abf910acb228e1b130 Mon Sep 17 00:00:00 2001 From: Fernando Cainelli Date: Mon, 16 Nov 2026 10:37:32 -0300 Subject: [PATCH 1/2] strict yaml unmarshal loading test files Signed-off-by: Fernando Cainelli --- test/testcases.go | 2 +- test/testcases_test.go | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/test/testcases.go b/test/testcases.go index d940625..98e8962 100644 --- a/test/testcases.go +++ b/test/testcases.go @@ -315,7 +315,7 @@ func testData(t *testing.T, templateData any, files ...string) TestCases { for _, doc := range bytes.Split(b.Bytes(), []byte("---")) { var testcase Case - err = yaml.Unmarshal(doc, &testcase) + err = yaml.UnmarshalStrict(doc, &testcase) require.NoError(t, err) configs = append(configs, testcase) } diff --git a/test/testcases_test.go b/test/testcases_test.go index 0f5b44a..39e523d 100644 --- a/test/testcases_test.go +++ b/test/testcases_test.go @@ -3,6 +3,8 @@ package test_test import ( "context" "log" + "os" + "os/exec" "testing" "time" @@ -13,6 +15,23 @@ import ( "github.com/stretchr/testify/suite" ) +func TestLoadRejectsUnknownFields(t *testing.T) { + // Load fails via t.FailNow, so assert on it from a child process. + if os.Getenv("EXTPROC_LOAD_CHILD") == "1" { + extproctest.Load(t, "testdata/unknown_field.yml") + return + } + if testing.Short() { + t.Skip() + } + + cmd := exec.Command(os.Args[0], "-test.run=^TestLoadRejectsUnknownFields$") + cmd.Env = append(os.Environ(), "EXTPROC_LOAD_CHILD=1") + out, err := cmd.CombinedOutput() + require.Error(t, err, "Load should fail on unknown fields:\n%s", out) + require.Contains(t, string(out), `unknown field "expect"`) +} + func TestIntegration(t *testing.T) { suite.Run(t, &IntegrationTestSuite{}) } From 38b549ebd419423cb87cd7b297ae1b22901134ab Mon Sep 17 00:00:00 2001 From: Fernando Cainelli Date: Mon, 16 Nov 2026 10:38:22 -0300 Subject: [PATCH 2/2] add missing test file Signed-off-by: Fernando Cainelli --- test/testdata/unknown_field.yml | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 test/testdata/unknown_field.yml diff --git a/test/testdata/unknown_field.yml b/test/testdata/unknown_field.yml new file mode 100644 index 0000000..d48fbb3 --- /dev/null +++ b/test/testdata/unknown_field.yml @@ -0,0 +1,9 @@ +name: expect is wrongly nested under input +input: + headers: + - name: user-agent + value: curl/8.0.0 + expect: + requestHeaders: + - name: x-custom-header + exact: value-1