From 83e211ce35414a77cb582b016d106952856d8e76 Mon Sep 17 00:00:00 2001 From: Asger F Date: Wed, 1 Jul 2026 12:57:50 +0200 Subject: [PATCH 1/6] unified: Make tests fail on purpose --- unified/ql/test/library-tests/BasicTest/test.expected | 2 ++ 1 file changed, 2 insertions(+) diff --git a/unified/ql/test/library-tests/BasicTest/test.expected b/unified/ql/test/library-tests/BasicTest/test.expected index b9f4eafe8653..e73e2bde9b8a 100644 --- a/unified/ql/test/library-tests/BasicTest/test.expected +++ b/unified/ql/test/library-tests/BasicTest/test.expected @@ -1,3 +1,5 @@ +Dummy text to make the test fail + nameExpr | name_expr.swift:1:9:1:9 | NameExpr | y | | test.swift:1:8:1:17 | NameExpr | Foundation | From 58385ed73d0ddcbec6529524c4b31a8325e247f1 Mon Sep 17 00:00:00 2001 From: Asger F Date: Wed, 1 Jul 2026 13:27:10 +0200 Subject: [PATCH 2/6] Also make corpus tests fail --- .../corpus/swift/closures/closure-with-capture-list.output | 2 ++ 1 file changed, 2 insertions(+) diff --git a/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output b/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output index 8f28322b4930..fa05cee10861 100644 --- a/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output +++ b/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output @@ -67,3 +67,5 @@ top_level pattern: name_pattern identifier: identifier "self" + +dummy text to make the test fail From d962364f067872f04d801addb56b23c6f1e5a41c Mon Sep 17 00:00:00 2001 From: Asger F Date: Wed, 1 Jul 2026 13:27:18 +0200 Subject: [PATCH 3/6] Revert "unified: Make tests fail on purpose" This reverts commit 83e211ce35414a77cb582b016d106952856d8e76. --- unified/ql/test/library-tests/BasicTest/test.expected | 2 -- 1 file changed, 2 deletions(-) diff --git a/unified/ql/test/library-tests/BasicTest/test.expected b/unified/ql/test/library-tests/BasicTest/test.expected index e73e2bde9b8a..b9f4eafe8653 100644 --- a/unified/ql/test/library-tests/BasicTest/test.expected +++ b/unified/ql/test/library-tests/BasicTest/test.expected @@ -1,5 +1,3 @@ -Dummy text to make the test fail - nameExpr | name_expr.swift:1:9:1:9 | NameExpr | y | | test.swift:1:8:1:17 | NameExpr | Foundation | From d8e95ba5e868ae5722d501cf5c719b0b862cb68c Mon Sep 17 00:00:00 2001 From: Asger F Date: Wed, 1 Jul 2026 13:35:35 +0200 Subject: [PATCH 4/6] Revert "Also make corpus tests fail" This reverts commit 58385ed73d0ddcbec6529524c4b31a8325e247f1. --- .../corpus/swift/closures/closure-with-capture-list.output | 2 -- 1 file changed, 2 deletions(-) diff --git a/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output b/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output index fa05cee10861..8f28322b4930 100644 --- a/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output +++ b/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output @@ -67,5 +67,3 @@ top_level pattern: name_pattern identifier: identifier "self" - -dummy text to make the test fail From 4698a355a89f11714679bdd3818daa0b3860383c Mon Sep 17 00:00:00 2001 From: Asger F Date: Wed, 1 Jul 2026 13:59:07 +0200 Subject: [PATCH 5/6] Make change in corpus test --- .../corpus/swift/closures/closure-with-capture-list.output | 6 +++--- .../corpus/swift/closures/closure-with-capture-list.swift | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output b/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output index 8f28322b4930..f4ada182d9ec 100644 --- a/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output +++ b/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.output @@ -1,4 +1,4 @@ -let f = { [weak self] in self?.doThing() } +let f = { [weak self] in self?.doThingBlah() } --- @@ -28,7 +28,7 @@ source_file navigation_expression suffix: navigation_suffix - suffix: simple_identifier "doThing" + suffix: simple_identifier "doThingBlah" target: optional_chain_marker expr: @@ -60,7 +60,7 @@ top_level base: name_expr identifier: identifier "self" - member: identifier "doThing" + member: identifier "doThingBlah" capture_declaration: variable_declaration modifier: modifier "weak" diff --git a/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.swift b/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.swift index e6b06ca3d0db..c3db10454c4b 100644 --- a/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.swift +++ b/unified/extractor/tests/corpus/swift/closures/closure-with-capture-list.swift @@ -1 +1 @@ -let f = { [weak self] in self?.doThing() } +let f = { [weak self] in self?.doThingBlah() } From da6301f19195c8ce3b9acc59b4dc7a8aeee86c4d Mon Sep 17 00:00:00 2001 From: Asger F Date: Wed, 1 Jul 2026 13:59:35 +0200 Subject: [PATCH 6/6] Make change in qltest --- .../library-tests/BasicTest/test.expected | 66 +++++++++---------- .../test/library-tests/BasicTest/test.swift | 2 + 2 files changed, 35 insertions(+), 33 deletions(-) diff --git a/unified/ql/test/library-tests/BasicTest/test.expected b/unified/ql/test/library-tests/BasicTest/test.expected index b9f4eafe8653..20be6946071c 100644 --- a/unified/ql/test/library-tests/BasicTest/test.expected +++ b/unified/ql/test/library-tests/BasicTest/test.expected @@ -1,37 +1,37 @@ nameExpr | name_expr.swift:1:9:1:9 | NameExpr | y | | test.swift:1:8:1:17 | NameExpr | Foundation | -| test.swift:8:9:8:13 | NameExpr | items | -| test.swift:8:22:8:25 | NameExpr | item | -| test.swift:12:16:12:20 | NameExpr | items | -| test.swift:12:31:12:34 | NameExpr | item | -| test.swift:25:18:25:22 | NameExpr | Array | -| test.swift:25:24:25:28 | NameExpr | first | -| test.swift:26:17:26:22 | NameExpr | second | -| test.swift:27:13:27:18 | NameExpr | result | -| test.swift:27:29:27:32 | NameExpr | item | -| test.swift:28:13:28:18 | NameExpr | result | -| test.swift:28:27:28:30 | NameExpr | item | -| test.swift:31:12:31:17 | NameExpr | result | -| test.swift:40:16:40:19 | NameExpr | data | -| test.swift:44:9:44:12 | NameExpr | data | -| test.swift:48:15:48:19 | NameExpr | index | -| test.swift:48:29:48:33 | NameExpr | index | -| test.swift:48:37:48:40 | NameExpr | data | -| test.swift:49:16:49:19 | NameExpr | data | -| test.swift:49:21:49:25 | NameExpr | index | -| test.swift:53:9:53:12 | NameExpr | data | -| test.swift:53:21:53:24 | NameExpr | item | -| test.swift:63:16:63:19 | NameExpr | self | -| test.swift:65:29:65:37 | NameExpr | transform | -| test.swift:65:39:65:43 | NameExpr | value | -| test.swift:67:29:67:33 | NameExpr | error | -| test.swift:76:16:76:19 | NameExpr | self | -| test.swift:76:21:76:21 | NameExpr | i | -| test.swift:76:26:76:29 | NameExpr | self | -| test.swift:76:31:76:31 | NameExpr | i | -| test.swift:86:12:86:17 | NameExpr | values | -| test.swift:87:12:87:17 | NameExpr | values | -| test.swift:87:38:87:43 | NameExpr | values | -| test.swift:87:49:87:57 | NameExpr | transform | +| test.swift:10:9:10:13 | NameExpr | items | +| test.swift:10:22:10:25 | NameExpr | item | +| test.swift:14:16:14:20 | NameExpr | items | +| test.swift:14:31:14:34 | NameExpr | item | +| test.swift:27:18:27:22 | NameExpr | Array | +| test.swift:27:24:27:28 | NameExpr | first | +| test.swift:28:17:28:22 | NameExpr | second | +| test.swift:29:13:29:18 | NameExpr | result | +| test.swift:29:29:29:32 | NameExpr | item | +| test.swift:30:13:30:18 | NameExpr | result | +| test.swift:30:27:30:30 | NameExpr | item | +| test.swift:33:12:33:17 | NameExpr | result | +| test.swift:42:16:42:19 | NameExpr | data | +| test.swift:46:9:46:12 | NameExpr | data | +| test.swift:50:15:50:19 | NameExpr | index | +| test.swift:50:29:50:33 | NameExpr | index | +| test.swift:50:37:50:40 | NameExpr | data | +| test.swift:51:16:51:19 | NameExpr | data | +| test.swift:51:21:51:25 | NameExpr | index | +| test.swift:55:9:55:12 | NameExpr | data | +| test.swift:55:21:55:24 | NameExpr | item | +| test.swift:65:16:65:19 | NameExpr | self | +| test.swift:67:29:67:37 | NameExpr | transform | +| test.swift:67:39:67:43 | NameExpr | value | +| test.swift:69:29:69:33 | NameExpr | error | +| test.swift:78:16:78:19 | NameExpr | self | +| test.swift:78:21:78:21 | NameExpr | i | +| test.swift:78:26:78:29 | NameExpr | self | +| test.swift:78:31:78:31 | NameExpr | i | +| test.swift:88:12:88:17 | NameExpr | values | +| test.swift:89:12:89:17 | NameExpr | values | +| test.swift:89:38:89:43 | NameExpr | values | +| test.swift:89:49:89:57 | NameExpr | transform | unsupported diff --git a/unified/ql/test/library-tests/BasicTest/test.swift b/unified/ql/test/library-tests/BasicTest/test.swift index 158ef26f598b..cce90ecc465a 100644 --- a/unified/ql/test/library-tests/BasicTest/test.swift +++ b/unified/ql/test/library-tests/BasicTest/test.swift @@ -1,5 +1,7 @@ import Foundation + + // Generic struct with type constraint struct Container { var items: [T] = []