|
1 | 1 | import { describe, it, expect } from "vitest"; |
2 | | -import { isIssueVisible, isPrVisible, isRunVisible } from "../../src/app/lib/filters"; |
| 2 | +import { |
| 3 | + isIssueVisible, |
| 4 | + isPrVisible, |
| 5 | + isRunVisible, |
| 6 | + isWorkflowRunPending, |
| 7 | + isWorkflowRunWaiting, |
| 8 | + matchesActionsConclusionFilter, |
| 9 | +} from "../../src/app/lib/filters"; |
| 10 | +import { KNOWN_CONCLUSIONS } from "../../src/app/components/shared/filterTypes"; |
3 | 11 | import { makeIssue, makePullRequest, makeWorkflowRun } from "../helpers/index"; |
4 | 12 |
|
5 | | -// All three predicates are pure functions — no reactive root or store setup needed. |
| 13 | +// All predicates are pure functions — no reactive root or store setup needed. |
6 | 14 |
|
7 | 15 | describe("isIssueVisible", () => { |
8 | 16 | describe("ignoredIds", () => { |
@@ -234,3 +242,108 @@ describe("isRunVisible", () => { |
234 | 242 | }); |
235 | 243 | }); |
236 | 244 | }); |
| 245 | + |
| 246 | +describe("isWorkflowRunWaiting", () => { |
| 247 | + it("returns true for waiting and action_required statuses and completed action_required conclusion", () => { |
| 248 | + expect(isWorkflowRunWaiting({ status: "waiting", conclusion: null })).toBe(true); |
| 249 | + expect(isWorkflowRunWaiting({ status: "action_required", conclusion: null })).toBe(true); |
| 250 | + expect(isWorkflowRunWaiting({ status: "completed", conclusion: "action_required" })).toBe(true); |
| 251 | + }); |
| 252 | + |
| 253 | + it("returns false for running, pending, and other completed conclusions", () => { |
| 254 | + expect(isWorkflowRunWaiting({ status: "in_progress", conclusion: null })).toBe(false); |
| 255 | + expect(isWorkflowRunWaiting({ status: "queued", conclusion: null })).toBe(false); |
| 256 | + expect(isWorkflowRunWaiting({ status: "pending", conclusion: null })).toBe(false); |
| 257 | + expect(isWorkflowRunWaiting({ status: "requested", conclusion: null })).toBe(false); |
| 258 | + expect(isWorkflowRunWaiting({ status: "completed", conclusion: "success" })).toBe(false); |
| 259 | + expect(isWorkflowRunWaiting({ status: "completed", conclusion: "failure" })).toBe(false); |
| 260 | + expect(isWorkflowRunWaiting({ status: "completed", conclusion: null })).toBe(false); |
| 261 | + }); |
| 262 | +}); |
| 263 | + |
| 264 | +describe("isWorkflowRunPending", () => { |
| 265 | + it("returns true for queued, pending, and requested statuses", () => { |
| 266 | + expect(isWorkflowRunPending({ status: "queued" })).toBe(true); |
| 267 | + expect(isWorkflowRunPending({ status: "pending" })).toBe(true); |
| 268 | + expect(isWorkflowRunPending({ status: "requested" })).toBe(true); |
| 269 | + }); |
| 270 | + |
| 271 | + it("returns false for running, waiting, action_required, and completed statuses", () => { |
| 272 | + expect(isWorkflowRunPending({ status: "in_progress" })).toBe(false); |
| 273 | + expect(isWorkflowRunPending({ status: "waiting" })).toBe(false); |
| 274 | + expect(isWorkflowRunPending({ status: "action_required" })).toBe(false); |
| 275 | + expect(isWorkflowRunPending({ status: "completed" })).toBe(false); |
| 276 | + }); |
| 277 | +}); |
| 278 | + |
| 279 | +describe("matchesActionsConclusionFilter", () => { |
| 280 | + it("matches all runs when conclusionFilter is 'all'", () => { |
| 281 | + expect(matchesActionsConclusionFilter({ status: "in_progress", conclusion: null }, "all", KNOWN_CONCLUSIONS)).toBe(true); |
| 282 | + expect(matchesActionsConclusionFilter({ status: "waiting", conclusion: null }, "all", KNOWN_CONCLUSIONS)).toBe(true); |
| 283 | + expect(matchesActionsConclusionFilter({ status: "queued", conclusion: null }, "all", KNOWN_CONCLUSIONS)).toBe(true); |
| 284 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "success" }, "all", KNOWN_CONCLUSIONS)).toBe(true); |
| 285 | + }); |
| 286 | + |
| 287 | + it("matches only in_progress runs when conclusionFilter is 'running'", () => { |
| 288 | + expect(matchesActionsConclusionFilter({ status: "in_progress", conclusion: null }, "running", KNOWN_CONCLUSIONS)).toBe(true); |
| 289 | + expect(matchesActionsConclusionFilter({ status: "waiting", conclusion: null }, "running", KNOWN_CONCLUSIONS)).toBe(false); |
| 290 | + expect(matchesActionsConclusionFilter({ status: "queued", conclusion: null }, "running", KNOWN_CONCLUSIONS)).toBe(false); |
| 291 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "success" }, "running", KNOWN_CONCLUSIONS)).toBe(false); |
| 292 | + }); |
| 293 | + |
| 294 | + it("matches waiting and action_required runs when conclusionFilter is 'waiting'", () => { |
| 295 | + expect(matchesActionsConclusionFilter({ status: "waiting", conclusion: null }, "waiting", KNOWN_CONCLUSIONS)).toBe(true); |
| 296 | + expect(matchesActionsConclusionFilter({ status: "action_required", conclusion: null }, "waiting", KNOWN_CONCLUSIONS)).toBe(true); |
| 297 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "action_required" }, "waiting", KNOWN_CONCLUSIONS)).toBe(true); |
| 298 | + expect(matchesActionsConclusionFilter({ status: "in_progress", conclusion: null }, "waiting", KNOWN_CONCLUSIONS)).toBe(false); |
| 299 | + expect(matchesActionsConclusionFilter({ status: "queued", conclusion: null }, "waiting", KNOWN_CONCLUSIONS)).toBe(false); |
| 300 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "failure" }, "waiting", KNOWN_CONCLUSIONS)).toBe(false); |
| 301 | + }); |
| 302 | + |
| 303 | + it("matches queued, pending, and requested runs when conclusionFilter is 'pending'", () => { |
| 304 | + expect(matchesActionsConclusionFilter({ status: "queued", conclusion: null }, "pending", KNOWN_CONCLUSIONS)).toBe(true); |
| 305 | + expect(matchesActionsConclusionFilter({ status: "pending", conclusion: null }, "pending", KNOWN_CONCLUSIONS)).toBe(true); |
| 306 | + expect(matchesActionsConclusionFilter({ status: "requested", conclusion: null }, "pending", KNOWN_CONCLUSIONS)).toBe(true); |
| 307 | + expect(matchesActionsConclusionFilter({ status: "in_progress", conclusion: null }, "pending", KNOWN_CONCLUSIONS)).toBe(false); |
| 308 | + expect(matchesActionsConclusionFilter({ status: "waiting", conclusion: null }, "pending", KNOWN_CONCLUSIONS)).toBe(false); |
| 309 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "success" }, "pending", KNOWN_CONCLUSIONS)).toBe(false); |
| 310 | + }); |
| 311 | + |
| 312 | + it("excludes non-terminal and waiting runs from terminal conclusion filters ('success', 'failure', 'cancelled', 'other')", () => { |
| 313 | + const nonTerminalRuns = [ |
| 314 | + { status: "in_progress", conclusion: "success" }, |
| 315 | + { status: "in_progress", conclusion: "skipped" }, |
| 316 | + { status: "waiting", conclusion: "failure" }, |
| 317 | + { status: "action_required", conclusion: "cancelled" }, |
| 318 | + { status: "completed", conclusion: "action_required" }, |
| 319 | + { status: "queued", conclusion: "success" }, |
| 320 | + { status: "pending", conclusion: "failure" }, |
| 321 | + { status: "requested", conclusion: "skipped" }, |
| 322 | + ]; |
| 323 | + |
| 324 | + for (const run of nonTerminalRuns) { |
| 325 | + expect(matchesActionsConclusionFilter(run, "success", KNOWN_CONCLUSIONS)).toBe(false); |
| 326 | + expect(matchesActionsConclusionFilter(run, "failure", KNOWN_CONCLUSIONS)).toBe(false); |
| 327 | + expect(matchesActionsConclusionFilter(run, "cancelled", KNOWN_CONCLUSIONS)).toBe(false); |
| 328 | + expect(matchesActionsConclusionFilter(run, "other", KNOWN_CONCLUSIONS)).toBe(false); |
| 329 | + } |
| 330 | + }); |
| 331 | + |
| 332 | + it("matches completed runs against exact terminal conclusion filters ('success', 'failure', 'cancelled')", () => { |
| 333 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "success" }, "success", KNOWN_CONCLUSIONS)).toBe(true); |
| 334 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "failure" }, "success", KNOWN_CONCLUSIONS)).toBe(false); |
| 335 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "failure" }, "failure", KNOWN_CONCLUSIONS)).toBe(true); |
| 336 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "cancelled" }, "cancelled", KNOWN_CONCLUSIONS)).toBe(true); |
| 337 | + }); |
| 338 | + |
| 339 | + it("matches completed runs with unknown non-null conclusions under 'other' and excludes KNOWN_CONCLUSIONS including 'action_required'", () => { |
| 340 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "skipped" }, "other", KNOWN_CONCLUSIONS)).toBe(true); |
| 341 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "timed_out" }, "other", KNOWN_CONCLUSIONS)).toBe(true); |
| 342 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "neutral" }, "other", KNOWN_CONCLUSIONS)).toBe(true); |
| 343 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: null }, "other", KNOWN_CONCLUSIONS)).toBe(false); |
| 344 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "success" }, "other", KNOWN_CONCLUSIONS)).toBe(false); |
| 345 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "failure" }, "other", KNOWN_CONCLUSIONS)).toBe(false); |
| 346 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "cancelled" }, "other", KNOWN_CONCLUSIONS)).toBe(false); |
| 347 | + expect(matchesActionsConclusionFilter({ status: "completed", conclusion: "action_required" }, "other", KNOWN_CONCLUSIONS)).toBe(false); |
| 348 | + }); |
| 349 | +}); |
0 commit comments