Skip to content

Commit fbd9eac

Browse files
committed
Do not repeat the screenshot on an open site, and name the checked URL
When a site is open to the world both vantages see the same page, and the exposure section was showing that same screenshot a second time under the one already at the top of the page. It now says the screenshot above is that page and does not repeat it. The exposure section also names the address it checked, the same final URL the screenshot is of, so it is clear which page the posture is about.
1 parent 4a550c7 commit fbd9eac

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

‎app/web/templates/external_site.html‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,15 @@
7070
<div class="card">
7171
<div class="card-head">Exposure
7272
{% if asset.exposure %}<span class="badge {{ {'open':'high','whitelisted':'ok','anomaly':'medium'}.get(asset.exposure,'info') }}">{{ exposures.get(asset.exposure, asset.exposure) }}</span>{% endif %}
73-
{% if asset.exposure_at %}<span class="faint small" style="font-weight:400">, checked {{ asset.exposure_at | dt('%Y-%m-%d %H:%M') }}</span>{% endif %}</div>
73+
<span class="faint small" style="font-weight:400">{{ tele.final_url or ('https://' ~ asset.host ~ '/') }}{% if asset.exposure_at %}, checked {{ asset.exposure_at | dt('%Y-%m-%d %H:%M') }}{% endif %}</span></div>
7474
<div class="card-body">
7575
{% if asset.exposure_detail %}<p class="small">{{ asset.exposure_detail }}</p>{% endif %}
7676
{% set wl_is_direct = whitelisted_vantage != 'proxy' %}
7777
{% set direct_has = asset.screenshot in ('ok', 'blank') or (asset.screenshot == 'waf' and has_shot) %}
7878
{% set direct_img = base ~ '/external/' ~ asset.id ~ '/screenshot.png?v=' ~ (asset.telemetry_at.timestamp() | int if asset.telemetry_at else 0) %}
7979
{% set proxy_img = base ~ '/external/' ~ asset.id ~ '/screenshot-proxy.png?v=' ~ (asset.exposure_at.timestamp() | int if asset.exposure_at else 0) %}
8080
{% if asset.exposure == 'open' %}
81-
<div class="small faint" style="margin-bottom:.3rem">Both the allow listed and the public vantage see the same page, so it is shown once.</div>
82-
{% if direct_has %}<img class="shot-small" alt="Screenshot of {{ asset.host }}" src="{{ direct_img }}">{% endif %}
81+
<div class="small faint">Both the allow listed and the public vantage reach the same page, so the screenshot above is that page. It is not shown again here.</div>
8382
{% elif asset.exposure in ('whitelisted', 'anomaly') %}
8483
{% set wl_img = direct_img if wl_is_direct else proxy_img %}
8584
{% set wl_has = direct_has if wl_is_direct else has_proxy_shot %}

0 commit comments

Comments
 (0)