From cef5d4ad34802a183d174fb9778852b4134bf7a4 Mon Sep 17 00:00:00 2001 From: "Sodhi, Vunny" Date: Thu, 24 Sep 2026 10:58:09 +0800 Subject: [PATCH] media: intel: ipu7: isys: raise FRAME DROP log level to warn_ratelimited When the firmware reports a capture sync frame drop (INSYS_MSG_ERR_GROUP_CAPTURE / INSYS_MSG_ERR_CAPTURE_SYNC_FRAME_DROP), the driver currently logs the event via dev_dbg(). Because dev_dbg() is compiled out unless CONFIG_DYNAMIC_DEBUG or DEBUG is enabled, real frame drops silently disappear from dmesg on production builds, making capture pipeline issues hard to diagnose from field logs. Promote the three FRAME DROP dev_dbg() calls to dev_warn_ratelimited() so that drops are always surfaced in dmesg while preventing log floods when many frames are dropped in a burst across pins or streams. Signed-off-by: Sodhi, Vunny --- drivers/media/pci/intel/ipu7/ipu7-isys.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/drivers/media/pci/intel/ipu7/ipu7-isys.c b/drivers/media/pci/intel/ipu7/ipu7-isys.c index 8b0f0c3..f6e79d2 100644 --- a/drivers/media/pci/intel/ipu7/ipu7-isys.c +++ b/drivers/media/pci/intel/ipu7/ipu7-isys.c @@ -1344,14 +1344,17 @@ int isys_isr_one(struct ipu7_bus_device *adev) if (err_info.err_group == INSYS_MSG_ERR_GROUP_CAPTURE && err_info.err_code == INSYS_MSG_ERR_CAPTURE_SYNC_FRAME_DROP) { /* receive a sp w/o command, firmware drop it */ - dev_dbg(dev, "FRAME DROP: %02u %s stream %u\n", - resp->type, is_fw_msg[resp->type].msg, - resp->stream_id); - dev_dbg(dev, "\tpin %u buf_id %llx frame %u\n", - resp->pin_id, resp->buf_id, resp->frame_id); - dev_dbg(dev, "\terror group %u code %u details [%u %u]\n", - err_info.err_group, err_info.err_code, - err_info.err_detail[0], err_info.err_detail[1]); + dev_warn_ratelimited(dev, "FRAME DROP: %02u %s stream %u\n", + resp->type, is_fw_msg[resp->type].msg, + resp->stream_id); + dev_warn_ratelimited(dev, "\tpin %u buf_id %llx frame %u\n", + resp->pin_id, resp->buf_id, + resp->frame_id); + dev_warn_ratelimited(dev, + "\terror group %u code %u details [%u %u]\n", + err_info.err_group, err_info.err_code, + err_info.err_detail[0], + err_info.err_detail[1]); } else if (!IA_GOFO_MSG_ERR_IS_OK(err_info)) { dev_err(dev, "%02u %s stream %u pin %u buf_id %llx frame %u\n", resp->type, is_fw_msg[resp->type].msg, resp->stream_id,