chore: adopt StandardRB for lib/ + auto-fix 953 violations

- Add 'standard' gem + .standard.yml (lib/ only; spec/bin/exe ignored)
- Auto-fix 953 -> 23 remaining violations (mostly regexp_converter.rb
  and visualize/*.rb; need manual review)
- Add StandardRB job to rake.yml CI

Author: ronaldtse

.github/workflows/rake.yml

@@ -44,3 +44,14 @@ jobs:
       - name: RSpec
         working-directory: ruby
         run: bundle exec rspec
+
+  standard:
+    name: StandardRB
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v7
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: "3.4"
+          bundler-cache: true
+      - run: bundle exec standardrb

.standard.yml

@@ -0,0 +1,11 @@
+# StandardRB config — enforce Ruby style on lib/, leave specs/bin/exe flexible for now.
+# Existing violations in lib/ were auto-fixed in this PR; remaining violations are
+# tracked in TODO.complete/06-standardrb-ruby-gems.md.
+ignore:
+  - "bin/**/*"
+  - "exe/**/*"
+  - "spec/**/*"
+  - "docs/**/*"
+  - "reference-docs/**/*"
+  - "pkg/**/*"
+  - "vendor/**/*"

Gemfile

@@ -38,3 +38,4 @@ gem "iso-639-data"
 gem "iso-15924"
 
 gem "simplecov", require: false, group: :test
+gem "standard", group: :development, require: false

Rakefile

@@ -25,15 +25,15 @@ task :compile, [:compiler, :target] do |t, args|
 
   maps = Interscript.maps
   maps = Interscript.exclude_maps(maps, compiler: compiler, platform: false)
-  
+
   maps.each do |map|
-    code = compiler.(map).code
+    code = compiler.call(map).code
     File.write(args[:target] + "/" + map + "." + ext, code)
     maplist[map] = nil
   end
 
   Interscript.maps(libraries: true).each do |map|
-    code = compiler.(map).code
+    code = compiler.call(map).code
     File.write(args[:target] + "/" + map + "." + ext, code)
   end
 
@@ -45,12 +45,12 @@ task :generate_visualization_html do
   require "interscript"
   require "interscript/visualize"
 
-  FileUtils.rm_rf(dir = __dir__+"/visualizations/")
+  FileUtils.rm_rf(dir = __dir__ + "/visualizations/")
   FileUtils.mkdir_p(dir)
 
   Interscript.maps.each do |map|
-    html = Interscript::Visualize.(map)
-    File.write(dir+map+".html", html)
+    html = Interscript::Visualize.call(map)
+    File.write(dir + map + ".html", html)
   end
 end
 
@@ -60,16 +60,15 @@ task :generate_metadata_json do
   require "interscript"
   require "interscript/compiler/javascript"
 
-  FileUtils.rm_rf(file = __dir__+"/metadata.json")
+  FileUtils.rm_rf(file = __dir__ + "/metadata.json")
 
   hash = Interscript.maps.map do |map|
     parsed_map = Interscript.parse(map)
     md = parsed_map.metadata.to_hash
     md["test"] = parsed_map.tests&.data&.first
     md["skip_js"] = Interscript.exclude_maps([map],
-                      compiler: Interscript::Compiler::Javascript,
-                      platform: false,
-                    ).empty?
+      compiler: Interscript::Compiler::Javascript,
+      platform: false).empty?
     [map, md]
   end.to_h
 
@@ -81,12 +80,12 @@ task :generate_json do
   require "json"
   require "interscript"
 
-  FileUtils.rm_rf(dir = __dir__+"/json/")
+  FileUtils.rm_rf(dir = __dir__ + "/json/")
   FileUtils.mkdir_p(dir)
 
   (Interscript.maps + Interscript.maps(libraries: true)).each do |map|
     json = JSON.pretty_generate(Interscript.parse(map).to_hash)
-    File.write(dir+map+".json", json)
+    File.write(dir + map + ".json", json)
   end
 end
 
@@ -96,14 +95,14 @@ task :generate_visualization_json do
   require "json"
   require "interscript/visualize"
 
-  FileUtils.rm_rf(dir = __dir__+"/vis_json/")
+  FileUtils.rm_rf(dir = __dir__ + "/vis_json/")
   FileUtils.mkdir_p(dir)
 
   (Interscript.maps + Interscript.maps(libraries: true)).each do |map_name|
     map = Interscript.parse(map_name)
     map.stages.each do |stage_name, stage|
       json = JSON.pretty_generate(stage.to_visualization_array(map))
-      File.write(dir+map_name+"_#{stage_name}.json", json)
+      File.write(dir + map_name + "_#{stage_name}.json", json)
     end
   end
 end
@@ -113,7 +112,7 @@ task :generate_authority_json do
   require "json"
   require "iso-639-data"
 
-  FileUtils.rm_rf(dir = __dir__+"/auth_json/")
+  FileUtils.rm_rf(dir = __dir__ + "/auth_json/")
   FileUtils.mkdir_p(dir)
 
   %w[iso icao din].each do |auth|
@@ -122,10 +121,10 @@ task :generate_authority_json do
     end.sort.map do |map_name|
       map = Interscript.parse(map_name)
       tests = map.tests&.data&.first(2)&.transpose || []
-      std, lang = map.metadata.data[:language].split(':')
+      std, lang = map.metadata.data[:language].split(":")
 
       {
-        lang: std.end_with?("-3") ? Iso639Data.iso_639_3[lang]['Ref_Name'] : Iso639Data.iso_639_2[lang]['eng'],
+        lang: std.end_with?("-3") ? Iso639Data.iso_639_3[lang]["Ref_Name"] : Iso639Data.iso_639_2[lang]["eng"],
         isoName: map.metadata.data[:name],
         systemName: map_name,
         samples: tests[0] || [],
@@ -135,8 +134,8 @@ task :generate_authority_json do
     end
 
     json = JSON.pretty_generate(out)
-    File.write(dir+auth+".json", json)
+    File.write(dir + auth + ".json", json)
   end
 end
 
-task :default => :spec
+task default: :spec

interscript.gemspec

@@ -1,21 +1,21 @@
 require_relative "lib/interscript/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "interscript"
-  spec.version       = Interscript::VERSION
-  spec.summary       = "Interoperable script conversion systems"
-  spec.description   = "Interoperable script conversion systems."
-  spec.authors       = ["Ribose Inc."]
-  spec.email         = ["open.source@ribose.com"]
+  spec.name = "interscript"
+  spec.version = Interscript::VERSION
+  spec.summary = "Interoperable script conversion systems"
+  spec.description = "Interoperable script conversion systems."
+  spec.authors = ["Ribose Inc."]
+  spec.email = ["open.source@ribose.com"]
 
-  spec.homepage      = "https://www.interscript.com"
-  spec.license       = "BSD-2-Clause"
+  spec.homepage = "https://www.interscript.com"
+  spec.license = "BSD-2-Clause"
   spec.required_ruby_version = ">= 3.3.0"
 
-  spec.metadata["homepage_uri"]         = spec.homepage
-  spec.metadata["source_code_uri"]      = "https://github.com/interscript/interscript-ruby"
-  spec.metadata["changelog_uri"]        = "https://github.com/interscript/interscript-ruby/releases"
-  spec.metadata["bug_tracker_uri"]      = "https://github.com/interscript/interscript-ruby/issues"
+  spec.metadata["homepage_uri"] = spec.homepage
+  spec.metadata["source_code_uri"] = "https://github.com/interscript/interscript-ruby"
+  spec.metadata["changelog_uri"] = "https://github.com/interscript/interscript-ruby/releases"
+  spec.metadata["bug_tracker_uri"] = "https://github.com/interscript/interscript-ruby/issues"
   spec.metadata["rubygems_mfa_required"] = "true"
 
   spec.files = Dir.chdir(__dir__) do
@@ -28,11 +28,11 @@ Gem::Specification.new do |spec|
       "*.gemspec"
     ].select { |f| File.file?(f) }
   end
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
+  spec.bindir = "exe"
+  spec.executables = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_dependency "thor"
-  spec.add_dependency "interscript-maps", "~> #{Interscript::VERSION.split('.')[0, 2].join(".")}.0a"
+  spec.add_dependency "interscript-maps", "~> #{Interscript::VERSION.split(".")[0, 2].join(".")}.0a"
   spec.add_dependency "text"
 end

lib/interscript.rb

@@ -13,7 +13,7 @@ class MapLogicError < StandardError; end
 
   class << self
     def load_path
-      @load_path ||= ['.', *Interscript.map_locations]
+      @load_path ||= [".", *Interscript.map_locations]
     end
 
     def locate map_name
@@ -33,26 +33,26 @@ def parse(map_name)
       Interscript::DSL.parse(map_name)
     end
 
-    def load(system_code, maps={}, compiler: Interscript::Interpreter)
-      maps[[system_code, compiler.name]] ||= compiler.(system_code)
+    def load(system_code, maps = {}, compiler: Interscript::Interpreter)
+      maps[[system_code, compiler.name]] ||= compiler.call(system_code)
     end
 
     # Transliterates the string.
-    def transliterate(system_code, string, maps={}, compiler: Interscript::Interpreter)
+    def transliterate(system_code, string, maps = {}, compiler: Interscript::Interpreter)
       # The current best implementation is Interpreter
-      load(system_code, maps, compiler: compiler).(string)
+      load(system_code, maps, compiler: compiler).call(string)
     end
 
     # Gives each possible value of the transliteration.
-    def transliterate_each(system_code, string, maps={}, &block)
-      load(system_code, maps).(string, each: true, &block)
+    def transliterate_each(system_code, string, maps = {}, &block)
+      load(system_code, maps).call(string, each: true, &block)
     end
 
-    def transliterate_file(system_code, input_file, output_file, maps={}, compiler: Interscript::Interpreter)
+    def transliterate_file(system_code, input_file, output_file, maps = {}, compiler: Interscript::Interpreter)
       input = File.read(input_file)
       output = transliterate(system_code, input, maps, compiler: compiler)
 
-      File.open(output_file, 'w') do |f|
+      File.open(output_file, "w") do |f|
         f.puts(output)
       end
 
@@ -67,17 +67,17 @@ def transliterate_file(system_code, input_file, output_file, maps={}, compiler:
     def detect(source, destination, **kwargs)
       detector = Detector.new
       detector.set_from_kwargs(**kwargs)
-      detector.(source, destination)
+      detector.call(source, destination)
     end
 
     def map_gems
-      @map_gems ||= Gem.find_latest_files('interscript-maps.yaml').map do |i|
+      @map_gems ||= Gem.find_latest_files("interscript-maps.yaml").map do |i|
         [i, YAML.load_file(i)]
       end.to_h
     end
 
     def map_locations
-      @map_locations ||= map_gems.map do |i,v|
+      @map_locations ||= map_gems.map do |i, v|
         paths = v["paths"].dup
         paths += v["staging"] if ENV["INTERSCRIPT_STAGING"] && v["staging"]
 
@@ -88,24 +88,24 @@ def map_locations
     end
 
     def secryst_index_locations
-      @secryst_index_locations ||= map_gems.map do |i,v|
+      @secryst_index_locations ||= map_gems.map do |i, v|
         v["secryst-models"]
       end.compact.flatten
     end
 
     def rababa_configs
-      @rababa_configs ||= map_gems.map do |i,v|
+      @rababa_configs ||= map_gems.map do |i, v|
         v["rababa-configs"]
-      end.compact.inject({}) do |a,b|
+      end.compact.inject({}) do |a, b|
         a.merge(b)
       end
     end
 
     # This code is borrowed from Secryst and should end up in Rababa, but for now,
     # let's keep it here.
     def rababa_provision(model_name, model_uri)
-      require 'fileutils'
-      require 'open-uri'
+      require "fileutils"
+      require "open-uri"
 
       # We provision the environment in the following way:
       # First, we try the RABABA_DATA environment variable. If that's available,
@@ -129,26 +129,26 @@ def rababa_provision(model_name, model_uri)
         break
       rescue
       end
-  
+
       raise ExternalUtilError, "Can't find a writable path for Rababa. Consider setting a RABABA_DATA environment variable" unless write_path
 
       model_path = "#{write_path}/model-#{model_name}.onnx"
 
       # Redownload every hour
       if File.exist?(model_path) && File.mtime(model_path) + 3600 >= Time.now
-        return model_path
+        model_path
       else
         data = URI.open(model_uri, encoding: "BINARY").read
         File.binwrite(model_path, data)
-        return model_path
+        model_path
       end
     end
 
     def map_aliases
       return @map_aliases if @map_aliases
 
       @map_aliases = {}
-      map_gems.each do |i,v|
+      map_gems.each do |i, v|
         (v["aliases"] || {}).each do |code, value|
           value.each do |al, map|
             @map_aliases[al] = map["alias_to"]
@@ -172,9 +172,9 @@ def maps(basename: true, load_path: false, select: "*", libraries: false)
     # To be used by tests
     # and builders. It uses the `skip` directive in interscript-maps.yaml
     def exclude_maps(maps, compiler:, platform: true)
-      map_gems.each do |i,v|
+      map_gems.each do |i, v|
         [compiler.name, (Gem::Platform.local.os if platform)].compact.each do |name|
-          skips = v.dig('skip', name) || []
+          skips = v.dig("skip", name) || []
           skips.each do |skip|
             skip_re = /#{Regexp.escape(skip).gsub("\\*", ".*?")}/
             maps = maps.grep_v(skip_re)
@@ -186,12 +186,12 @@ def exclude_maps(maps, compiler:, platform: true)
   end
 end
 
-require 'interscript/stdlib'
+require "interscript/stdlib"
 
 require "interscript/compiler"
 require "interscript/interpreter"
 
-require 'interscript/dsl'
-require 'interscript/node'
+require "interscript/dsl"
+require "interscript/node"
 
-require 'interscript/detector'
+require "interscript/detector"