From 215cd95b3f5297787a2ce9fb25f14c8b7e4c5abc Mon Sep 17 00:00:00 2001 From: Matthew Podwysocki Date: Fri, 25 Sep 2026 11:28:09 -0400 Subject: [PATCH] Fix a stale comment in install.ps1 about Arm64 Windows having no native build install.ps1's arm64/x64 fallback logic already preferred a native aarch64-pc-windows-msvc build over the emulated x64 one; the comment above it still said Arm64 Windows "has no build of its own yet", written before the native build existed. Now that the build matrix ships it, the comment described a state that no longer holds. Reported in review of the build-matrix change as a good independent follow-up here. Co-Authored-By: Claude Sonnet 5 --- scripts/install.ps1 | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/scripts/install.ps1 b/scripts/install.ps1 index 9734a2f..e5c7663 100644 --- a/scripts/install.ps1 +++ b/scripts/install.ps1 @@ -295,10 +295,9 @@ Or point this copy at one: if (-not $arch) { $arch = $env:PROCESSOR_ARCHITECTURE } if (-not $arch) { $arch = 'an unnamed architecture' } - # In preference order. Arm64 Windows has no build of its own yet, and runs - # the x64 one under emulation; listing both means the day a native - # aarch64-pc-windows-msvc appears in the manifest, this picks it up with no - # change here. + # In preference order. Arm64 Windows has a native aarch64-pc-windows-msvc + # build; the x64 one is the fallback for a manifest that hasn't published + # it yet (an older pinned version, say), which runs under emulation. $candidates = @() switch ($arch) { 'AMD64' { $candidates = @('x86_64-pc-windows-msvc') }