Skip to content

Commit 3eacb67

Browse files
authored
Merge pull request #13 from iccir/fix-usernames
Always use GitHub usernames with `@`
2 parents a99a4a5 + 40ca606 commit 3eacb67

94 files changed

Lines changed: 461 additions & 462 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

meeting_notes/2018/2018_03_mar.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
- Antony, Hannah, Ryan, Jody
1010

11-
- [ ] DateFormatter and Locator @Jody K
11+
- [ ] DateFormatter and Locator @jklymak
1212
Do we want to update the default locator and ticks or just provide another Formatter option for savvy users?
1313
- https://github.com/matplotlib/matplotlib/pull/10841
1414
- https://github.com/matplotlib/matplotlib/pull/9801
@@ -46,7 +46,7 @@
4646
- General agreement formatter:
4747
- needs way to get old beghaviour
4848
- useful for teaching/default
49-
- @Antony L suggested naming convention
49+
- @anntzer suggested naming convention
5050
- MPLxyDateFormatter
5151
- Alias AutoFormatter to current MPLXYDateFormatter
5252
- Document “We reserve right to change formatter”

meeting_notes/2018/2018_04_apr.md

Lines changed: 51 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
## Notes
1515

16-
### MEP about MEP? ** @Thomas C will do book keeping tasks**
16+
### MEP about MEP? ** @tacaswell will do book keeping tasks**
1717

1818
- When to write a MEP?
1919
- proposing controversial features,
@@ -34,13 +34,13 @@
3434
1. do a small PR that adds your MEP to the master list (in https://matplotlib.org/devdocs/devel/MEP/index.html),
3535
2. have another PR with the actual discussion. Helps avoiding conflicting numbers.
3636

37-
**Need text/followup from** @Thomas C **on**
37+
**Need text/followup from** @tacaswell **on**
3838

3939
- [x] summer student
4040
- [x] documentation summit
4141

4242

43-
### Tick Refactor ** @Tim H **
43+
### Tick Refactor ** @timhoffm **
4444

4545
- target 3.1
4646
- MEP?
@@ -54,7 +54,7 @@
5454
- public api that predates __ convention
5555
- are ticks markers or line collections or something else?
5656
- gridlines are line collections/single broken line
57-
- @Antony L sketch: https://github.com/anntzer/matplotlib/tree/_wip/newaxis
57+
- @anntzer sketch: https://github.com/anntzer/matplotlib/tree/_wip/newaxis
5858
- how does it work with projections?
5959
- straight line in proj space or data space
6060
- rader plots wants straight
@@ -70,7 +70,7 @@
7070

7171
- text rendering may be slow because of rasterization of individual glyphs, but should be profiled
7272
- might be good for completeness/API reasons
73-
- @Ryan M scattertext WIP: https://github.com/matplotlib/matplotlib/pull/4063
73+
- @dopplershift scattertext WIP: https://github.com/matplotlib/matplotlib/pull/4063
7474
- needs colormapping
7575
- marker, patch and polycollection
7676
- marker codepath/ in draw path:
@@ -85,7 +85,7 @@
8585

8686
# April 9, 2018
8787

88-
@Ryan M , @Jody K @Eric F @Thomas C , @hannah a
88+
@dopplershift @jklymak @efiring @tacaswell @story645
8989

9090

9191
- [x] inset_axes and extra_spine_x/extra_spine_y into main library.
@@ -101,15 +101,15 @@
101101

102102
### Inset_axes/spine tick stuff
103103

104-
- @Eric F spend time over the weekend reading through how tick code actually works and took notes.
105-
- @Jody K Currently we don’t have a notion of ‘nested’ axes, but that it would make sense to have ‘child’ axes that is follows the parent. Thinking of these following axes an decorations on the parent axes (like legend)
106-
- @Eric F summary of history of axes_grid and friends
104+
- @efiring spend time over the weekend reading through how tick code actually works and took notes.
105+
- @jklymak Currently we don’t have a notion of ‘nested’ axes, but that it would make sense to have ‘child’ axes that is follows the parent. Thinking of these following axes an decorations on the parent axes (like legend)
106+
- @efiring summary of history of axes_grid and friends
107107
- discussion of what parts of axes_grid we can move up into the ‘mainline’ of the codebase
108-
- @Eric F - refactor and better document code to reduce technical debt?
109-
- @Eric F Cleaning up current ticker might be worth doing before we do whole-sale re-write
110-
- @Eric F suggests that we accept more breakage of edge-case APIs for improved consistency,
108+
- @efiring - refactor and better document code to reduce technical debt?
109+
- @efiring Cleaning up current ticker might be worth doing before we do whole-sale re-write
110+
- @efiring suggests that we accept more breakage of edge-case APIs for improved consistency,
111111
- trade off: replacing more complex with simpler 👍 , complex with complex 👎
112-
- @Thomas C sold on:
112+
- @tacaswell sold on:
113113
- axes_inset as children of parent axes
114114
- more thought on axis children objects
115115
- different x spine/multiple x spines
@@ -131,7 +131,7 @@
131131
- add tutorial section for developers
132132
- https://github.com/matplotlib/matplotlib/pull/10947
133133
- Notes in progress?
134-
- @Antony L suggested the wiki
134+
- @anntzer suggested the wiki
135135
- **Consensus** https://github.com/orgs/matplotlib/teams/developers
136136

137137
### Perez:
@@ -142,30 +142,30 @@
142142

143143
- Find out who has push on it
144144
- using it to standardize workflow across communities
145-
- @Antony L suggesting we just link to central gitwash instead of bothering with templating
146-
- @Tim H https://github.com/matplotlib/matplotlib/pull/10997
145+
- @anntzer suggesting we just link to central gitwash instead of bothering with templating
146+
- @timhoffm https://github.com/matplotlib/matplotlib/pull/10997
147147

148148
### Mailing list:
149149

150-
- @Jody K suggest automatic reply on rejected posts saying you have to join to post to the list
150+
- @jklymak suggest automatic reply on rejected posts saying you have to join to post to the list
151151

152152
### Tool manager:
153153

154154
- https://github.com/matplotlib/matplotlib/pull/9022
155-
- @Antony L - good idea but ToolBarManager should be moved out of core
156-
- @Thomas C can’t be moved out ‘cause too coupled with GUI backends
157-
- @Jody K why ToolBarManager?
158-
- @Thomas C makes toolbar modular -can just add buttons for things like zoom and lasso
159-
- @Antony L adding buttons using homebuilt widget system → tool bar manager → write full blown QT GUI
160-
- @Antony L wants to know if it will be the full blown default or another axis_grid
155+
- @anntzer - good idea but ToolBarManager should be moved out of core
156+
- @tacaswell can’t be moved out ‘cause too coupled with GUI backends
157+
- @jklymak why ToolBarManager?
158+
- @tacaswell makes toolbar modular -can just add buttons for things like zoom and lasso
159+
- @anntzer adding buttons using homebuilt widget system → tool bar manager → write full blown QT GUI
160+
- @anntzer wants to know if it will be the full blown default or another axis_grid
161161
- backends: everything except WX (which is in PR)
162162
- goal for 3, default in 3.1
163163

164164
---
165165

166166
# April 16, 2018
167167

168-
@Eric F, @Ryan M, @Thomas C, @hannah a, @Antony L
168+
@efiring, @dopplershift, @tacaswell, @story645, @anntzer
169169

170170
- Documentation Summit: Who wants to come? (And where are you located?)
171171
- PRs:
@@ -177,17 +177,17 @@
177177

178178
- imshow Python refactor:
179179
- agg interpolation
180-
- 11027 - @Thomas C
180+
- 11027 - @tacaswell
181181
- Add one more dial to automatic spacing based on font size
182182
- assuming x axis tick labels are wider than y axis - more ticks on y than x
183183
- wants algorithm to factor in when x is smaller - dynamic guessing of xtick size
184184
- adding unnecessary? complexity
185-
- @Ryan M - subclass locator, make it first class citizen in library
186-
- @Antony L monkey patch axis api:
185+
- @dopplershift - subclass locator, make it first class citizen in library
186+
- @anntzer monkey patch axis api:
187187
- add public API to replace methods
188188
- tell user to subclass locator - have subclassing API
189189
- set default axes for axis
190-
- @Eric F generalize API to accomplish same by making two new parameters:
190+
- @efiring generalize API to accomplish same by making two new parameters:
191191
- x tick label size/ y tick label size - access to these properties
192192
- trying to estimate how large tick will be in axis dimension (based on character width and height, not fontsize)
193193
- Public API change to locator:
@@ -198,30 +198,30 @@
198198
- fontsize in points
199199
- locator can get axis object for axis names (x or y)
200200
- need easy way to subclass locators instead of having to subclass axis
201-
- 11048 - @Thomas C
201+
- 11048 - @tacaswell
202202
- move bar grouping out of hist into its own thing so that it can be a shared private function
203203
- add a plt.multibar/groupedbar to support multiple bars that can call bar underneath the hood
204204
- can prune some of the features of bar: no bottom, no alignment,
205205
- grouping - by variable (y) or by x(category)
206206
- API design with no implementation first + how it’d be used by refactored hist
207207
- follow plot and pandas semantics with respect to broadcasting x to y: each column is a dataseries/variable
208208
- replace some of histograms logic with a call to multibar
209-
- @Eric F create a hierarchy of how the plots build on top of each other
209+
- @efiring create a hierarchy of how the plots build on top of each other
210210
- bar charts x tick labels should probably be fixedlocator/fixedformatter by default
211211
- 11055
212-
- @Antony L easy to restore, unclear what it does, doesn’t think it works
213-
- @Ryan M conda-forge testing branch makes setup_cfg use the local freetype
212+
- @anntzer easy to restore, unclear what it does, doesn’t think it works
213+
- @dopplershift conda-forge testing branch makes setup_cfg use the local freetype
214214
- use case: conda looks up listed packages, so you can run only the tests and install the test data, can check all the files that were installed and say “that’s my package” which is a test only package that only contains test results
215215
- newer versions of conda build can generate multiple packages out of one recipe
216216
- pitch it back to conda unless they ask about it?
217217
- [+Documentation summit](https://paper.dropbox.com/doc/Documentation-summit-3HkbTDvrztZbmIm6wsC0B)
218218
- Late Summer/Early Fall - 2-3 days
219219
- Manning people want long form narrative explaining step by step
220220
- thoughts
221-
- @Eric F - summer is better than fall (mid august)
222-
- @Antony L - intermediate level docs (step function in documentation)
221+
- @efiring - summer is better than fall (mid august)
222+
- @anntzer - intermediate level docs (step function in documentation)
223223
- does this already exist?
224-
- defining what is intermediate? - @Antony L what is Python? what is matplotlib?
224+
- defining what is intermediate? - @anntzer what is Python? what is matplotlib?
225225
- https://mail.python.org/pipermail/matplotlib-devel/2018-March/001033.html
226226

227227
---
@@ -232,7 +232,7 @@
232232

233233
## Agenda:
234234
- bbox issues: @jklymak:
235-
`ax.get_tightbbox()` now includes legends as of #9164 (and #10682 proposes making it that way for *all* artists). But that is sometimes bad if the user has stuck the legend far from the axes (i.e. #11041). @ImportanceOfBeingEearnest brought up the idea of having a flag attached to an artist that says whether it should be part of get_tightbbox, so users can turn it on/off on an as-needed basis.
235+
`ax.get_tightbbox()` now includes legends as of #9164 (and #10682 proposes making it that way for *all* artists). But that is sometimes bad if the user has stuck the legend far from the axes (i.e. #11041). @ImportanceOfBeingErnest brought up the idea of having a flag attached to an artist that says whether it should be part of get_tightbbox, so users can turn it on/off on an as-needed basis.
236236
- https://github.com/matplotlib/matplotlib/issues/9130, https://github.com/matplotlib/matplotlib/pull/9164, https://github.com/matplotlib/matplotlib/pull/10682, https://github.com/matplotlib/matplotlib/issues/11041
237237
- inset_axes API:
238238
- https://github.com/matplotlib/matplotlib/pull/11026
@@ -249,40 +249,40 @@
249249
- used in tight and constraint layout
250250
- artist property set to true by default, could be set to false by default
251251
- should all artists be part of tight box? do we need method of exclusion?
252-
- @Eric F flag is low barrier, but is there enough use case?
252+
- @efiring flag is low barrier, but is there enough use case?
253253
- current: legend based on bbox_to_anchor argument against existing axes
254254
- proposed exclusion methods:
255255
- method on artist: legend.exclude for bbox
256256
- kwarg to `constraint_layout`?
257257
- alternatives for legends:
258258
- attach legend to its own axes and use that bbox
259-
- @use fig.legend + bbox transform
260-
- @Jody K To Do: add exclusion flag
261-
- @Eric F move automatic gathering of handles, labels into axes methods
259+
- use fig.legend + bbox transform
260+
- @jklymak To Do: add exclusion flag
261+
- @efiring move automatic gathering of handles, labels into axes methods
262262
- do axes composition: axes.get_legend_entries in fig.axes
263263
- feed sum(handles, labels) into fig.legend()
264264

265265
### inset_axis
266266

267267
- child axes
268-
- @Eric F want to preserve hierarchy/ composition
269-
- @Jody K needed for tight_layout/constrained_layout
268+
- @efiring want to preserve hierarchy/ composition
269+
- @jklymak needed for tight_layout/constrained_layout
270270
- tension w/ preserving axesgrid api:
271271
- axesgrid is poorly documented
272272
- multiple apis for add_inset:
273273
- manual, specify the box for the inset axis
274274
- loc based but needs height+width
275275
- padding?
276276
- handled w/ uniform shrink (like colorbar)
277-
- pad in terms of physical units? @Jody K??
278-
- @Eric F : Start with simple api
277+
- pad in terms of physical units? @jklymak??
278+
- @efiring : Start with simple api
279279
- specify rectangle and transform
280-
- @Jody K add_inset_rect + pad
280+
- @jklymak add_inset_rect + pad
281281
- specify pad in physical units
282282

283283
### API inconsistencies
284284

285-
- @Eric F: importance of being earnest mentions inconsistency between text (x, y, text) and annotate takes (text, (x,y))
285+
- @efiring: importance of being earnest mentions inconsistency between text (x, y, text) and annotate takes (text, (x,y))
286286
- keep track of inconsistencies?
287287
- shift to a more uniform standard?
288288
- how to tabulate?
@@ -298,7 +298,7 @@
298298

299299
# April 30, 2018
300300

301-
@Eric F @Jody K @Thomas C @paul h @hannah a
301+
@efiring @jklymak @tacaswell @phobson @story645
302302

303303
## Agenda:
304304
- py3 transition:
@@ -309,20 +309,20 @@
309309

310310
PY3 transition.
311311

312-
- @Thomas C wants to stand by the backport criteria (critical bugs and regressions), other backports need a champion.
312+
- @tacaswell wants to stand by the backport criteria (critical bugs and regressions), other backports need a champion.
313313
- 2.2.2 doc branch should only get changes to the .rst file, won’t see changes .py because of how docs are built
314314

315315
UpdateL bbox issues
316316

317317
- `artist.inbbox` flag - property on artist:
318318
- when tight_layout does calculation, ignores everything set to False
319319
- pro: explicit listing of elements in bbox
320-
- con: @Eric F unintended consequences like possible performance issues?
320+
- con: @efiring unintended consequences like possible performance issues?
321321
- does everything need to be explicitly white/blacklisted?
322322
- goal for constraint layout to maybe be default?
323323
- GUIs need to be resized and so on the fly layout
324-
- @paul h suggests doing some benchmarks to see if performance is an issue
325-
- @Thomas C what else could we use this flag for? semantic content of “I want this artist included in the bbox” - tight layout, constrained layout
324+
- @phobson suggests doing some benchmarks to see if performance is an issue
325+
- @tacaswell what else could we use this flag for? semantic content of “I want this artist included in the bbox” - tight layout, constrained layout
326326
- sticky edge - when you change autoscaling to non-tight, but some artists need tight like imshow:
327327
- draw circle on image, will recognize that image wants tight
328328
- if circle>image, adds pad

meeting_notes/2018/2018_05_may.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
# May 7, 2018
88

9-
@Jody K @Eric F @hannah a @Thomas C
9+
@jklymak @efiring @story645 @tacaswell
1010

1111
## Agenda
1212

@@ -31,7 +31,7 @@
3131

3232
- str same as repr is fine? Best practice? `__repr__` shorter….
3333

34-
### Unit property of Axis: ** attn @Ryan M **
34+
### Unit property of Axis: ** attn @dopplershift **
3535

3636
- go back to using different attribute to store mapping
3737
- create attribute on unit that stores ordering string - unit.unit =
@@ -44,7 +44,7 @@
4444
- kwarg unit - was stored in ax.unit, now clobbered my datatype unit
4545
- datatype - _unit
4646
- should axis support floats even when locked?
47-
- @Jody K let the convertor decide
47+
- @jklymak let the convertor decide
4848
- internal data abstraction @tacaswell
4949
- data objects attached to artist…
5050
- adaptive re-sampling
@@ -59,7 +59,7 @@
5959

6060
# May 14, 2018
6161

62-
@Jody K @Eric F @Antony L @Thomas C @hannah a
62+
@jklymak @efiring @anntzer @tacaswell @story645
6363

6464
## Agenda
6565
- 2.2.3? https://github.com/matplotlib/matplotlib/milestone/34
@@ -83,7 +83,7 @@
8383
- in sdist, but not repo; download at download time? Download sdist, not tarball
8484
- from pypi will be OK not GitHub for a single tar file
8585
- follow jupyter’s methodology
86-
- @Antony L in next month or so?
86+
- @anntzer in next month or so?
8787

8888
### Scipy dependency
8989

@@ -98,7 +98,7 @@
9898

9999
- good idea, parallels version on contours
100100
- concern that PathCollection used for other things
101-
- maybe add a ScatterAritist which is a subsclass of PathCollecion which adds this method (+ would help @Antony L with mpl cursor)
101+
- maybe add a ScatterAritist which is a subsclass of PathCollecion which adds this method (+ would help @anntzer with mpl cursor)
102102
- https://github.com/networkx/grave/blob/master/grave/grave.py#L221
103103

104104
---

meeting_notes/2018/2018_06_jun.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
- https://github.com/matplotlib/matplotlib/pull/11127
1111
- DPI issues for hi-dpi and `fig.set_dpi` and `fig.dpi` inconsistencies…
1212
- [#11227](https://github.com/matplotlib/matplotlib/issues/11227), [#11232](https://github.com/matplotlib/matplotlib/pull/11232),
13-
- @Jody K Methods to organize plotting hierarchy: #11026, #11010, #11234
13+
- @jklymak Methods to organize plotting hierarchy: #11026, #11010, #11234
1414
- Note new project aimed at axes_grid1 harmonization: https://github.com/matplotlib/matplotlib/projects/9
1515
- do we want this? Not attracting reviews…
16-
- @Tim H naming issues? In particular the set_*lim parameter names #11293
17-
- @Tim H naming conventions re methods: maybe inset_axes_rect #11026.
16+
- @timhoffm naming issues? In particular the set_*lim parameter names #11293
17+
- @timhoffm naming conventions re methods: maybe inset_axes_rect #11026.
1818

1919
## Notes
2020

@@ -26,18 +26,18 @@
2626
- min/max is consistent with r/theta
2727
- directional may be more strictly correct/accurate
2828
- replace name and use start/stop for everything
29-
- @Eric F xlim/xmin/xmax are horrible:
29+
- @efiring xlim/xmin/xmax are horrible:
3030
- xmin/xmax subset of xlim
3131
- min & max isn’t clear - positional or numerical -
3232
- for cartesian axis left & right are correct and unambiguous
33-
- @Eric F bbox methods confusing but use left, right, bottom, top
33+
- @efiring bbox methods confusing but use left, right, bottom, top
3434
- rlim directional would be inner/outer
3535
- theta lim - maybe use stop/start instead (would be consistent with normal range)
3636
- radial has clockwise and counterclockwise - figure out default direction?
3737
- ToDo:
3838
- look at situation with polar plots
3939
- look at transforms see if change needed for API consistency
40-
- check with @Thomas C for thoughts
40+
- check with @tacaswell for thoughts
4141
- formal deprecation or informal deprecation in documentation (new standards)
4242
- do a long term change in docs and warn people heavily - slow dep roll out
4343

@@ -116,7 +116,7 @@
116116
- `add_zoom_inset_indicator`?
117117

118118
- TODO: review https://github.com/matplotlib/matplotlib/pull/11127 determine if it needs https://github.com/matplotlib/matplotlib/pull/11127 a subclass scatter artist.
119-
- @Thomas C will review this week.
119+
- @tacaswell will review this week.
120120
- https://github.com/matplotlib/matplotlib/pull/10682:
121121
- TODO review before 3.0
122122

0 commit comments

Comments
 (0)